[PATCH] arm64: dts: rockchip: sapphire: add chosen node

[PATCH] arm64: dts: rockchip: sapphire: add chosen node

[Vicente Bergas]

In order to use earlycon, the stdout-path property needs to be set in
the chosen node.

---

Also, this works around this kexec bug:
http://lists.infradead.org/pipermail/kexec/2018-October/021746.html

Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
index 5a5806044..326615018 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
@@ -9,4 +9,8 @@
 / {
 	model = "Sapphire-RK3399 Board";
 	compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399";
+
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
 };
-- 
2.19.1

Re: [PATCH] arm64: dts: rockchip: sapphire: add chosen node

[Heiko Stuebner]

Hi Vicente,

Am Freitag, 26. Oktober 2018, 15:36:55 CET schrieb Vicente Bergas:
> In order to use earlycon, the stdout-path property needs to be set in
> the chosen node.
> 
> ---
> 
> Also, this works around this kexec bug:
> http://lists.infradead.org/pipermail/kexec/2018-October/021746.html
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> index 5a5806044..326615018 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts
> @@ -9,4 +9,8 @@
>  / {
>  	model = "Sapphire-RK3399 Board";
>  	compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399";
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};

shouldn't that maybe live in the shared .dtsi instead?
I do guess the excavator will have the same default serial?


Heiko

[PATCH v2] arm64: dts: rockchip: sapphire: add chosen node

[Vicente Bergas]

In order to use earlycon, the stdout-path property needs to be set in the chosen node.

---

Hi Heiko,

> shouldn't that maybe live in the shared .dtsi instead?
this v2 applies the change in the .dtsi as suggested.

> I do guess the excavator will have the same default serial?
Well, in fact it seems to me that serial2 is set as the default serial port
at the chip level, although there are some exceptions. But on the other hand
the baud rate is more free form.
So, as suggested, it could be a good compromise to put it at the
daugther-card level.

The point for working around the kexec bug is still valid, but with
the update from the maintainer it is not enough to fix everything:
http://lists.infradead.org/pipermail/kexec/2018-October/021762.html

Regards,
  Vicenç.

Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 5421e2376..2eb6489d4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -11,6 +11,10 @@
 / {
 	compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399";
 
+	chosen {
+		stdout-path = "serial2:1500000n8";
+	};
+
 	backlight: backlight {
 		compatible = "pwm-backlight";
 		brightness-levels = <
-- 
2.19.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH v2] arm64: dts: rockchip: sapphire: add chosen node

[Heiko Stuebner]

Am Dienstag, 30. Oktober 2018, 15:59:41 CET schrieb Vicente Bergas:
> In order to use earlycon, the stdout-path property needs to be set in the chosen node.
> 
> ---
> 
> Hi Heiko,
> 
> > shouldn't that maybe live in the shared .dtsi instead?
> this v2 applies the change in the .dtsi as suggested.
> 
> > I do guess the excavator will have the same default serial?
> Well, in fact it seems to me that serial2 is set as the default serial port
> at the chip level, although there are some exceptions. But on the other hand
> the baud rate is more free form.
> So, as suggested, it could be a good compromise to put it at the
> daugther-card level.
> 
> The point for working around the kexec bug is still valid, but with
> the update from the maintainer it is not enough to fix everything:
> http://lists.infradead.org/pipermail/kexec/2018-October/021762.html
> 
> Regards,
>   Vicenç.
> 
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

applied for 4.21

Thanks
Heiko