* [REGRESSION] PCI v5.5-rc1 breaks google kevin @ 2019-12-11 23:38 Vicente Bergas 2019-12-12 0:12 ` Robin Murphy 0 siblings, 1 reply; 7+ messages in thread From: Vicente Bergas @ 2019-12-11 23:38 UTC (permalink / raw) To: Bjorn Helgaas, Shawn Lin, Heiko Stuebner, Liam Girdwood, Mark Brown, Heiner Kallweit, "Rafael J. Wysocki" Cc: Lorenzo Pieralisi, Andrew Murray, Philipp Zabel, Andy Shevchenko, "Stefan Mätje", Frederick Lawler, Mika Westerberg, linux-pci, linux-kernel, linux-rockchip, linux-arm-kernel Hi, since v5.5-rc1 the google kevin chromebook does not boot. Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() unnecessary locking as the first bad commit. In order to revert it from v5.5-rc1 i had to also revert some dependencies: 5e0c21c75e8c08375a69710527e4a921b897cb7e aff5d0552da4055da3faa27ee4252e48bb1f5821 35efea32b26f9aacc99bf07e0d2cdfba2028b099 687aaf386aeb551130f31705ce40d1341047a936 72ea91afbfb08619696ccde610ee4d0d29cf4a1d 87e90283c94c76ee11d379ab5a0973382bbd0baf After reverting all of this, still no luck. So, either the results of git bisect are not to be trusted, or there are more bad commits. By "does not boot" i mean that the display fails to start and the display is the only output device, so debugging is quite difficult. v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI: # CONFIG_PCI is not set Regards, Vicente. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-11 23:38 [REGRESSION] PCI v5.5-rc1 breaks google kevin Vicente Bergas @ 2019-12-12 0:12 ` Robin Murphy 2019-12-12 0:52 ` Andrew Murray 0 siblings, 1 reply; 7+ messages in thread From: Robin Murphy @ 2019-12-12 0:12 UTC (permalink / raw) To: Vicente Bergas, Bjorn Helgaas, Shawn Lin, Heiko Stuebner, Liam Girdwood, Mark Brown, Heiner Kallweit, Rafael J. Wysocki Cc: Lorenzo Pieralisi, Frederick Lawler, linux-pci, linux-kernel, linux-rockchip, Philipp Zabel, Andrew Murray, Andy Shevchenko, Mika Westerberg, Stefan Mätje, linux-arm-kernel Hi Vicente, On 2019-12-11 11:38 pm, Vicente Bergas wrote: > Hi, > since v5.5-rc1 the google kevin chromebook does not boot. > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() > unnecessary locking > as the first bad commit. > > In order to revert it from v5.5-rc1 i had to also revert some dependencies: > 5e0c21c75e8c08375a69710527e4a921b897cb7e > aff5d0552da4055da3faa27ee4252e48bb1f5821 > 35efea32b26f9aacc99bf07e0d2cdfba2028b099 > 687aaf386aeb551130f31705ce40d1341047a936 > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d > 87e90283c94c76ee11d379ab5a0973382bbd0baf > After reverting all of this, still no luck. > So, either the results of git bisect are not to be trusted, or > there are more bad commits. > > By "does not boot" i mean that the display fails to start and > the display is the only output device, so debugging is quite difficult. Assuming it's a manifestation of the same PCI breakage that Enric and Lorenzo figured out, there's a proposed fix here: https://lkml.org/lkml/2019/12/11/199 Robin. > v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI: > # CONFIG_PCI is not set > > Regards, > Vicente. > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-12 0:12 ` Robin Murphy @ 2019-12-12 0:52 ` Andrew Murray 2019-12-12 14:16 ` Enric Balletbo Serra 0 siblings, 1 reply; 7+ messages in thread From: Andrew Murray @ 2019-12-12 0:52 UTC (permalink / raw) To: Robin Murphy Cc: Vicente Bergas, Bjorn Helgaas, Shawn Lin, Heiko Stuebner, Liam Girdwood, Mark Brown, Heiner Kallweit, Rafael J. Wysocki, Lorenzo Pieralisi, Frederick Lawler, linux-pci, linux-kernel, linux-rockchip, Philipp Zabel, Andy Shevchenko, Mika Westerberg, Stefan Mätje, linux-arm-kernel On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: > Hi Vicente, > > On 2019-12-11 11:38 pm, Vicente Bergas wrote: > > Hi, > > since v5.5-rc1 the google kevin chromebook does not boot. > > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() > > unnecessary locking > > as the first bad commit. > > > > In order to revert it from v5.5-rc1 i had to also revert some dependencies: > > 5e0c21c75e8c08375a69710527e4a921b897cb7e > > aff5d0552da4055da3faa27ee4252e48bb1f5821 > > 35efea32b26f9aacc99bf07e0d2cdfba2028b099 > > 687aaf386aeb551130f31705ce40d1341047a936 > > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d > > 87e90283c94c76ee11d379ab5a0973382bbd0baf > > After reverting all of this, still no luck. > > So, either the results of git bisect are not to be trusted, or > > there are more bad commits. > > > > By "does not boot" i mean that the display fails to start and > > the display is the only output device, so debugging is quite difficult. > > Assuming it's a manifestation of the same PCI breakage that Enric and > Lorenzo figured out, there's a proposed fix here: > https://lkml.org/lkml/2019/12/11/199 It's likely that any PCI driver that uses PCI IO with that controller will suffer the same fate. Vicente - can you try the patch that has been proposed and verify it fixes the issue for you? Thanks, Andrew Murray > > Robin. > > > v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI: > > # CONFIG_PCI is not set > > > > Regards, > > Vicente. > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-12 0:52 ` Andrew Murray @ 2019-12-12 14:16 ` Enric Balletbo Serra 2019-12-12 18:40 ` Vicente Bergas 0 siblings, 1 reply; 7+ messages in thread From: Enric Balletbo Serra @ 2019-12-12 14:16 UTC (permalink / raw) To: Andrew Murray Cc: Robin Murphy, Lorenzo Pieralisi, Heiko Stuebner, Frederick Lawler, linux-pci, Shawn Lin, Rafael J. Wysocki, Liam Girdwood, Vicente Bergas, linux-kernel, open list:ARM/Rockchip SoC..., Mark Brown, Philipp Zabel, Bjorn Helgaas, Andy Shevchenko, Mika Westerberg, Stefan Mätje, Linux ARM Hi Vicente, Missatge de Andrew Murray <andrew.murray@arm.com> del dia dj., 12 de des. 2019 a les 1:53: > > On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: > > Hi Vicente, > > > > On 2019-12-11 11:38 pm, Vicente Bergas wrote: > > > Hi, > > > since v5.5-rc1 the google kevin chromebook does not boot. > > > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() > > > unnecessary locking > > > as the first bad commit. > > > > > > In order to revert it from v5.5-rc1 i had to also revert some dependencies: > > > 5e0c21c75e8c08375a69710527e4a921b897cb7e > > > aff5d0552da4055da3faa27ee4252e48bb1f5821 > > > 35efea32b26f9aacc99bf07e0d2cdfba2028b099 > > > 687aaf386aeb551130f31705ce40d1341047a936 > > > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d > > > 87e90283c94c76ee11d379ab5a0973382bbd0baf > > > After reverting all of this, still no luck. > > > So, either the results of git bisect are not to be trusted, or > > > there are more bad commits. > > > > > > By "does not boot" i mean that the display fails to start and > > > the display is the only output device, so debugging is quite difficult. > > Another issue that is affecting current mainline for kevin is fixed with [1]. As usual, I have a tracking branch for 5.5 for different Chromebooks with some not yet merged patches that makes things work while are not fixed [2]. For kevin only the mentioned ASoC patch [1] and the pcie fix [3] should be needed. Other than that display is working for me on Kevin. Cheers, Enric [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.5&id=4bf2e385aa59c2fae5f880aa25cfd2b470109093 [2] https://gitlab.collabora.com/eballetbo/linux/commits/topic/chromeos/somewhat-stable-5.5 [3] https://lkml.org/lkml/2019/12/11/199 > > Assuming it's a manifestation of the same PCI breakage that Enric and > > Lorenzo figured out, there's a proposed fix here: > > https://lkml.org/lkml/2019/12/11/199 > > It's likely that any PCI driver that uses PCI IO with that controller will > suffer the same fate. > > Vicente - can you try the patch that has been proposed and verify it fixes > the issue for you? > > Thanks, > > Andrew Murray > > > > > Robin. > > > > > v5.5-rc1 as is (reverting no commits at all) works fine when disabling PCI: > > > # CONFIG_PCI is not set > > > > > > Regards, > > > Vicente. > > > > > > > > > _______________________________________________ > > > Linux-rockchip mailing list > > > Linux-rockchip@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-12 14:16 ` Enric Balletbo Serra @ 2019-12-12 18:40 ` Vicente Bergas 2019-12-12 20:39 ` Andrew Murray 0 siblings, 1 reply; 7+ messages in thread From: Vicente Bergas @ 2019-12-12 18:40 UTC (permalink / raw) To: Enric Balletbo Serra, Andrew Murray, Robin Murphy Cc: Lorenzo Pieralisi, Heiko Stuebner, Frederick Lawler, linux-pci, Shawn Lin, Rafael J. Wysocki, Liam Girdwood, linux-kernel, open list:ARM/Rockchip SoC..., Mark Brown, Philipp Zabel, Bjorn Helgaas, Andy Shevchenko, Mika Westerberg, Stefan Mätje, Linux ARM, Heiner Kallweit On Thursday, December 12, 2019 3:16:25 PM CET, Enric Balletbo Serra wrote: > Hi Vicente, > > Missatge de Andrew Murray <andrew.murray@arm.com> del dia dj., 12 de > des. 2019 a les 1:53: >> >> On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: >>> Hi Vicente, >>> >>> On 2019-12-11 11:38 pm, Vicente Bergas wrote: >>>> Hi, >>>> since v5.5-rc1 the google kevin chromebook does not boot. >>>> Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() >>>> unnecessary locking >>>> as the first bad commit. >>>> >>>> In order to revert it from v5.5-rc1 i had to also revert >>>> some dependencies: >>>> 5e0c21c75e8c08375a69710527e4a921b897cb7e >>>> aff5d0552da4055da3faa27ee4252e48bb1f5821 >>>> 35efea32b26f9aacc99bf07e0d2cdfba2028b099 >>>> 687aaf386aeb551130f31705ce40d1341047a936 >>>> 72ea91afbfb08619696ccde610ee4d0d29cf4a1d >>>> 87e90283c94c76ee11d379ab5a0973382bbd0baf >>>> After reverting all of this, still no luck. >>>> So, either the results of git bisect are not to be trusted, or >>>> there are more bad commits. >>>> >>>> By "does not boot" i mean that the display fails to start and >>>> the display is the only output device, so debugging is quite difficult. >>> > > Another issue that is affecting current mainline for kevin is fixed > with [1]. As usual, I have a tracking branch for 5.5 for different > Chromebooks with some not yet merged patches that makes things work > while are not fixed [2]. For kevin only the mentioned ASoC patch [1] > and the pcie fix [3] should be needed. Other than that display is > working for me on Kevin. > > Cheers, > Enric > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.5&id=4bf2e385aa59c2fae5f880aa25cfd2b470109093 > [2] > https://gitlab.collabora.com/eballetbo/linux/commits/topic/chromeos/somewhat-stable-5.5 > [3] https://lkml.org/lkml/2019/12/11/199 > >>> Assuming it's a manifestation of the same PCI breakage that Enric and >>> Lorenzo figured out, there's a proposed fix here: >>> https://lkml.org/lkml/2019/12/11/199 >> >> It's likely that any PCI driver that uses PCI IO with that controller will >> suffer the same fate. >> >> Vicente - can you try the patch that has been proposed and verify it fixes >> the issue for you? >> >> Thanks, >> >> Andrew Murray >> >>> >>> Robin. >>> >>>> v5.5-rc1 as is (reverting no commits at all) works fine when >>>> disabling PCI: >>>> # CONFIG_PCI is not set >>>> >>>> Regards, >>>> Vicente. Hi Robin, Andrew and Enric, thank you all for the quick responses! I can confirm that patch [3] fixes the issue reported in this email and that [1] fixes the other issue reported on the other email. Regards, Vicenç. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-12 18:40 ` Vicente Bergas @ 2019-12-12 20:39 ` Andrew Murray 2019-12-12 20:48 ` Vicente Bergas 0 siblings, 1 reply; 7+ messages in thread From: Andrew Murray @ 2019-12-12 20:39 UTC (permalink / raw) To: Vicente Bergas Cc: Enric Balletbo Serra, Robin Murphy, Lorenzo Pieralisi, Heiko Stuebner, Frederick Lawler, linux-pci, Shawn Lin, Rafael J. Wysocki, Liam Girdwood, linux-kernel, open list:ARM/Rockchip SoC..., Mark Brown, Philipp Zabel, Bjorn Helgaas, Andy Shevchenko, Mika Westerberg, Stefan Mätje, Linux ARM On Thu, Dec 12, 2019 at 07:40:06PM +0100, Vicente Bergas wrote: > On Thursday, December 12, 2019 3:16:25 PM CET, Enric Balletbo Serra wrote: > > Hi Vicente, > > > > Missatge de Andrew Murray <andrew.murray@arm.com> del dia dj., 12 de > > des. 2019 a les 1:53: > > > > > > On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: > > > > Hi Vicente, > > > > > > > > On 2019-12-11 11:38 pm, Vicente Bergas wrote: > > > > > Hi, > > > > > since v5.5-rc1 the google kevin chromebook does not boot. > > > > > Git bisect reports 5e0c21c75e8c PCI/ASPM: Remove pcie_aspm_enabled() > > > > > unnecessary locking > > > > > as the first bad commit. > > > > > > > > > > In order to revert it from v5.5-rc1 i had to also revert > > > > > some dependencies: > > > > > 5e0c21c75e8c08375a69710527e4a921b897cb7e > > > > > aff5d0552da4055da3faa27ee4252e48bb1f5821 > > > > > 35efea32b26f9aacc99bf07e0d2cdfba2028b099 > > > > > 687aaf386aeb551130f31705ce40d1341047a936 > > > > > 72ea91afbfb08619696ccde610ee4d0d29cf4a1d > > > > > 87e90283c94c76ee11d379ab5a0973382bbd0baf > > > > > After reverting all of this, still no luck. > > > > > So, either the results of git bisect are not to be trusted, or > > > > > there are more bad commits. > > > > > > > > > > By "does not boot" i mean that the display fails to start and > > > > > the display is the only output device, so debugging is quite difficult. > > > > > > > > Another issue that is affecting current mainline for kevin is fixed > > with [1]. As usual, I have a tracking branch for 5.5 for different > > Chromebooks with some not yet merged patches that makes things work > > while are not fixed [2]. For kevin only the mentioned ASoC patch [1] > > and the pcie fix [3] should be needed. Other than that display is > > working for me on Kevin. > > > > Cheers, > > Enric > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.5&id=4bf2e385aa59c2fae5f880aa25cfd2b470109093 > > [2] https://gitlab.collabora.com/eballetbo/linux/commits/topic/chromeos/somewhat-stable-5.5 > > [3] https://lkml.org/lkml/2019/12/11/199 > > > > > > Assuming it's a manifestation of the same PCI breakage that Enric and > > > > Lorenzo figured out, there's a proposed fix here: > > > > https://lkml.org/lkml/2019/12/11/199 > > > > > > It's likely that any PCI driver that uses PCI IO with that controller will > > > suffer the same fate. > > > > > > Vicente - can you try the patch that has been proposed and verify it fixes > > > the issue for you? > > > > > > Thanks, > > > > > > Andrew Murray > > > > > > > > > > > Robin. > > > > > > > > > v5.5-rc1 as is (reverting no commits at all) works fine when > > > > > disabling PCI: > > > > > # CONFIG_PCI is not set > > > > > > > > > > Regards, > > > > > Vicente. > > Hi Robin, Andrew and Enric, > thank you all for the quick responses! > I can confirm that patch [3] fixes the issue reported in this email and > that [1] fixes the other issue reported on the other email. Pleased to hear this is working for you now. Are you happy to give a tested-by tag for [3]? Thanks, Andrew Murray > > Regards, > Vicenç. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [REGRESSION] PCI v5.5-rc1 breaks google kevin 2019-12-12 20:39 ` Andrew Murray @ 2019-12-12 20:48 ` Vicente Bergas 0 siblings, 0 replies; 7+ messages in thread From: Vicente Bergas @ 2019-12-12 20:48 UTC (permalink / raw) To: Andrew Murray Cc: Enric Balletbo Serra, Robin Murphy, Lorenzo Pieralisi, Heiko Stuebner, Frederick Lawler, linux-pci, Shawn Lin, Rafael J. Wysocki, Liam Girdwood, linux-kernel, open list:ARM/Rockchip SoC..., Mark Brown, Philipp Zabel, Bjorn Helgaas, Andy Shevchenko, Mika Westerberg, Stefan Mätje, Linux ARM On Thursday, December 12, 2019 9:39:27 PM CET, Andrew Murray wrote: > On Thu, Dec 12, 2019 at 07:40:06PM +0100, Vicente Bergas wrote: >> On Thursday, December 12, 2019 3:16:25 PM CET, Enric Balletbo Serra wrote: >>> Hi Vicente, >>> >>> Missatge de Andrew Murray <andrew.murray@arm.com> del dia dj., 12 de >>> des. 2019 a les 1:53: >>>> On Thu, Dec 12, 2019 at 12:12:56AM +0000, Robin Murphy wrote: ... >>> >>> Another issue that is affecting current mainline for kevin is fixed >>> with [1]. As usual, I have a tracking branch for 5.5 for different >>> Chromebooks with some not yet merged patches that makes things work >>> while are not fixed [2]. For kevin only the mentioned ASoC patch [1] >>> and the pcie fix [3] should be needed. Other than that display is >>> working for me on Kevin. >>> >>> Cheers, >>> Enric >>> >>> [1] >>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-5.5&id=4bf2e385aa59c2fae5f880aa25cfd2b470109093 >>> [2] >>> https://gitlab.collabora.com/eballetbo/linux/commits/topic/chromeos/somewhat-stable-5.5 >>> [3] https://lkml.org/lkml/2019/12/11/199 >>> >>>>> ... >>>> It's likely that any PCI driver that uses PCI IO with that >>>> controller will >>>> suffer the same fate. >>>> >>>> Vicente - can you try the patch that has been proposed and >>>> verify it fixes >>>> the issue for you? >>>> >>>> Thanks, ... >> >> Hi Robin, Andrew and Enric, >> thank you all for the quick responses! >> I can confirm that patch [3] fixes the issue reported in this email and >> that [1] fixes the other issue reported on the other email. > > Pleased to hear this is working for you now. > > Are you happy to give a tested-by tag for [3]? Yes, feel free to apply this tag. Using it just now and the wlan at the other side of the PCIe bus is detected. Regards, Vicente. > Thanks, > > Andrew Murray > >> >> Regards, >> Vicenç. >> > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-12 20:48 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-11 23:38 [REGRESSION] PCI v5.5-rc1 breaks google kevin Vicente Bergas 2019-12-12 0:12 ` Robin Murphy 2019-12-12 0:52 ` Andrew Murray 2019-12-12 14:16 ` Enric Balletbo Serra 2019-12-12 18:40 ` Vicente Bergas 2019-12-12 20:39 ` Andrew Murray 2019-12-12 20:48 ` Vicente Bergas
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox