From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-rockchip@lists.infradead.org, Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH 03/15] arm64: dts: rockchip: add status LED to opi5max
Date: Sun, 27 Oct 2024 20:45:49 +0100 [thread overview]
Message-ID: <5b170e1d-2540-4895-ae87-be38060fedb3@kernel.org> (raw)
In-Reply-To: <CALWfF7JhoZAkMBjC=4BUyQevvKD-9oTeRO3VftqjHskXJEkQGA@mail.gmail.com>
On 26/10/2024 22:17, Jimmy Hon wrote:
> leds, it's tempting to use the leds-pwm-multicolor. However, the RED
> portion is hardwired on when the power is on and not connected to PWM.
>
> I still have some more functions that I'm working on (i.e. WIFi), so
> those commits are not ready. I'm afraid that the Android BCMDHD driver
> may need DTS nodes that are different from the DTS nodes the bcrmfmac
> driver would use.
>
> Anyways, should I squash the commits together in the new revision? I
> was able to test the majority of the functionality, I don't have the
> additional hardware to test fan, rtc, and eMMC.
That's what I would expect. Look at qcom commits. First publish of new
SoC is one commit, new board is another one. Feel free to grow it later
(release early, release often), but that's not the case here.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-10-27 19:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 9:48 [PATCH v1 0/15] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2024-10-26 9:48 ` [PATCH 01/15] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Max Jimmy Hon
2024-10-26 17:58 ` Krzysztof Kozlowski
2024-10-26 9:48 ` [PATCH 02/15] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2024-10-26 9:48 ` [PATCH 03/15] arm64: dts: rockchip: add status LED to opi5max Jimmy Hon
2024-10-26 17:59 ` Krzysztof Kozlowski
2024-10-26 20:17 ` Jimmy Hon
2024-10-27 19:45 ` Krzysztof Kozlowski [this message]
2024-10-26 9:48 ` [PATCH 04/15] arm64: dts: rockchip: Enable RTC support for opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 05/15] arm64: dts: rockchip: add PCIe network controller to opi5max Jimmy Hon
2024-10-26 20:29 ` Jimmy Hon
2024-10-26 9:48 ` [PATCH 06/15] arm64: dts: rockchip: add PCIe for M.2 M-key " Jimmy Hon
2024-10-26 9:48 ` [PATCH 07/15] arm64: dts: rockchip: add fan support " Jimmy Hon
2024-10-26 9:48 ` [PATCH 08/15] arm64: dts: rockchip: add USB2 " Jimmy Hon
2024-10-26 9:48 ` [PATCH 09/15] arm64: dts: rockchip: add lower USB3 port " Jimmy Hon
2024-10-26 20:40 ` Jimmy Hon
2024-10-26 20:49 ` Jimmy Hon
2024-10-26 9:48 ` [PATCH 10/15] arm64: dts: rockchip: add upper " Jimmy Hon
2024-10-26 9:48 ` [PATCH 11/15] arm64: dts: rockchip: Enable GPU on opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 12/15] arm64: dts: rockchip: add SFC support for opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 13/15] arm64: dts: rockchip: ADC button " Jimmy Hon
2024-10-26 9:48 ` [PATCH 14/15] arm64: dts: rockchip: analog audio on opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 15/15] arm64: dts: rockchip: Enable HDMI0 " Jimmy Hon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b170e1d-2540-4895-ae87-be38060fedb3@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox