From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jimmy Hon <honyuenkwun@gmail.com>, Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-rockchip@lists.infradead.org, Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH 03/15] arm64: dts: rockchip: add status LED to opi5max
Date: Sat, 26 Oct 2024 19:59:01 +0200 [thread overview]
Message-ID: <eb6956d3-27f5-416d-a3d2-26a4b2d940fc@kernel.org> (raw)
In-Reply-To: <20241026100310.52679-4-honyuenkwun@gmail.com>
On 26/10/2024 11:48, Jimmy Hon wrote:
> Describe the Orange Pi 5 Max 2 status LEDs in its device tree.
>
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> ---
> .../dts/rockchip/rk3588-orangepi-5-max.dts | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts
> index 53a34cb37487..83a118e52bb0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-max.dts
This is a new board. Why do you add incomplete board in first patch?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-10-26 17:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 9:48 [PATCH v1 0/15] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2024-10-26 9:48 ` [PATCH 01/15] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Max Jimmy Hon
2024-10-26 17:58 ` Krzysztof Kozlowski
2024-10-26 9:48 ` [PATCH 02/15] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2024-10-26 9:48 ` [PATCH 03/15] arm64: dts: rockchip: add status LED to opi5max Jimmy Hon
2024-10-26 17:59 ` Krzysztof Kozlowski [this message]
2024-10-26 20:17 ` Jimmy Hon
2024-10-27 19:45 ` Krzysztof Kozlowski
2024-10-26 9:48 ` [PATCH 04/15] arm64: dts: rockchip: Enable RTC support for opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 05/15] arm64: dts: rockchip: add PCIe network controller to opi5max Jimmy Hon
2024-10-26 20:29 ` Jimmy Hon
2024-10-26 9:48 ` [PATCH 06/15] arm64: dts: rockchip: add PCIe for M.2 M-key " Jimmy Hon
2024-10-26 9:48 ` [PATCH 07/15] arm64: dts: rockchip: add fan support " Jimmy Hon
2024-10-26 9:48 ` [PATCH 08/15] arm64: dts: rockchip: add USB2 " Jimmy Hon
2024-10-26 9:48 ` [PATCH 09/15] arm64: dts: rockchip: add lower USB3 port " Jimmy Hon
2024-10-26 20:40 ` Jimmy Hon
2024-10-26 20:49 ` Jimmy Hon
2024-10-26 9:48 ` [PATCH 10/15] arm64: dts: rockchip: add upper " Jimmy Hon
2024-10-26 9:48 ` [PATCH 11/15] arm64: dts: rockchip: Enable GPU on opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 12/15] arm64: dts: rockchip: add SFC support for opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 13/15] arm64: dts: rockchip: ADC button " Jimmy Hon
2024-10-26 9:48 ` [PATCH 14/15] arm64: dts: rockchip: analog audio on opi5max Jimmy Hon
2024-10-26 9:48 ` [PATCH 15/15] arm64: dts: rockchip: Enable HDMI0 " Jimmy Hon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb6956d3-27f5-416d-a3d2-26a4b2d940fc@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=megi@xff.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox