* [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple
@ 2024-08-28 8:45 Jacobe Zang
2024-08-28 8:45 ` [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Jacobe Zang @ 2024-08-28 8:45 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Hector Martin, Sven Peter, Alyssa Rosenzweig
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi,
Jacobe Zang, Muhammed Efe Cetin, Arend van Spriel
Add basic Wi-Fi support on Khadas Edge2. Wireless driver need to check "brcm,bcm4329-fmac"
compatible so add it to Apple's devices.
Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
---
Changes in v13:
- Change patch 2/2 argument from driver to bindings.
- Link to v12: https://lore.kernel.org/all/20240828033953.967649-1-jacobe.zang@wesion.com/
Changes in v12:
- Add fallback compatible for Apple's devices
- Link to v11: https://lore.kernel.org/all/20240816015214.1271162-1-jacobe.zang@wesion.com/
Changes in v11:
- Split DTS and submit separately
- Link to v10: https://lore.kernel.org/all/20240813082007.2625841-1-jacobe.zang@wesion.com/
Changes in v10:
- Use ret instead unused probe_attach_result in sdio.c
- Link to v9: https://lore.kernel.org/all/20240810035141.439024-1-jacobe.zang@wesion.com/
Changes in v9:
- Add return -ENODEV error pointer from brcmf_sdio_probe as the default for the fail path
- Add if statement for brcmf_of_probe in common.c
- Retain modifications to of.c other than the return values
- Link to v8: https://lore.kernel.org/all/20240805073425.3492078-1-jacobe.zang@wesion.com/
Changes in v8:
- Add appropriate errno's for return values that will be
send to bus when error occurred.
- Link to v7: https://lore.kernel.org/all/20240802025715.2360456-1-jacobe.zang@wesion.com/
Changes in v7:
- Change brcmf_of_probe prototypes from void to int, add appropriate errno's for return
value, move clock check to the end of brcmf_of_probe
- Add "brcm,bcm4329-fmac" compatible for wifi node
- Link to v6: https://lore.kernel.org/all/20240731061132.703368-1-jacobe.zang@wesion.com/
Changes in v6:
- Move "brcm,bcm4329-fmac" check to the top of brcmf_of_probe in of.c
- Add return if clk didn't set in DTS
-Link to v5: https://lore.kernel.org/all/20240730033053.4092132-1-jacobe.zang@wesion.com/
Changes in v5:
- Add more commit message to the clock in bindings
- Use IS_ERR_OR_NULL as a judgment condition of clk
- Link to v4: https://lore.kernel.org/all/20240729070102.3770318-1-jacobe.zang@wesion.com/
Changes in v4:
- Change clock description in dt-bindings
- Move enable clk from pcie.c to of.c
- Add compatible for wifi node in DTS
- Add random seed flag for firmware download
- Link to v3: https://lore.kernel.org/all/20240630073605.2164346-1-jacobe.zang@wesion.com/
Changes in v3:
- Dropped redundant parts in dt-bindings.
- Change driver patch title prefix as 'wifi: brcmfmac:'.
- Change DTS Wi-Fi node clock-name as 'lpo'.
- Link to v2: https://lore.kernel.org/all/20240624081906.1399447-1-jacobe.zang@wesion.com/
Changes in v2:
- Add SoB tags for original developer.
- Add dt-bindings for pci14e4,449d and clocks.
- Replace dev_info to brcmf_dbg in pcie.c
- Link to v1: https://lore.kernel.org/all/20240620020015.4021696-1-jacobe.zang@wesion.com/
---
Jacobe Zang (2):
arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2
arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible
arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +-
arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +-
arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +-
arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 16 ++++++++++++++++
4 files changed, 19 insertions(+), 3 deletions(-)
---
base-commit: dabcfd5e116800496eb9bec2ba7c015ca2043aa0
change-id: 20240828-dts-1b163375c49c
Best regards,
--
Jacobe Zang <jacobe.zang@wesion.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang @ 2024-08-28 8:45 ` Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible Jacobe Zang ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Jacobe Zang @ 2024-08-28 8:45 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi, Jacobe Zang, Muhammed Efe Cetin, Arend van Spriel Khadas Edge2 uses the PCI-e Ampak AP6275P 2T2R Wi-Fi 6 module. The pcie@0 node can be used as Bridge1, so the wifi@0 node is used as a device under the Bridge1. Co-developed-by: Muhammed Efe Cetin <efectn@protonmail.com> Signed-off-by: Muhammed Efe Cetin <efectn@protonmail.com> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> --- arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts index dbddfc3bb4641..3d0f55c123d92 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts @@ -283,6 +283,22 @@ &pcie2x1l2 { reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>; vpcie3v3-supply = <&vcc3v3_pcie_wl>; status = "okay"; + + pcie@0,0 { + reg = <0x400000 0 0 0 0>; + #address-cells = <3>; + #size-cells = <2>; + ranges; + device_type = "pci"; + bus-range = <0x40 0x4f>; + + wifi: wifi@0,0 { + compatible = "pci14e4,449d", "brcm,bcm4329-fmac"; + reg = <0x410000 0 0 0 0>; + clocks = <&hym8563>; + clock-names = "lpo"; + }; + }; }; &pwm11 { -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible 2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang @ 2024-08-28 8:45 ` Jacobe Zang 2024-08-28 13:02 ` Krzysztof Kozlowski 2024-08-28 8:55 ` [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Arend van Spriel 2024-08-28 12:51 ` Rob Herring (Arm) 3 siblings, 1 reply; 8+ messages in thread From: Jacobe Zang @ 2024-08-28 8:45 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi, Jacobe Zang Wi-Fi compatible in these DTS is based on PCI ID. Bindings need "brcm,bcm4329-fmac" as fallback compatible. Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> --- arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi index 5988a4eb6efaa..4b021626d4692 100644 --- a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi +++ b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi @@ -72,7 +72,7 @@ hpm1: usb-pd@3f { &port00 { bus-range = <1 1>; wifi0: network@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00]; diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts index 6f69658623bf8..df2a63d8dd5e9 100644 --- a/arch/arm64/boot/dts/apple/t8112-j413.dts +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4433"; + compatible = "pci14e4,4433", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 10 18 00 00 10]; diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts index 0ad908349f554..5f3453e109b85 100644 --- a/arch/arm64/boot/dts/apple/t8112-j493.dts +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00]; -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible 2024-08-28 8:45 ` [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible Jacobe Zang @ 2024-08-28 13:02 ` Krzysztof Kozlowski 2024-08-28 13:16 ` Jacobe Zang 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-08-28 13:02 UTC (permalink / raw) To: Jacobe Zang, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi On 28/08/2024 10:45, Jacobe Zang wrote: > Wi-Fi compatible in these DTS is based on PCI ID. Bindings need > "brcm,bcm4329-fmac" as fallback compatible. > > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- > arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- > arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Bindings are being questioned, so link to them in changelog section would help the maintainers to decide when to apply it. I am not convinced this is correct bindings change, thus this DTS should wait. Your previous patch also misses link to bindings. Whenever you split DTS to separate series, please always provide link to the bindings, so people will have the context. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible 2024-08-28 13:02 ` Krzysztof Kozlowski @ 2024-08-28 13:16 ` Jacobe Zang 0 siblings, 0 replies; 8+ messages in thread From: Jacobe Zang @ 2024-08-28 13:16 UTC (permalink / raw) To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi On 2024/8/28 21:02, Krzysztof Kozlowski wrote: > On 28/08/2024 10:45, Jacobe Zang wrote: >> Wi-Fi compatible in these DTS is based on PCI ID. Bindings need >> "brcm,bcm4329-fmac" as fallback compatible. >> >> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> >> --- >> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- >> arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- >> arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > Bindings are being questioned, so link to them in changelog section > would help the maintainers to decide when to apply it. > > I am not convinced this is correct bindings change, thus this DTS should > wait. > > Your previous patch also misses link to bindings. Whenever you split DTS > to separate series, please always provide link to the bindings, so > people will have the context. > Sure. I will post the link in changelog next time. -- Best Regards Jacobe _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple 2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible Jacobe Zang @ 2024-08-28 8:55 ` Arend van Spriel 2024-08-28 9:09 ` Jacobe Zang 2024-08-28 12:51 ` Rob Herring (Arm) 3 siblings, 1 reply; 8+ messages in thread From: Arend van Spriel @ 2024-08-28 8:55 UTC (permalink / raw) To: Jacobe Zang, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi, Muhammed Efe Cetin On 8/28/2024 10:45 AM, Jacobe Zang wrote: > Add basic Wi-Fi support on Khadas Edge2. Wireless driver need to check "brcm,bcm4329-fmac" > compatible so add it to Apple's devices. Did not receive [PATCH v13 2/2]. I don't follow every kernel list. Maybe good to add linux-wireless list? Regards, Arend > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > Changes in v13: > - Change patch 2/2 argument from driver to bindings. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple 2024-08-28 8:55 ` [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Arend van Spriel @ 2024-08-28 9:09 ` Jacobe Zang 0 siblings, 0 replies; 8+ messages in thread From: Jacobe Zang @ 2024-08-28 9:09 UTC (permalink / raw) To: Arend van Spriel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Hector Martin, Sven Peter, Alyssa Rosenzweig Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel, asahi, Muhammed Efe Cetin On 2024/8/28 16:55, Arend van Spriel wrote: > On 8/28/2024 10:45 AM, Jacobe Zang wrote: >> Add basic Wi-Fi support on Khadas Edge2. Wireless driver need to check >> "brcm,bcm4329-fmac" >> compatible so add it to Apple's devices. > > Did not receive [PATCH v13 2/2]. I don't follow every kernel list. Maybe > good to add linux-wireless list? Just now in your reply said the compatible should not be added. So 2/2 patch is also dropped. Maybe the patch is about DTS, so b4 didn't include linux-wireless, need to be added manually. > > Regards, > Arend > >> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> >> --- >> Changes in v13: >> - Change patch 2/2 argument from driver to bindings. -- Best Regards Jacobe _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple 2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang ` (2 preceding siblings ...) 2024-08-28 8:55 ` [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Arend van Spriel @ 2024-08-28 12:51 ` Rob Herring (Arm) 3 siblings, 0 replies; 8+ messages in thread From: Rob Herring (Arm) @ 2024-08-28 12:51 UTC (permalink / raw) To: Jacobe Zang Cc: Krzysztof Kozlowski, Alyssa Rosenzweig, linux-arm-kernel, asahi, Muhammed Efe Cetin, Arend van Spriel, Conor Dooley, devicetree, Heiko Stuebner, linux-rockchip, Hector Martin, Sven Peter, linux-kernel On Wed, 28 Aug 2024 16:45:39 +0800, Jacobe Zang wrote: > Add basic Wi-Fi support on Khadas Edge2. Wireless driver need to check "brcm,bcm4329-fmac" > compatible so add it to Apple's devices. > > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > Changes in v13: > - Change patch 2/2 argument from driver to bindings. > > - Link to v12: https://lore.kernel.org/all/20240828033953.967649-1-jacobe.zang@wesion.com/ > > Changes in v12: > - Add fallback compatible for Apple's devices > > - Link to v11: https://lore.kernel.org/all/20240816015214.1271162-1-jacobe.zang@wesion.com/ > > Changes in v11: > - Split DTS and submit separately > > - Link to v10: https://lore.kernel.org/all/20240813082007.2625841-1-jacobe.zang@wesion.com/ > > Changes in v10: > - Use ret instead unused probe_attach_result in sdio.c > > - Link to v9: https://lore.kernel.org/all/20240810035141.439024-1-jacobe.zang@wesion.com/ > > Changes in v9: > - Add return -ENODEV error pointer from brcmf_sdio_probe as the default for the fail path > - Add if statement for brcmf_of_probe in common.c > - Retain modifications to of.c other than the return values > > - Link to v8: https://lore.kernel.org/all/20240805073425.3492078-1-jacobe.zang@wesion.com/ > > Changes in v8: > - Add appropriate errno's for return values that will be > send to bus when error occurred. > > - Link to v7: https://lore.kernel.org/all/20240802025715.2360456-1-jacobe.zang@wesion.com/ > > Changes in v7: > - Change brcmf_of_probe prototypes from void to int, add appropriate errno's for return > value, move clock check to the end of brcmf_of_probe > - Add "brcm,bcm4329-fmac" compatible for wifi node > > - Link to v6: https://lore.kernel.org/all/20240731061132.703368-1-jacobe.zang@wesion.com/ > > Changes in v6: > - Move "brcm,bcm4329-fmac" check to the top of brcmf_of_probe in of.c > - Add return if clk didn't set in DTS > > -Link to v5: https://lore.kernel.org/all/20240730033053.4092132-1-jacobe.zang@wesion.com/ > > Changes in v5: > - Add more commit message to the clock in bindings > - Use IS_ERR_OR_NULL as a judgment condition of clk > > - Link to v4: https://lore.kernel.org/all/20240729070102.3770318-1-jacobe.zang@wesion.com/ > > Changes in v4: > - Change clock description in dt-bindings > - Move enable clk from pcie.c to of.c > - Add compatible for wifi node in DTS > - Add random seed flag for firmware download > > - Link to v3: https://lore.kernel.org/all/20240630073605.2164346-1-jacobe.zang@wesion.com/ > > Changes in v3: > - Dropped redundant parts in dt-bindings. > - Change driver patch title prefix as 'wifi: brcmfmac:'. > - Change DTS Wi-Fi node clock-name as 'lpo'. > > - Link to v2: https://lore.kernel.org/all/20240624081906.1399447-1-jacobe.zang@wesion.com/ > > Changes in v2: > - Add SoB tags for original developer. > - Add dt-bindings for pci14e4,449d and clocks. > - Replace dev_info to brcmf_dbg in pcie.c > > - Link to v1: https://lore.kernel.org/all/20240620020015.4021696-1-jacobe.zang@wesion.com/ > > --- > Jacobe Zang (2): > arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 > arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible > > arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- > arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- > arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts | 16 ++++++++++++++++ > 4 files changed, 19 insertions(+), 3 deletions(-) > --- > base-commit: dabcfd5e116800496eb9bec2ba7c015ca2043aa0 > change-id: 20240828-dts-1b163375c49c > > Best regards, > -- > Jacobe Zang <jacobe.zang@wesion.com> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y apple/t8112-j413.dtb apple/t8112-j493.dtb rockchip/rk3588s-khadas-edge2.dtb' for 20240828-dts-v13-0-6bff9896d649@wesion.com: arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dtb: wifi@0,0: compatible: 'oneOf' conditional failed, one must be fixed: ['pci14e4,449d', 'brcm,bcm4329-fmac'] is too long 'pci14e4,449d' is not one of ['brcm,bcm43143-fmac', 'brcm,bcm4341b0-fmac', 'brcm,bcm4341b4-fmac', 'brcm,bcm4341b5-fmac', 'brcm,bcm4329-fmac', 'brcm,bcm4330-fmac', 'brcm,bcm4334-fmac', 'brcm,bcm43340-fmac', 'brcm,bcm4335-fmac', 'brcm,bcm43362-fmac', 'brcm,bcm4339-fmac', 'brcm,bcm43430a0-fmac', 'brcm,bcm43430a1-fmac', 'brcm,bcm43455-fmac', 'brcm,bcm43456-fmac', 'brcm,bcm4354-fmac', 'brcm,bcm4356-fmac', 'brcm,bcm4359-fmac', 'brcm,bcm4366-fmac', 'cypress,cyw4373-fmac', 'cypress,cyw43012-fmac', 'infineon,cyw43439-fmac'] 'pci14e4,449d' is not one of ['brcm,bcm4329-fmac', 'pci14e4,43dc', 'pci14e4,4464', 'pci14e4,4488', 'pci14e4,4425', 'pci14e4,4433'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dtb: wifi@0,0: Unevaluated properties are not allowed ('clock-names', 'clocks', 'compatible' were unexpected) from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/apple/t8112-j493.dtb: wifi@0,0: compatible: 'oneOf' conditional failed, one must be fixed: ['pci14e4,4425', 'brcm,bcm4329-fmac'] is too long 'pci14e4,4425' is not one of ['brcm,bcm43143-fmac', 'brcm,bcm4341b0-fmac', 'brcm,bcm4341b4-fmac', 'brcm,bcm4341b5-fmac', 'brcm,bcm4329-fmac', 'brcm,bcm4330-fmac', 'brcm,bcm4334-fmac', 'brcm,bcm43340-fmac', 'brcm,bcm4335-fmac', 'brcm,bcm43362-fmac', 'brcm,bcm4339-fmac', 'brcm,bcm43430a0-fmac', 'brcm,bcm43430a1-fmac', 'brcm,bcm43455-fmac', 'brcm,bcm43456-fmac', 'brcm,bcm4354-fmac', 'brcm,bcm4356-fmac', 'brcm,bcm4359-fmac', 'brcm,bcm4366-fmac', 'cypress,cyw4373-fmac', 'cypress,cyw43012-fmac', 'infineon,cyw43439-fmac'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/apple/t8112-j493.dtb: wifi@0,0: Unevaluated properties are not allowed ('compatible', 'local-mac-address' were unexpected) from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/apple/t8112-j413.dtb: wifi@0,0: compatible: 'oneOf' conditional failed, one must be fixed: ['pci14e4,4433', 'brcm,bcm4329-fmac'] is too long 'pci14e4,4433' is not one of ['brcm,bcm43143-fmac', 'brcm,bcm4341b0-fmac', 'brcm,bcm4341b4-fmac', 'brcm,bcm4341b5-fmac', 'brcm,bcm4329-fmac', 'brcm,bcm4330-fmac', 'brcm,bcm4334-fmac', 'brcm,bcm43340-fmac', 'brcm,bcm4335-fmac', 'brcm,bcm43362-fmac', 'brcm,bcm4339-fmac', 'brcm,bcm43430a0-fmac', 'brcm,bcm43430a1-fmac', 'brcm,bcm43455-fmac', 'brcm,bcm43456-fmac', 'brcm,bcm4354-fmac', 'brcm,bcm4356-fmac', 'brcm,bcm4359-fmac', 'brcm,bcm4366-fmac', 'cypress,cyw4373-fmac', 'cypress,cyw43012-fmac', 'infineon,cyw43439-fmac'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# arch/arm64/boot/dts/apple/t8112-j413.dtb: wifi@0,0: Unevaluated properties are not allowed ('compatible', 'local-mac-address' were unexpected) from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-08-28 13:18 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang 2024-08-28 8:45 ` [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible Jacobe Zang 2024-08-28 13:02 ` Krzysztof Kozlowski 2024-08-28 13:16 ` Jacobe Zang 2024-08-28 8:55 ` [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Arend van Spriel 2024-08-28 9:09 ` Jacobe Zang 2024-08-28 12:51 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox