From: Daniel Wagner <wagi@monom.org>
To: John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Daniel Wagner <wagi@monom.org>
Subject: [PATCH v2 05/12] pi_stress: Rename -t command line option to -D
Date: Wed, 5 Jun 2019 18:06:10 +0200 [thread overview]
Message-ID: <20190605160617.22987-6-wagi@monom.org> (raw)
In-Reply-To: <20190605160617.22987-1-wagi@monom.org>
Streamline the duration command line argument for all rt-tests. While
at it also add man page.
Signed-off-by: Daniel Wagner <wagi@monom.org>
---
src/pi_tests/pi_stress.8 | 4 ++++
src/pi_tests/pi_stress.c | 11 ++++++-----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/pi_tests/pi_stress.8 b/src/pi_tests/pi_stress.8
index c92b4bdf5609..475d3c34f135 100644
--- a/src/pi_tests/pi_stress.8
+++ b/src/pi_tests/pi_stress.8
@@ -57,6 +57,10 @@ seconds and then terminate.
The number of inversion groups to run. Defaults to 10.
.IP \-d|\-\-debug
Run in debug mode; lots of extra prints
+.IP "\-D, \-\-duration=TIME"
+Specify a length for the test run.
+.br
+Append 'm', 'h', or 'd' to specify minutes, hours or days.
.IP \-v|\-\-verbose
Run with verbose messages
.IP \-s|\-\-signal
diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
index 543106be8e18..1286370c474b 100644
--- a/src/pi_tests/pi_stress.c
+++ b/src/pi_tests/pi_stress.c
@@ -146,7 +146,7 @@ int lockall = 0;
/* command line options */
struct option options[] = {
- {"duration", required_argument, NULL, 't'},
+ {"duration", required_argument, NULL, 'D'},
{"verbose", no_argument, NULL, 'v'},
{"quiet", no_argument, NULL, 'q'},
{"groups", required_argument, NULL, 'g'},
@@ -1027,7 +1027,8 @@ void usage(void)
printf("\t--verbose\t- lots of output\n");
printf("\t--quiet\t\t- suppress running output\n");
printf
- ("\t--duration=<n>- length of the test run in seconds [infinite]\n");
+ ("\t--duration=<n>\t- length of the test run in seconds [infinite]\n");
+ printf("\t\t\t Append 'm', 'h', or 'd' to specify minutes, hours or days.\n");
printf("\t--groups=<n>\t- set the number of inversion groups [%d]\n",
ngroups);
printf
@@ -1322,13 +1323,13 @@ int process_sched_line(const char *arg)
void process_command_line(int argc, char **argv)
{
int opt;
- while ((opt = getopt_long(argc, argv, "+ht:vqi:g:rs:pdVum", options, NULL)) != -1) {
+ while ((opt = getopt_long(argc, argv, "+hD:vqi:g:rs:pdVum", options, NULL)) != -1) {
switch (opt) {
case 'h':
usage();
exit(0);
- case 't':
- duration = strtol(optarg, NULL, 10);
+ case 'D':
+ duration = parse_time_string(optarg);
break;
case 'v':
verbose = 1;
--
2.20.1
next prev parent reply other threads:[~2019-06-05 16:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 16:06 [PATCH v2 00/12] rt-tests: Add --duration argument to tests Daniel Wagner
2019-06-05 16:06 ` [PATCH v2 01/12] rt_numa.h: Remove unused function Daniel Wagner
2019-06-13 13:48 ` John Kacur
2019-06-05 16:06 ` [PATCH v2 02/12] queuelat: Use clock syscall for ARM 32 bit Daniel Wagner
2019-06-13 13:51 ` John Kacur
2019-06-05 16:06 ` [PATCH v2 03/12] rt-utils: Move parse_time_string() Daniel Wagner
2019-06-13 13:57 ` John Kacur
2019-06-05 16:06 ` [PATCH v2 04/12] pi_stress: Allow short command line arguments Daniel Wagner
2019-06-13 14:04 ` John Kacur
2019-06-16 16:29 ` Daniel Wagner
2019-06-05 16:06 ` Daniel Wagner [this message]
2019-06-13 14:07 ` [PATCH v2 05/12] pi_stress: Rename -t command line option to -D John Kacur
2019-06-05 16:06 ` [PATCH v2 06/12] pmqtest: Add duration command line argument Daniel Wagner
2019-06-13 14:10 ` John Kacur
2019-06-05 16:06 ` [PATCH v2 07/12] ptsematest: " Daniel Wagner
2019-06-05 16:06 ` [PATCH v2 08/12] cyclicdeadline: " Daniel Wagner
2019-06-13 14:18 ` John Kacur
2019-06-16 16:34 ` Daniel Wagner
2019-06-13 14:40 ` John Kacur
2019-06-05 16:06 ` [PATCH v2 09/12] signaltest: " Daniel Wagner
2019-06-13 19:07 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605160617.22987-6-wagi@monom.org \
--to=wagi@monom.org \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox