public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Daniel Wagner <wagi@monom.org>
Subject: [PATCH v2 08/12] cyclicdeadline: Add duration command line argument
Date: Wed,  5 Jun 2019 18:06:13 +0200	[thread overview]
Message-ID: <20190605160617.22987-9-wagi@monom.org> (raw)
In-Reply-To: <20190605160617.22987-1-wagi@monom.org>

Many of the test programs have the --loop argument for automatic
stopping. The main problem with the --loop argument is how long is
--loop 1000?

To simplify automated tests introduce a --duration argument which
allows to set the time how long a test should run. This allows the
test suite to define the execution time and also the timeout which a
normal human can understand.

For example run the test for 10 minutes and timeout at 11 minutes:

  # timeout 11m cyclicdeadline -D 10m

Signed-off-by: Daniel Wagner <wagi@monom.org>
---
 src/sched_deadline/cyclicdeadline.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index 6d461b27ac43..47892daf747b 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -21,6 +21,8 @@
 #include <linux/unistd.h>
 #include <linux/magic.h>
 
+#include <rt-utils.h>
+
 #ifdef __i386__
 #ifndef __NR_sched_setattr
 #define __NR_sched_setattr		351
@@ -1049,6 +1051,7 @@ int main (int argc, char **argv)
 	unsigned int interval = 1000;
 	unsigned int step = 500;
 	int percent = 60;
+	int duration = 0;
 	u64 runtime;
 	u64 start_period;
 	u64 end_period;
@@ -1062,7 +1065,7 @@ int main (int argc, char **argv)
 		exit(-1);
 	}
 
-	while ((c = getopt(argc, argv, "+hac:i:s:t:")) >= 0) {
+	while ((c = getopt(argc, argv, "+hac:i:s:t:D:")) >= 0) {
 		switch (c) {
 		case 'a':
 			all_cpus = 1;
@@ -1081,6 +1084,9 @@ int main (int argc, char **argv)
 		case 't':
 			nr_threads = atoi(optarg);
 			break;
+		case 'D':
+			duration = parse_time_string(optarg);
+			break;
 		case 'h':
 		default:
 			usage(argv);
@@ -1246,6 +1252,10 @@ int main (int argc, char **argv)
 
 	signal(SIGINT, sighand);
 	signal(SIGTERM, sighand);
+	signal(SIGALRM, sighand);
+
+	if (duration)
+		alarm(duration);
 
 	if (!fail)
 		loop(sched_data, nr_threads);
-- 
2.20.1

  parent reply	other threads:[~2019-06-05 16:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 16:06 [PATCH v2 00/12] rt-tests: Add --duration argument to tests Daniel Wagner
2019-06-05 16:06 ` [PATCH v2 01/12] rt_numa.h: Remove unused function Daniel Wagner
2019-06-13 13:48   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 02/12] queuelat: Use clock syscall for ARM 32 bit Daniel Wagner
2019-06-13 13:51   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 03/12] rt-utils: Move parse_time_string() Daniel Wagner
2019-06-13 13:57   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 04/12] pi_stress: Allow short command line arguments Daniel Wagner
2019-06-13 14:04   ` John Kacur
2019-06-16 16:29     ` Daniel Wagner
2019-06-05 16:06 ` [PATCH v2 05/12] pi_stress: Rename -t command line option to -D Daniel Wagner
2019-06-13 14:07   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 06/12] pmqtest: Add duration command line argument Daniel Wagner
2019-06-13 14:10   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 07/12] ptsematest: " Daniel Wagner
2019-06-05 16:06 ` Daniel Wagner [this message]
2019-06-13 14:18   ` [PATCH v2 08/12] cyclicdeadline: " John Kacur
2019-06-16 16:34     ` Daniel Wagner
2019-06-13 14:40   ` John Kacur
2019-06-05 16:06 ` [PATCH v2 09/12] signaltest: " Daniel Wagner
2019-06-13 19:07   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605160617.22987-9-wagi@monom.org \
    --to=wagi@monom.org \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox