Re: [PATCH v2 04/12] pi_stress: Allow short command line arguments

[Daniel Wagner <wagi@monom.org>]

Hi John,

On 6/13/19 4:04 PM, John Kacur wrote:
>> index ac7646cd2613..543106be8e18 100644
>> --- a/src/pi_tests/pi_stress.c
>> +++ b/src/pi_tests/pi_stress.c
>> @@ -1322,9 +1322,8 @@ int process_sched_line(const char *arg)
>>   void process_command_line(int argc, char **argv)
>>   {
>>   	int opt;
>> -	while ((opt = getopt_long(argc, argv, "+", options, NULL)) != -1) {
>> +	while ((opt = getopt_long(argc, argv, "+ht:vqi:g:rs:pdVum", options, NULL)) != -1) {
>>   		switch (opt) {
>> -		case '?':
>>   		case 'h':
>>   			usage();
>>   			exit(0);
>> -- 
>> 2.20.1
>>
> 
> I actually don't see short options in the usage help text, but I do see
> them in the manpage.
> 
> This could use some clean-up to make sure the manpage is current and the
> usage text is current and synced too, if you or anyone else reading cares
> to address this.

pi_stress differs a bit in the handling of the options. Indeed it makes 
sense to streamline it with the other tools. Will look into it (but 
don't hold your breath :))

Thanks,
Daniel