* [PATCH 0/4] rt-tests bug fixes
@ 2019-03-12 17:24 Daniel Wagner
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Daniel Wagner @ 2019-03-12 17:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams, Daniel Wagner
Hi,
I found a couple of bugs in cyclicdeadline and deadline_test.
Thanks,
Daniel
Daniel Wagner (4):
cyclicdeadline: Fix stack corruption
deadline_test: Fix stack corruption
deadline_test: Free allocated resources at exit
cyclicdeadline: Free allocated resources at exit
src/sched_deadline/cyclicdeadline.c | 8 ++++++--
src/sched_deadline/deadline_test.c | 8 ++++++--
2 files changed, 12 insertions(+), 4 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/4] cyclicdeadline: Fix stack corruption
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
@ 2019-03-12 17:24 ` Daniel Wagner
2019-04-05 16:28 ` John Kacur
2019-03-12 17:24 ` [PATCH 2/4] deadline_test: " Daniel Wagner
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Daniel Wagner @ 2019-03-12 17:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams, Daniel Wagner
The buffer is too short for the string.
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
---
src/sched_deadline/cyclicdeadline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index 577ad95cfee1..095e6ccc166f 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -285,7 +285,7 @@ static void setup_ftrace_marker(void)
{
struct stat st;
const char *debugfs = find_debugfs();
- char files[strlen(debugfs) + 14];
+ char files[strlen(debugfs) + strlen("/tracing/trace_marker")];
int ret;
if (strlen(debugfs) == 0)
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/4] cyclicdeadline: Fix stack corruption
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
@ 2019-04-05 16:28 ` John Kacur
0 siblings, 0 replies; 9+ messages in thread
From: John Kacur @ 2019-04-05 16:28 UTC (permalink / raw)
To: Daniel Wagner; +Cc: linux-rt-users, Clark Williams
On Tue, 12 Mar 2019, Daniel Wagner wrote:
> The buffer is too short for the string.
>
> Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
> ---
> src/sched_deadline/cyclicdeadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
> index 577ad95cfee1..095e6ccc166f 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -285,7 +285,7 @@ static void setup_ftrace_marker(void)
> {
> struct stat st;
> const char *debugfs = find_debugfs();
> - char files[strlen(debugfs) + 14];
> + char files[strlen(debugfs) + strlen("/tracing/trace_marker")];
> int ret;
>
> if (strlen(debugfs) == 0)
> --
> 2.20.1
>
Same here, you were faster than Kurt, but he included the null byte, so I
grabbed his
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/4] deadline_test: Fix stack corruption
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
@ 2019-03-12 17:24 ` Daniel Wagner
2019-04-05 16:27 ` John Kacur
2019-03-12 17:24 ` [PATCH 3/4] deadline_test: Free allocated resources at exit Daniel Wagner
2019-03-12 17:24 ` [PATCH 4/4] cyclicdeadline: " Daniel Wagner
3 siblings, 1 reply; 9+ messages in thread
From: Daniel Wagner @ 2019-03-12 17:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams, Daniel Wagner
The buffer is too short for the string.
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
---
src/sched_deadline/deadline_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
index b213c206559c..1b72c6097a87 100644
--- a/src/sched_deadline/deadline_test.c
+++ b/src/sched_deadline/deadline_test.c
@@ -435,7 +435,7 @@ static void setup_ftrace_marker(void)
{
struct stat st;
const char *debugfs = find_debugfs();
- char files[strlen(debugfs) + 14];
+ char files[strlen(debugfs) + strlen("/tracing/trace_marker")];
int ret;
if (strlen(debugfs) == 0)
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] deadline_test: Fix stack corruption
2019-03-12 17:24 ` [PATCH 2/4] deadline_test: " Daniel Wagner
@ 2019-04-05 16:27 ` John Kacur
0 siblings, 0 replies; 9+ messages in thread
From: John Kacur @ 2019-04-05 16:27 UTC (permalink / raw)
To: Daniel Wagner; +Cc: linux-rt-users, Clark Williams
On Tue, 12 Mar 2019, Daniel Wagner wrote:
> The buffer is too short for the string.
>
> Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
> ---
> src/sched_deadline/deadline_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> index b213c206559c..1b72c6097a87 100644
> --- a/src/sched_deadline/deadline_test.c
> +++ b/src/sched_deadline/deadline_test.c
> @@ -435,7 +435,7 @@ static void setup_ftrace_marker(void)
> {
> struct stat st;
> const char *debugfs = find_debugfs();
> - char files[strlen(debugfs) + 14];
> + char files[strlen(debugfs) + strlen("/tracing/trace_marker")];
> int ret;
>
> if (strlen(debugfs) == 0)
> --
> 2.20.1
>
>
You beat Kurt with this patch, but his included the null byte, so I
grabbed that one
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] deadline_test: Free allocated resources at exit
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
2019-03-12 17:24 ` [PATCH 2/4] deadline_test: " Daniel Wagner
@ 2019-03-12 17:24 ` Daniel Wagner
2019-04-05 16:29 ` John Kacur
2019-03-12 17:24 ` [PATCH 4/4] cyclicdeadline: " Daniel Wagner
3 siblings, 1 reply; 9+ messages in thread
From: Daniel Wagner @ 2019-03-12 17:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams, Daniel Wagner
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
---
src/sched_deadline/deadline_test.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
index 1b72c6097a87..04984d997f58 100644
--- a/src/sched_deadline/deadline_test.c
+++ b/src/sched_deadline/deadline_test.c
@@ -2092,8 +2092,12 @@ int main (int argc, char **argv)
printf("\n");
}
- if (!setcpu_buf)
+ if (setcpu_buf)
free(setcpu_buf);
+ free(thread);
+ free(sched_data);
+
+ CPU_FREE(cpusetp);
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/4] deadline_test: Free allocated resources at exit
2019-03-12 17:24 ` [PATCH 3/4] deadline_test: Free allocated resources at exit Daniel Wagner
@ 2019-04-05 16:29 ` John Kacur
0 siblings, 0 replies; 9+ messages in thread
From: John Kacur @ 2019-04-05 16:29 UTC (permalink / raw)
To: Daniel Wagner; +Cc: linux-rt-users, Clark Williams
On Tue, 12 Mar 2019, Daniel Wagner wrote:
> Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
> ---
> src/sched_deadline/deadline_test.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/sched_deadline/deadline_test.c b/src/sched_deadline/deadline_test.c
> index 1b72c6097a87..04984d997f58 100644
> --- a/src/sched_deadline/deadline_test.c
> +++ b/src/sched_deadline/deadline_test.c
> @@ -2092,8 +2092,12 @@ int main (int argc, char **argv)
> printf("\n");
> }
>
> - if (!setcpu_buf)
> + if (setcpu_buf)
> free(setcpu_buf);
> + free(thread);
> + free(sched_data);
> +
> + CPU_FREE(cpusetp);
>
> return 0;
> }
> --
> 2.20.1
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] cyclicdeadline: Free allocated resources at exit
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
` (2 preceding siblings ...)
2019-03-12 17:24 ` [PATCH 3/4] deadline_test: Free allocated resources at exit Daniel Wagner
@ 2019-03-12 17:24 ` Daniel Wagner
2019-04-05 16:31 ` John Kacur
3 siblings, 1 reply; 9+ messages in thread
From: Daniel Wagner @ 2019-03-12 17:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams, Daniel Wagner
Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
---
src/sched_deadline/cyclicdeadline.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
index 095e6ccc166f..e3cc3c74ef68 100644
--- a/src/sched_deadline/cyclicdeadline.c
+++ b/src/sched_deadline/cyclicdeadline.c
@@ -1271,6 +1271,10 @@ int main (int argc, char **argv)
}
}
- free(setcpu_buf);
+ if (setcpu_buf)
+ free(setcpu_buf);
+ free(thread);
+ free(sched_data);
+
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 4/4] cyclicdeadline: Free allocated resources at exit
2019-03-12 17:24 ` [PATCH 4/4] cyclicdeadline: " Daniel Wagner
@ 2019-04-05 16:31 ` John Kacur
0 siblings, 0 replies; 9+ messages in thread
From: John Kacur @ 2019-04-05 16:31 UTC (permalink / raw)
To: Daniel Wagner; +Cc: linux-rt-users, Clark Williams
On Tue, 12 Mar 2019, Daniel Wagner wrote:
> Signed-off-by: Daniel Wagner <daniel.wagner@siemens.com>
> ---
> src/sched_deadline/cyclicdeadline.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
> index 095e6ccc166f..e3cc3c74ef68 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -1271,6 +1271,10 @@ int main (int argc, char **argv)
> }
> }
>
> - free(setcpu_buf);
> + if (setcpu_buf)
> + free(setcpu_buf);
> + free(thread);
> + free(sched_data);
> +
> return 0;
> }
> --
> 2.20.1
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-05 16:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 17:24 [PATCH 0/4] rt-tests bug fixes Daniel Wagner
2019-03-12 17:24 ` [PATCH 1/4] cyclicdeadline: Fix stack corruption Daniel Wagner
2019-04-05 16:28 ` John Kacur
2019-03-12 17:24 ` [PATCH 2/4] deadline_test: " Daniel Wagner
2019-04-05 16:27 ` John Kacur
2019-03-12 17:24 ` [PATCH 3/4] deadline_test: Free allocated resources at exit Daniel Wagner
2019-04-05 16:29 ` John Kacur
2019-03-12 17:24 ` [PATCH 4/4] cyclicdeadline: " Daniel Wagner
2019-04-05 16:31 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox