[rtc-linux] Re: [PATCH 6/6] rtc-rv3029: Add device tree property for trickle charger

[Alexandre Belloni <alexandre.belloni@free-electrons.com>]

On 04/03/2016 at 19:56:54 +0100, Michael B=C3=BCsch wrote :
> +	err =3D of_property_read_u32(of_node, "trickle-resistor-ohms", &ohms);
> +	if (err) {
> +		/* Disable trickle charger. */
> +		eectrl &=3D ~RV3029_TRICKLE_MASK;
> +	} else {
> +		/* Enable trickle charger. */
> +		for (i =3D 0; i < ARRAY_SIZE(rv3029_trickle_tab); i++) {
> +			elem =3D &rv3029_trickle_tab[i];
> +			if (elem->r >=3D ohms)
> +				break;
> +		}
> +		eectrl &=3D ~RV3029_TRICKLE_MASK;
> +		eectrl |=3D elem->conf;
> +		dev_info(&client->dev,
> +			 "Trickle charger enabled at %d ohms resistance.\n",
> +			 elem->r);
> +	}

Now the you have an update_bits functions, you probably want to use it
here. This simplifies the function.

> +	err =3D rv3029_eeprom_write(client, RV3029_CONTROL_E2P_EECTRL,
> +				  &eectrl, 1);
> +	if (err < 0) {
> +		dev_err(&client->dev,
> +			"Failed to write trickle charger config\n");
> +	}
> +}
> +
>  static const struct rtc_class_ops rv3029_rtc_ops =3D {
>  	.read_time	=3D rv3029_rtc_read_time,
>  	.set_time	=3D rv3029_rtc_set_time,
> @@ -557,6 +655,8 @@ static int rv3029_probe(struct i2c_client *client,
>  		return rc;
>  	}
> =20
> +	rv3029_trickle_config(client);
> +
>  	rtc =3D devm_rtc_device_register(&client->dev, client->name,
>  				       &rv3029_rtc_ops, THIS_MODULE);
> =20
> --=20
> 2.7.0
>=20



--=20
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--=20
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.