[rtc-linux] Re: [PATCH 6/6] rtc-rv3029: Add device tree property for trickle charger

["Michael Büsch" <m@bues.ch>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Fri, 4 Mar 2016 20:43:37 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> On 04/03/2016 at 19:56:54 +0100, Michael Büsch wrote :
> > +	err = of_property_read_u32(of_node, "trickle-resistor-ohms", &ohms);
> > +	if (err) {
> > +		/* Disable trickle charger. */
> > +		eectrl &= ~RV3029_TRICKLE_MASK;
> > +	} else {
> > +		/* Enable trickle charger. */
> > +		for (i = 0; i < ARRAY_SIZE(rv3029_trickle_tab); i++) {
> > +			elem = &rv3029_trickle_tab[i];
> > +			if (elem->r >= ohms)
> > +				break;
> > +		}
> > +		eectrl &= ~RV3029_TRICKLE_MASK;
> > +		eectrl |= elem->conf;
> > +		dev_info(&client->dev,
> > +			 "Trickle charger enabled at %d ohms resistance.\n",
> > +			 elem->r);
> > +	}  
> 
> Now the you have an update_bits functions, you probably want to use it
> here. This simplifies the function.


No. This operates on the eeprom. The update_bits function operates on
bare registers.
If we have more mask/set operations on the eeprom later, we can add an
update_bits function for the eeprom, too.

-- 
Michael

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]