* [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE()
@ 2026-07-04 12:20 Pengpeng Hou
2026-07-04 12:22 ` sashiko-bot
2026-07-06 9:43 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Pengpeng Hou @ 2026-07-04 12:20 UTC (permalink / raw)
To: Chester Lin, Matthias Brugger, Ghennadi Procopciuc,
NXP S32 Linux Team, Alexandre Belloni
Cc: Pengpeng Hou, linux-arm-kernel, linux-rtc, linux-kernel
The driver has an OF match table wired to .of_match_table, but does
not export the table with MODULE_DEVICE_TABLE().
Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
information is generated for OF based module autoloading.
This is a source-level fix. It does not claim dynamic hardware
reproduction; the evidence is the driver-owned match table, its use by
the platform driver, and the missing module alias publication.
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
drivers/rtc/rtc-s32g.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-s32g.c b/drivers/rtc/rtc-s32g.c
index 3a0818e972eb..86716192d10f 100644
--- a/drivers/rtc/rtc-s32g.c
+++ b/drivers/rtc/rtc-s32g.c
@@ -366,6 +366,7 @@ static const struct of_device_id rtc_dt_ids[] = {
{ .compatible = "nxp,s32g2-rtc", .data = &rtc_s32g2_data },
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, rtc_dt_ids);
static DEFINE_SIMPLE_DEV_PM_OPS(s32g_rtc_pm_ops,
s32g_rtc_suspend, s32g_rtc_resume);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE()
2026-07-04 12:20 [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
@ 2026-07-04 12:22 ` sashiko-bot
2026-07-06 9:43 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-04 12:22 UTC (permalink / raw)
To: Pengpeng Hou; +Cc: linux-rtc, Alexandre Belloni
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260704122003.70108-1-pengpeng@iscas.ac.cn?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE()
2026-07-04 12:20 [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-04 12:22 ` sashiko-bot
@ 2026-07-06 9:43 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2026-07-06 9:43 UTC (permalink / raw)
To: Pengpeng Hou, Chester Lin, Ghennadi Procopciuc,
NXP S32 Linux Team, Alexandre Belloni
Cc: linux-arm-kernel, linux-rtc, linux-kernel
On 04/07/2026 14:20, Pengpeng Hou wrote:
> The driver has an OF match table wired to .of_match_table, but does
> not export the table with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE(of, ...) entry so module alias
> information is generated for OF based module autoloading.
>
> This is a source-level fix. It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the platform driver, and the missing module alias publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
> drivers/rtc/rtc-s32g.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-s32g.c b/drivers/rtc/rtc-s32g.c
> index 3a0818e972eb..86716192d10f 100644
> --- a/drivers/rtc/rtc-s32g.c
> +++ b/drivers/rtc/rtc-s32g.c
> @@ -366,6 +366,7 @@ static const struct of_device_id rtc_dt_ids[] = {
> { .compatible = "nxp,s32g2-rtc", .data = &rtc_s32g2_data },
> { /* sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, rtc_dt_ids);
>
> static DEFINE_SIMPLE_DEV_PM_OPS(s32g_rtc_pm_ops,
> s32g_rtc_suspend, s32g_rtc_resume);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-06 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 12:20 [PATCH] rtc: s32g: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-04 12:22 ` sashiko-bot
2026-07-06 9:43 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox