* [PATCH v2 0/1] rtc: rtctest: Support opal-rtc and rtc-generic
From: Lukáš Doktor @ 2017-08-15 8:45 UTC (permalink / raw)
To: ldoktor, a.zummo, linuxppc-dev, sboyd, linux-kernel,
alexandre.belloni, linux-kselftest, john.stultz, tglx, shuah,
linux-rtc
On ppc64le machines the opal-rtc, resp rtc-generic in guest is used. They only
support minimal set of functionality and fail this test in not-yet treated
way. This extends the checks and skips to the next test when feature is not
supported.
Changes in v2:
- Removed the double EINVAL check
- Added missing space before "EIO" check.
Lukáš Doktor (1):
rtc: rtctest: Improve support detection
tools/testing/selftests/timers/rtctest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--
2.9.4
^ permalink raw reply
* Re: [PATCH] rtc: rtctest: Improve support detection
From: Lukáš Doktor @ 2017-08-15 8:20 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo, john.stultz, tglx, sboyd, shuah, linux-rtc, linux-kernel,
linux-kselftest, linuxppc-dev
In-Reply-To: <20170812202206.6phv7fesej42jhxr@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 2200 bytes --]
Dne 12.8.2017 v 22:22 Alexandre Belloni napsal(a):
> Hi,
>
> On 11/08/2017 at 11:14:55 +0200, Lukáš Doktor wrote:
>> The rtc-generic and opal-rtc are failing to run this test as they do not
>> support all the features. Let's treat the error returns and skip to the
>> following test.
>>
>> Theoretically the test_DATE should be also adjusted, but as it's enabled
>> on demand I think it makes sense to fail in such case.
>>
>> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
>> ---
>> tools/testing/selftests/timers/rtctest.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
>> index f61170f..6344842 100644
>> --- a/tools/testing/selftests/timers/rtctest.c
>> +++ b/tools/testing/selftests/timers/rtctest.c
>> @@ -125,7 +125,7 @@ int main(int argc, char **argv)
>> /* Turn on update interrupts (one per second) */
>> retval = ioctl(fd, RTC_UIE_ON, 0);
>> if (retval == -1) {
>> - if (errno == EINVAL) {
>> + if (errno == EINVAL || errno == EINVAL) {
>
> Well, this needs to be fixed.
>
Yes, this chunk is actually not needed anymore (it was based on outdated copy we use in Autotest which had ENOTTY which is probably not needed nowadays). Let me send v2 without this.
Regards,
Lukáš
>> fprintf(stderr,
>> "\n...Update IRQs not supported.\n");
>> goto test_READ;
>> @@ -221,6 +221,11 @@ int main(int argc, char **argv)
>> /* Read the current alarm settings */
>> retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
>> if (retval == -1) {
>> + if (errno == EINVAL) {
>> + fprintf(stderr,
>> + "\n...EINVAL reading current alarm setting.\n");
>> + goto test_PIE;
>> + }
>> perror("RTC_ALM_READ ioctl");
>> exit(errno);
>> }
>> @@ -231,7 +236,7 @@ int main(int argc, char **argv)
>> /* Enable alarm interrupts */
>> retval = ioctl(fd, RTC_AIE_ON, 0);
>> if (retval == -1) {
>> - if (errno == EINVAL) {
>> + if (errno == EINVAL || errno ==EIO) {
>> fprintf(stderr,
>> "\n...Alarm IRQs not supported.\n");
>> goto test_PIE;
>> --
>> 2.9.4
>>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 502 bytes --]
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Wolfram Sang @ 2017-08-14 16:32 UTC (permalink / raw)
To: Daniel Thompson
Cc: Tony Lindgren, Lee Jones, Thierry Reding, linux-i2c, Russell King,
Linus Walleij, Alexandre Courbot, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Dmitry Torokhov, Kishon Vijay Abraham I, Sebastian Reichel,
Liam Girdwood, Mark Brown, Alessandro Zummo, Alexandre Belloni,
Felipe Balbi, Greg Kroah-Hartman, Jingoo Han,
Bartlomiej Zolnierkiewicz, Wim Van Sebroeck, Guenter Roeck,
Peter Ujfalusi, Jaroslav Kysela, Takashi Iwai, linux-omap,
linux-arm-kernel, linux-kernel, linux-gpio, linux-iio,
linux-input, linux-pm, linux-pwm, rtc-linux, linux-usb,
linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <c5e65e34-f308-f601-ba0b-d96792591727@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Added, thanks!
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Daniel Thompson @ 2017-08-14 16:27 UTC (permalink / raw)
To: Tony Lindgren, Wolfram Sang
Cc: Lee Jones, Thierry Reding, linux-i2c, Russell King, Linus Walleij,
Alexandre Courbot, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Dmitry Torokhov,
Kishon Vijay Abraham I, Sebastian Reichel, Liam Girdwood,
Mark Brown, Alessandro Zummo, Alexandre Belloni, Felipe Balbi,
Greg Kroah-Hartman, Jingoo Han, Bartlomiej Zolnierkiewicz,
Wim Van Sebroeck, Guenter Roeck, Peter Ujfalusi, Jaroslav Kysela,
Takashi Iwai, linux-omap, linux-arm-kernel, linux-kernel,
linux-gpio, linux-iio, linux-input, linux-pm, linux-pwm,
rtc-linux, linux-usb, linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <20170814162219.GX8569@atomide.com>
On 14/08/17 17:22, Tony Lindgren wrote:
> * Wolfram Sang <wsa@the-dreams.de> [170814 01:43]:
>>
>>>> Given the triviality of the change for non-MFD subsystems, can we apply
>>>> this for 4.14?
>>>
>>> I can't apply anything without Acks for *all* of the subsystems above.
>>
>> Well, there are cases when you can. Those should be exceptions and well
>> justified, of course.
>>
>>> My suggestion would be to collect the Acks you've received up until
>>> this point and identify which SS's are still lacking in change log
>>> section of a RESEND.
>>
>> I agree, though, that I can try a second round to get the acks.
>
> As long as it's been compile tested with omap2plus_defconfig:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Don't recall if I sent an ack before but I do remember the patch... so
from a backlight PoV:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Tony Lindgren @ 2017-08-14 16:22 UTC (permalink / raw)
To: Wolfram Sang
Cc: Lee Jones, Thierry Reding, linux-i2c, Russell King, Linus Walleij,
Alexandre Courbot, Jonathan Cameron, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Dmitry Torokhov,
Kishon Vijay Abraham I, Sebastian Reichel, Liam Girdwood,
Mark Brown, Alessandro Zummo, Alexandre Belloni, Felipe Balbi,
Greg Kroah-Hartman, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Wim Van Sebroeck, Guenter Roeck,
Peter Ujfalusi, Jaroslav Kysela, Takashi Iwai, linux-omap,
linux-arm-kernel, linux-kernel, linux-gpio, linux-iio,
linux-input, linux-pm, linux-pwm, rtc-linux, linux-usb,
linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <20170814084340.65morabelapfegph@ninjato>
* Wolfram Sang <wsa@the-dreams.de> [170814 01:43]:
>
> > > Given the triviality of the change for non-MFD subsystems, can we apply
> > > this for 4.14?
> >
> > I can't apply anything without Acks for *all* of the subsystems above.
>
> Well, there are cases when you can. Those should be exceptions and well
> justified, of course.
>
> > My suggestion would be to collect the Acks you've received up until
> > this point and identify which SS's are still lacking in change log
> > section of a RESEND.
>
> I agree, though, that I can try a second round to get the acks.
As long as it's been compile tested with omap2plus_defconfig:
Acked-by: Tony Lindgren <tony@atomide.com>
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
From: Alexandre Belloni @ 2017-08-14 13:13 UTC (permalink / raw)
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org, Goran Ferenc, Alessandro Zummo, Bo Hu,
David S. Miller, Douglas Leung, Greg Kroah-Hartman, James Hogan,
Jin Qian, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
Raghu Gandham, Miodrag Dinic, Aleksandar Markovic
In-Reply-To: <EF5FA6C3467F85449672C3E735957B85015D9CC3E1@BADAG02.ba.imgtec.org>
On 14/08/2017 at 12:45:55 +0000, Aleksandar Markovic wrote:
> Hello, Alexandre,
>
> In addition, if you, and everybody else, don't object, I plan to change the title of this patch form:
>
> "MIPS: ranchu: Add Goldfish RTC driver"
>
> to
>
> "rtc: Add Goldfish RTC driver",
>
> to be more consistent with all commit messages for this kernel source directory.
>
Yes please, I would have changed it anyway.
> Regards,
> Aleksandar
>
> ________________________________________
> From: Miodrag Dinic
> Sent: Friday, August 11, 2017 9:46 AM
> To: Alexandre Belloni; Aleksandar Markovic
> Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
> Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
>
> Hi Alexandre,
>
> we have this sorted & plan to submit version 4 of this series next week.
>
> Thank you.
>
> Kind regards,
> Miodrag
> ________________________________________
> From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
> Sent: Thursday, August 10, 2017 10:34 PM
> To: Aleksandar Markovic
> Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
> Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
>
> Hi,
>
> On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> > From: Miodrag Dinic <miodrag.dinic@imgtec.com>
> >
> > Add device driver for a virtual Goldfish RTC clock.
> >
> > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> > set. The compatible string used by OS for binding the driver is
> > defined as "google,goldfish-rtc".
> >
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> > ---
> > MAINTAINERS | 1 +
> > drivers/rtc/Kconfig | 8 ++
> > drivers/rtc/Makefile | 1 +
> > drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 243 insertions(+)
> > create mode 100644 drivers/rtc/rtc-goldfish.c
> >
>
> Do you mind fixing the remaining checkpatch --strict issues, the two
> kbuild errors and the warning reported by Julia?
>
> Thanks!
>
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
From: Aleksandar Markovic @ 2017-08-14 12:45 UTC (permalink / raw)
To: Alexandre Belloni
Cc: linux-mips@linux-mips.org, Goran Ferenc, Alessandro Zummo, Bo Hu,
David S. Miller, Douglas Leung, Greg Kroah-Hartman, James Hogan,
Jin Qian, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
Raghu Gandham, Miodrag Dinic, Aleksandar Markovic
In-Reply-To: <232DDC0A2B605E4F9E85F6904417885F015D937238@BADAG02.ba.imgtec.org>
Hello, Alexandre,
In addition, if you, and everybody else, don't object, I plan to change the title of this patch form:
"MIPS: ranchu: Add Goldfish RTC driver"
to
"rtc: Add Goldfish RTC driver",
to be more consistent with all commit messages for this kernel source directory.
Regards,
Aleksandar
________________________________________
From: Miodrag Dinic
Sent: Friday, August 11, 2017 9:46 AM
To: Alexandre Belloni; Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Hi Alexandre,
we have this sorted & plan to submit version 4 of this series next week.
Thank you.
Kind regards,
Miodrag
________________________________________
From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
Sent: Thursday, August 10, 2017 10:34 PM
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Hi,
On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 8 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 243 insertions(+)
> create mode 100644 drivers/rtc/rtc-goldfish.c
>
Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Wolfram Sang @ 2017-08-14 8:43 UTC (permalink / raw)
To: Lee Jones
Cc: Thierry Reding, linux-i2c, Tony Lindgren, Russell King,
Linus Walleij, Alexandre Courbot, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Dmitry Torokhov, Kishon Vijay Abraham I, Sebastian Reichel,
Liam Girdwood, Mark Brown, Alessandro Zummo, Alexandre Belloni,
Felipe Balbi, Greg Kroah-Hartman, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Wim Van Sebroeck, Guenter Roeck,
Peter Ujfalusi, Jaroslav Kysela, Takashi Iwai, linux-omap,
linux-arm-kernel, linux-kernel, linux-gpio, linux-iio,
linux-input, linux-pm, linux-pwm, rtc-linux, linux-usb,
linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <20170814064247.qvggx4ito4vgjqvs@dell>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
> > Given the triviality of the change for non-MFD subsystems, can we apply
> > this for 4.14?
>
> I can't apply anything without Acks for *all* of the subsystems above.
Well, there are cases when you can. Those should be exceptions and well
justified, of course.
> My suggestion would be to collect the Acks you've received up until
> this point and identify which SS's are still lacking in change log
> section of a RESEND.
I agree, though, that I can try a second round to get the acks.
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* [rtc-linux] Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm
From: Wolfram Sang @ 2017-08-14 8:25 UTC (permalink / raw)
To: Lee Jones
Cc: linux-i2c, Dmitry Torokhov, Alessandro Zummo, Alexandre Belloni,
linux-input, linux-kernel, rtc-linux
In-Reply-To: <20170814064336.secnn77amfjgbltw@dell>
[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]
On Mon, Aug 14, 2017 at 07:43:36AM +0100, Lee Jones wrote:
> On Sun, 13 Aug 2017, Wolfram Sang wrote:
>
> > On Tue, May 23, 2017 at 08:17:27AM +0100, Lee Jones wrote:
> > > On Mon, 22 May 2017, Wolfram Sang wrote:
> > >
> > > > include/linux/i2c is not for client devices. Move the header file to a
> > > > more appropriate location.
> > > >
> > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > > ---
> > > > drivers/input/misc/dm355evm_keys.c | 2 +-
> > >
> > > > drivers/mfd/dm355evm_msp.c | 2 +-
> > >
> > > For my own reference:
> > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> >
> > Does that mean it will be in 4.14? Or is something else needed?
>
> Can this patch be applied on its own, or does it have dependencies?
These patches are self-contained; they only move an include file from A
to B.
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* [rtc-linux] Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm
From: Lee Jones @ 2017-08-14 6:43 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Dmitry Torokhov, Alessandro Zummo, Alexandre Belloni,
linux-input, linux-kernel, rtc-linux
In-Reply-To: <20170813133418.e7lftrmry3gu3dcc@ninjato>
On Sun, 13 Aug 2017, Wolfram Sang wrote:
> On Tue, May 23, 2017 at 08:17:27AM +0100, Lee Jones wrote:
> > On Mon, 22 May 2017, Wolfram Sang wrote:
> >=20
> > > include/linux/i2c is not for client devices. Move the header file to =
a
> > > more appropriate location.
> > >=20
> > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > ---
> > > drivers/input/misc/dm355evm_keys.c | 2 +-
> >=20
> > > drivers/mfd/dm355evm_msp.c | 2 +-
> >=20
> > For my own reference:
> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>=20
> Does that mean it will be in 4.14? Or is something else needed?
Can this patch be applied on its own, or does it have dependencies?
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Lee Jones @ 2017-08-14 6:42 UTC (permalink / raw)
To: Wolfram Sang
Cc: Thierry Reding, linux-i2c, Tony Lindgren, Russell King,
Linus Walleij, Alexandre Courbot, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Dmitry Torokhov, Kishon Vijay Abraham I, Sebastian Reichel,
Liam Girdwood, Mark Brown, Alessandro Zummo, Alexandre Belloni,
Felipe Balbi, Greg Kroah-Hartman, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Wim Van Sebroeck, Guenter Roeck,
Peter Ujfalusi, Jaroslav Kysela, Takashi Iwai, linux-omap,
linux-arm-kernel, linux-kernel, linux-gpio, linux-iio,
linux-input, linux-pm, linux-pwm, rtc-linux, linux-usb,
linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <20170813133700.tv4ka7anvbzcplr7@ninjato>
On Sun, 13 Aug 2017, Wolfram Sang wrote:
> On Thu, Jul 06, 2017 at 08:03:52AM +0100, Lee Jones wrote:
> > On Thu, 06 Jul 2017, Thierry Reding wrote:
> >=20
> > > On Mon, May 22, 2017 at 12:02:10AM +0200, Wolfram Sang wrote:
> > > > include/linux/i2c is not for client devices. Move the header file t=
o a
> > > > more appropriate location.
> > > >=20
> > > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > > ---
> > > > arch/arm/mach-omap2/common.h | 2 +-
> > > > arch/arm/mach-omap2/omap_twl.c | 2 +-
> > > > drivers/gpio/gpio-twl4030.c | 2 +-
> > > > drivers/iio/adc/twl4030-madc.c | 2 +-
> > > > drivers/iio/adc/twl6030-gpadc.c | 2 +-
> > > > drivers/input/keyboard/twl4030_keypad.c | 2 +-
> > > > drivers/input/misc/twl4030-pwrbutton.c | 2 +-
> > > > drivers/input/misc/twl4030-vibra.c | 2 +-
> > > > drivers/mfd/twl-core.c | 6 +++---
> > > > drivers/mfd/twl4030-audio.c | 2 +-
> > > > drivers/mfd/twl4030-irq.c | 2 +-
> > > > drivers/mfd/twl4030-power.c | 2 +-
> > > > drivers/mfd/twl6030-irq.c | 2 +-
> > > > drivers/phy/phy-twl4030-usb.c | 2 +-
> > > > drivers/power/supply/twl4030_charger.c | 2 +-
> > > > drivers/pwm/pwm-twl-led.c | 2 +-
> > > > drivers/pwm/pwm-twl.c | 2 +-
> > > > drivers/regulator/twl-regulator.c | 2 +-
> > > > drivers/regulator/twl6030-regulator.c | 2 +-
> > > > drivers/rtc/rtc-twl.c | 2 +-
> > > > drivers/usb/phy/phy-twl6030-usb.c | 2 +-
> > > > drivers/video/backlight/pandora_bl.c | 2 +-
> > > > drivers/watchdog/twl4030_wdt.c | 2 +-
> > > > include/linux/{i2c =3D> mfd}/twl.h | 0
> > > > sound/soc/codecs/twl4030.c | 2 +-
> > > > 25 files changed, 26 insertions(+), 26 deletions(-)
> > > > rename include/linux/{i2c =3D> mfd}/twl.h (100%)
> > >=20
> > > I didn't see this get applied yet, so just in case anyone was waiting
> > > for me (this is trivial, so I don't think there's a need):
> >=20
> > You're not the last. :)
>=20
> Given the triviality of the change for non-MFD subsystems, can we apply
> this for 4.14?
I can't apply anything without Acks for *all* of the subsystems above.
As you well know, it is the submitters responsibility to obtain them.
My suggestion would be to collect the Acks you've received up until
this point and identify which SS's are still lacking in change log
section of a RESEND.
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply
* [rtc-linux] Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm
From: Wolfram Sang @ 2017-08-13 13:37 UTC (permalink / raw)
To: Lee Jones
Cc: Thierry Reding, linux-i2c, Tony Lindgren, Russell King,
Linus Walleij, Alexandre Courbot, Jonathan Cameron,
Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Dmitry Torokhov, Kishon Vijay Abraham I, Sebastian Reichel,
Liam Girdwood, Mark Brown, Alessandro Zummo, Alexandre Belloni,
Felipe Balbi, Greg Kroah-Hartman, Daniel Thompson, Jingoo Han,
Bartlomiej Zolnierkiewicz, Wim Van Sebroeck, Guenter Roeck,
Peter Ujfalusi, Jaroslav Kysela, Takashi Iwai, linux-omap,
linux-arm-kernel, linux-kernel, linux-gpio, linux-iio,
linux-input, linux-pm, linux-pwm, rtc-linux, linux-usb,
linux-fbdev, linux-watchdog, alsa-devel
In-Reply-To: <20170706070352.xdecvsnremwqed72@dell>
[-- Attachment #1: Type: text/plain, Size: 2592 bytes --]
On Thu, Jul 06, 2017 at 08:03:52AM +0100, Lee Jones wrote:
> On Thu, 06 Jul 2017, Thierry Reding wrote:
>
> > On Mon, May 22, 2017 at 12:02:10AM +0200, Wolfram Sang wrote:
> > > include/linux/i2c is not for client devices. Move the header file to a
> > > more appropriate location.
> > >
> > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > > ---
> > > arch/arm/mach-omap2/common.h | 2 +-
> > > arch/arm/mach-omap2/omap_twl.c | 2 +-
> > > drivers/gpio/gpio-twl4030.c | 2 +-
> > > drivers/iio/adc/twl4030-madc.c | 2 +-
> > > drivers/iio/adc/twl6030-gpadc.c | 2 +-
> > > drivers/input/keyboard/twl4030_keypad.c | 2 +-
> > > drivers/input/misc/twl4030-pwrbutton.c | 2 +-
> > > drivers/input/misc/twl4030-vibra.c | 2 +-
> > > drivers/mfd/twl-core.c | 6 +++---
> > > drivers/mfd/twl4030-audio.c | 2 +-
> > > drivers/mfd/twl4030-irq.c | 2 +-
> > > drivers/mfd/twl4030-power.c | 2 +-
> > > drivers/mfd/twl6030-irq.c | 2 +-
> > > drivers/phy/phy-twl4030-usb.c | 2 +-
> > > drivers/power/supply/twl4030_charger.c | 2 +-
> > > drivers/pwm/pwm-twl-led.c | 2 +-
> > > drivers/pwm/pwm-twl.c | 2 +-
> > > drivers/regulator/twl-regulator.c | 2 +-
> > > drivers/regulator/twl6030-regulator.c | 2 +-
> > > drivers/rtc/rtc-twl.c | 2 +-
> > > drivers/usb/phy/phy-twl6030-usb.c | 2 +-
> > > drivers/video/backlight/pandora_bl.c | 2 +-
> > > drivers/watchdog/twl4030_wdt.c | 2 +-
> > > include/linux/{i2c => mfd}/twl.h | 0
> > > sound/soc/codecs/twl4030.c | 2 +-
> > > 25 files changed, 26 insertions(+), 26 deletions(-)
> > > rename include/linux/{i2c => mfd}/twl.h (100%)
> >
> > I didn't see this get applied yet, so just in case anyone was waiting
> > for me (this is trivial, so I don't think there's a need):
>
> You're not the last. :)
Given the triviality of the change for non-MFD subsystems, can we apply
this for 4.14?
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* [rtc-linux] Re: [PATCH 1/3] mfd: dm355evm_msp: move header file out of I2C realm
From: Wolfram Sang @ 2017-08-13 13:34 UTC (permalink / raw)
To: Lee Jones
Cc: linux-i2c, Dmitry Torokhov, Alessandro Zummo, Alexandre Belloni,
linux-input, linux-kernel, rtc-linux
In-Reply-To: <20170523071727.tw6vblpnevihqgqk@dell>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Tue, May 23, 2017 at 08:17:27AM +0100, Lee Jones wrote:
> On Mon, 22 May 2017, Wolfram Sang wrote:
>
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> > drivers/input/misc/dm355evm_keys.c | 2 +-
>
> > drivers/mfd/dm355evm_msp.c | 2 +-
>
> For my own reference:
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Does that mean it will be in 4.14? Or is something else needed?
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply
* Re: [PATCH] rtc: at91rm9200: fix error return code in at91_rtc_probe()
From: Alexandre Belloni @ 2017-08-12 21:25 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Alessandro Zummo, linux-rtc, linux-kernel
In-Reply-To: <20170809155244.GA25987@embeddedgus>
On 09/08/2017 at 10:52:44 -0500, Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the at91rm9200 driver
> ignores it and always returns -ENXIO. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
>
This will never happen and is not an actual issue. I will not take such
a patch until you
1/ prove there is an issue
2/ test your patch on real hardware
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/rtc/rtc-at91rm9200.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index e221b78..09bc2e0 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -398,8 +398,8 @@ static int __init at91_rtc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "no irq resource defined\n");
> - return -ENXIO;
> + dev_err(&pdev->dev, "no irq resource defined: %d\n", irq);
> + return irq;
> }
>
> at91_rtc_regs = devm_ioremap(&pdev->dev, regs->start,
> --
> 2.5.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* Re: [PATCH] rtc: rtctest: Improve support detection
From: Alexandre Belloni @ 2017-08-12 20:22 UTC (permalink / raw)
To: Lukáš Doktor
Cc: a.zummo, john.stultz, tglx, sboyd, shuah, linux-rtc, linux-kernel,
linux-kselftest, linuxppc-dev
In-Reply-To: <20170811091455.11041-2-ldoktor@redhat.com>
Hi,
On 11/08/2017 at 11:14:55 +0200, Lukáš Doktor wrote:
> The rtc-generic and opal-rtc are failing to run this test as they do not
> support all the features. Let's treat the error returns and skip to the
> following test.
>
> Theoretically the test_DATE should be also adjusted, but as it's enabled
> on demand I think it makes sense to fail in such case.
>
> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
> ---
> tools/testing/selftests/timers/rtctest.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
> index f61170f..6344842 100644
> --- a/tools/testing/selftests/timers/rtctest.c
> +++ b/tools/testing/selftests/timers/rtctest.c
> @@ -125,7 +125,7 @@ int main(int argc, char **argv)
> /* Turn on update interrupts (one per second) */
> retval = ioctl(fd, RTC_UIE_ON, 0);
> if (retval == -1) {
> - if (errno == EINVAL) {
> + if (errno == EINVAL || errno == EINVAL) {
Well, this needs to be fixed.
> fprintf(stderr,
> "\n...Update IRQs not supported.\n");
> goto test_READ;
> @@ -221,6 +221,11 @@ int main(int argc, char **argv)
> /* Read the current alarm settings */
> retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
> if (retval == -1) {
> + if (errno == EINVAL) {
> + fprintf(stderr,
> + "\n...EINVAL reading current alarm setting.\n");
> + goto test_PIE;
> + }
> perror("RTC_ALM_READ ioctl");
> exit(errno);
> }
> @@ -231,7 +236,7 @@ int main(int argc, char **argv)
> /* Enable alarm interrupts */
> retval = ioctl(fd, RTC_AIE_ON, 0);
> if (retval == -1) {
> - if (errno == EINVAL) {
> + if (errno == EINVAL || errno ==EIO) {
> fprintf(stderr,
> "\n...Alarm IRQs not supported.\n");
> goto test_PIE;
> --
> 2.9.4
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* Re: [RFCv2] rtc: ds1307: add square wave output from ds1308
From: Alexandre Belloni @ 2017-08-12 18:12 UTC (permalink / raw)
To: Sean Nyekjaer; +Cc: linux-rtc, linux-clk
In-Reply-To: <20170802052727.18289-1-sean.nyekjaer@prevas.dk>
On 02/08/2017 at 07:27:27 +0200, Sean Nyekjaer wrote:
> +static int ds1308_write_control(struct ds1307 *ds1307, u8 mask, u8 value)
> +{
> + struct mutex *lock = &ds1307->rtc->ops_lock;
> + int ret;
> +
> + mutex_lock(lock);
> + ret = regmap_update_bits(ds1307->regmap, DS1307_REG_CONTROL,
> + mask, value);
This access is already properly locked, you don't need
ds1308_write_control.
(I know, the function below is not necessary either but it is there for
historical reasons).
> + mutex_unlock(lock);
> +
> + return ret;
> +}
> +
> static int ds1337_write_control(struct ds1307 *ds1307, u8 mask, u8 value)
> {
> struct mutex *lock = &ds1307->rtc->ops_lock;
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
From: Miodrag Dinic @ 2017-08-11 16:46 UTC (permalink / raw)
To: Alexandre Belloni, Aleksandar Markovic
Cc: linux-mips@linux-mips.org, Goran Ferenc, Aleksandar Markovic,
Alessandro Zummo, Bo Hu, David S. Miller, Douglas Leung,
Greg Kroah-Hartman, James Hogan, Jin Qian,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
Raghu Gandham
In-Reply-To: <20170810203430.zgtxvi7uaqmg4dzr@piout.net>
Hi Alexandre,
we have this sorted & plan to submit version 4 of this series next week.
Thank you.
Kind regards,
Miodrag
________________________________________
From: Alexandre Belloni [alexandre.belloni@free-electrons.com]
Sent: Thursday, August 10, 2017 10:34 PM
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@vger.kernel.org; linux-rtc@vger.kernel.org; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham
Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
Hi,
On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 8 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 243 insertions(+)
> create mode 100644 drivers/rtc/rtc-goldfish.c
>
Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* [PATCH] rtc: rtctest: Improve support detection
From: Lukáš Doktor @ 2017-08-11 9:14 UTC (permalink / raw)
To: ldoktor, a.zummo, alexandre.belloni, john.stultz, tglx, sboyd,
shuah, linux-rtc, linux-kernel, linux-kselftest, linuxppc-dev
In-Reply-To: <20170811091455.11041-1-ldoktor@redhat.com>
The rtc-generic and opal-rtc are failing to run this test as they do not
support all the features. Let's treat the error returns and skip to the
following test.
Theoretically the test_DATE should be also adjusted, but as it's enabled
on demand I think it makes sense to fail in such case.
Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
---
tools/testing/selftests/timers/rtctest.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/timers/rtctest.c b/tools/testing/selftests/timers/rtctest.c
index f61170f..6344842 100644
--- a/tools/testing/selftests/timers/rtctest.c
+++ b/tools/testing/selftests/timers/rtctest.c
@@ -125,7 +125,7 @@ int main(int argc, char **argv)
/* Turn on update interrupts (one per second) */
retval = ioctl(fd, RTC_UIE_ON, 0);
if (retval == -1) {
- if (errno == EINVAL) {
+ if (errno == EINVAL || errno == EINVAL) {
fprintf(stderr,
"\n...Update IRQs not supported.\n");
goto test_READ;
@@ -221,6 +221,11 @@ int main(int argc, char **argv)
/* Read the current alarm settings */
retval = ioctl(fd, RTC_ALM_READ, &rtc_tm);
if (retval == -1) {
+ if (errno == EINVAL) {
+ fprintf(stderr,
+ "\n...EINVAL reading current alarm setting.\n");
+ goto test_PIE;
+ }
perror("RTC_ALM_READ ioctl");
exit(errno);
}
@@ -231,7 +236,7 @@ int main(int argc, char **argv)
/* Enable alarm interrupts */
retval = ioctl(fd, RTC_AIE_ON, 0);
if (retval == -1) {
- if (errno == EINVAL) {
+ if (errno == EINVAL || errno ==EIO) {
fprintf(stderr,
"\n...Alarm IRQs not supported.\n");
goto test_PIE;
--
2.9.4
^ permalink raw reply related
* [PATCH 0/1] rtc: rtctest: Support opal-rtc and rtc-generic
From: Lukáš Doktor @ 2017-08-11 9:14 UTC (permalink / raw)
To: ldoktor, a.zummo, alexandre.belloni, john.stultz, tglx, sboyd,
shuah, linux-rtc, linux-kernel, linux-kselftest, linuxppc-dev
On ppc64le machines the opal-rtc, resp rtc-generic in guest is used. They only
support minimal set of functionality and fail this test in not-yet treated
way. This extends the checks and skips to the next test when feature is not
supported.
Lukáš Doktor (1):
rtc: rtctest: Improve support detection
tools/testing/selftests/timers/rtctest.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
2.9.4
^ permalink raw reply
* Re: [PATCH v2 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver
From: Chen Zhong @ 2017-08-11 7:18 UTC (permalink / raw)
To: Lee Jones
Cc: Dmitry Torokhov, Rob Herring, Mark Rutland, Matthias Brugger,
Eddie Huang, Alessandro Zummo, Alexandre Belloni, Jaechul Lee,
Jonathan Cameron, Javier Martinez Canillas, Linus Walleij,
Beomho Seo, linux-input, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, linux-rtc
In-Reply-To: <20170808111556.dmx2s6bcwnsccrkn@dell>
On Tue, 2017-08-08 at 12:15 +0100, Lee Jones wrote:
> On Mon, 07 Aug 2017, Chen Zhong wrote:
>
> > This patch adds compatible strings and interrupts for pmic keys
> > which serves as child device of MFD.
> >
> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> > ---
> > drivers/mfd/mt6397-core.c | 36 +++++++++++++++++++++++++++++++++++-
> > 1 file changed, 35 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 6546d7f..3c6a765 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
> > @@ -43,6 +43,30 @@
> > },
> > };
> >
> > +static const struct resource mt6323_keys_resources[] = {
> > + {
> > + .start = MT6323_IRQ_STATUS_PWRKEY,
> > + .end = MT6323_IRQ_STATUS_PWRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + }, {
> > + .start = MT6323_IRQ_STATUS_FCHRKEY,
> > + .end = MT6323_IRQ_STATUS_FCHRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + },
> > +};
> > +
> > +static const struct resource mt6397_keys_resources[] = {
> > + {
> > + .start = MT6397_IRQ_PWRKEY,
> > + .end = MT6397_IRQ_PWRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + }, {
> > + .start = MT6397_IRQ_HOMEKEY,
> > + .end = MT6397_IRQ_HOMEKEY,
> > + .flags = IORESOURCE_IRQ,
> > + },
> > +};
>
> We have better ways to define these now.
>
> Please grep for "DEFINE_RES_"
I'll define these with "DEFINE_RES_IRQ" here, Thank you for your
suggestion.
>
> > static const struct mfd_cell mt6323_devs[] = {
> > {
> > .name = "mt6323-regulator",
> > @@ -50,6 +74,11 @@
> > }, {
> > .name = "mt6323-led",
> > .of_compatible = "mediatek,mt6323-led"
> > + }, {
> > + .name = "mtk-pmic-keys",
> > + .num_resources = ARRAY_SIZE(mt6323_keys_resources),
> > + .resources = mt6323_keys_resources,
> > + .of_compatible = "mediatek,mt6323-keys"
> > },
> > };
> >
> > @@ -71,7 +100,12 @@
> > }, {
> > .name = "mt6397-pinctrl",
> > .of_compatible = "mediatek,mt6397-pinctrl",
> > - },
> > + }, {
> > + .name = "mtk-pmic-keys",
> > + .num_resources = ARRAY_SIZE(mt6397_keys_resources),
> > + .resources = mt6397_keys_resources,
> > + .of_compatible = "mediatek,mt6397-keys"
> > + }
> > };
> >
> > static void mt6397_irq_lock(struct irq_data *data)
>
^ permalink raw reply
* Re: [PATCH v2 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys
From: Chen Zhong @ 2017-08-11 7:01 UTC (permalink / raw)
To: Rob Herring
Cc: Dmitry Torokhov, Mark Rutland, Matthias Brugger, Lee Jones,
Eddie Huang, Alessandro Zummo, Alexandre Belloni, Jaechul Lee,
Jonathan Cameron, Javier Martinez Canillas, Linus Walleij,
Beomho Seo, linux-input, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, linux-rtc
In-Reply-To: <20170810204136.eghsslqq6d5fqg5d@rob-hp-laptop>
Hi Rob,
On Thu, 2017-08-10 at 15:41 -0500, Rob Herring wrote:
> On Mon, Aug 07, 2017 at 09:57:42AM +0800, Chen Zhong wrote:
> > This patch adds the device tree binding documentation for the MediaTek
> > pmic keys found on PMIC MT6397/MT6323.
> >
> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> > ---
> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 36 ++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> > new file mode 100644
> > index 0000000..c5b230f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> > @@ -0,0 +1,36 @@
> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver
> > +
> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey
> > +and homekey. The key functions are defined as the subnode of the function
> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind
> > +of Muti-Function Device (MFD)
> > +
> > +For MT6397/MT6323 MFD bindings see:
> > +Documentation/devicetree/bindings/mfd/mt6397.txt
> > +
> > +Required properties:
> > +- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> > +- mediatek,pwrkey-code: Keycode of pwrkey
> > +
> > +Optional Properties:
> > +- mediatek,homekey-code: Keycode of homekey
> > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for
> > + pwrkey only, 2 for pwrkey/homekey together, others for disabled.
> > +- mediatek,long-press-duration: Long press key shutdown duration setting,
> > + 0/1/2/3 for 8/11/14/5 seconds.
>
> Surely this could be a common property.
Sorry I'm not very clear about this. Could i move this to required
properties or remove the "mediatek" string here?
>
> > +
> > +Example:
> > +
> > + pmic: mt6397 {
> > + compatible = "mediatek,mt6397";
> > +
> > + ...
> > +
> > + mt6397keys: mt6397keys {
> > + compatible = "mediatek,mt6397-keys";
> > + mediatek,pwrkey-code = <116>;
> > + mediatek,homekey-code = <114>;
>
> We have a standard properties for keycodes.
Could i write them like this way?
linux,keycodes = <KEY_POWER>, <KEY_VOLUMEDOWN>
>
> > + mediatek,long-press-mode = <1>;
> > + mediatek,long-press-duration = <0>;
> > + };
> > + };
> > \ No newline at end of file
> > --
> > 1.7.9.5
> >
Thanks.
^ permalink raw reply
* Re: [PATCH 2/4] rtc: pl031: use devm_* for allocating memory and mapping resource
From: Alexandre Belloni @ 2017-08-10 21:05 UTC (permalink / raw)
To: Russell King; +Cc: Alessandro Zummo, Linus Walleij, linux-arm-kernel, linux-rtc
In-Reply-To: <E1dYKiF-0001kS-1w@rmk-PC.armlinux.org.uk>
Hi Russell,
On 21/07/2017 at 00:18:31 +0100, Russell King wrote:
> Use the devm_* APIs for allocating memory and mapping the memory in
> the probe function to relieve the driver from having to deal with
> this in the cleanup paths.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> drivers/rtc/rtc-pl031.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
> index 0d87b90b1903..5960fbd08b05 100644
> --- a/drivers/rtc/rtc-pl031.c
> +++ b/drivers/rtc/rtc-pl031.c
> @@ -310,8 +310,6 @@ static int pl031_remove(struct amba_device *adev)
> device_init_wakeup(&adev->dev, false);
> free_irq(adev->irq[0], ldata);
> rtc_device_unregister(ldata->rtc);
> - iounmap(ldata->base);
> - kfree(ldata);
> amba_release_regions(adev);
>
> return 0;
> @@ -322,25 +320,26 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id)
> int ret;
> struct pl031_local *ldata;
> struct pl031_vendor_data *vendor = id->data;
> - struct rtc_class_ops *ops = &vendor->ops;
> + struct rtc_class_ops *ops;
This change should probably go in patch 3/4
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
* Re: [PATCH v2 3/5] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC
From: Rob Herring @ 2017-08-10 20:42 UTC (permalink / raw)
To: Chen Zhong
Cc: Dmitry Torokhov, Mark Rutland, Matthias Brugger, Lee Jones,
Eddie Huang, Alessandro Zummo, Alexandre Belloni, Jaechul Lee,
Jonathan Cameron, Javier Martinez Canillas, Linus Walleij,
Beomho Seo, linux-input, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, linux-rtc
In-Reply-To: <1502071065-6745-4-git-send-email-chen.zhong@mediatek.com>
On Mon, Aug 07, 2017 at 09:57:43AM +0800, Chen Zhong wrote:
> This patch adds documentation for device tree bindings for keys support
> as the subnode of MT6397/MT6323 PMIC.
>
> Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> ---
> Documentation/devicetree/bindings/mfd/mt6397.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply
* Re: [PATCH v2 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys
From: Rob Herring @ 2017-08-10 20:41 UTC (permalink / raw)
To: Chen Zhong
Cc: Dmitry Torokhov, Mark Rutland, Matthias Brugger, Lee Jones,
Eddie Huang, Alessandro Zummo, Alexandre Belloni, Jaechul Lee,
Jonathan Cameron, Javier Martinez Canillas, Linus Walleij,
Beomho Seo, linux-input, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, linux-rtc
In-Reply-To: <1502071065-6745-3-git-send-email-chen.zhong@mediatek.com>
On Mon, Aug 07, 2017 at 09:57:42AM +0800, Chen Zhong wrote:
> This patch adds the device tree binding documentation for the MediaTek
> pmic keys found on PMIC MT6397/MT6323.
>
> Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> ---
> .../devicetree/bindings/input/mtk-pmic-keys.txt | 36 ++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
>
> diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> new file mode 100644
> index 0000000..c5b230f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> @@ -0,0 +1,36 @@
> +MediaTek MT6397/MT6323 PMIC Keys Device Driver
> +
> +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey
> +and homekey. The key functions are defined as the subnode of the function
> +node provided by MT6397/MT6323 PMIC that is being defined as one kind
> +of Muti-Function Device (MFD)
> +
> +For MT6397/MT6323 MFD bindings see:
> +Documentation/devicetree/bindings/mfd/mt6397.txt
> +
> +Required properties:
> +- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> +- mediatek,pwrkey-code: Keycode of pwrkey
> +
> +Optional Properties:
> +- mediatek,homekey-code: Keycode of homekey
> +- mediatek,long-press-mode: Long press key shutdown setting, 1 for
> + pwrkey only, 2 for pwrkey/homekey together, others for disabled.
> +- mediatek,long-press-duration: Long press key shutdown duration setting,
> + 0/1/2/3 for 8/11/14/5 seconds.
Surely this could be a common property.
> +
> +Example:
> +
> + pmic: mt6397 {
> + compatible = "mediatek,mt6397";
> +
> + ...
> +
> + mt6397keys: mt6397keys {
> + compatible = "mediatek,mt6397-keys";
> + mediatek,pwrkey-code = <116>;
> + mediatek,homekey-code = <114>;
We have a standard properties for keycodes.
> + mediatek,long-press-mode = <1>;
> + mediatek,long-press-duration = <0>;
> + };
> + };
> \ No newline at end of file
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver
From: Alexandre Belloni @ 2017-08-10 20:34 UTC (permalink / raw)
To: Aleksandar Markovic
Cc: linux-mips, Miodrag Dinic, Goran Ferenc, Aleksandar Markovic,
Alessandro Zummo, Bo Hu, David S. Miller, Douglas Leung,
Greg Kroah-Hartman, James Hogan, Jin Qian, linux-kernel,
linux-rtc, Mauro Carvalho Chehab, Paul Burton, Petar Jovanovic,
Raghu Gandham
In-Reply-To: <1500656111-9520-3-git-send-email-aleksandar.markovic@rt-rk.com>
Hi,
On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> Add device driver for a virtual Goldfish RTC clock.
>
> The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are
> set. The compatible string used by OS for binding the driver is
> defined as "google,goldfish-rtc".
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
> MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 8 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 243 insertions(+)
> create mode 100644 drivers/rtc/rtc-goldfish.c
>
Do you mind fixing the remaining checkpatch --strict issues, the two
kbuild errors and the warning reported by Julia?
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox