From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
To: Andrew Morton <akpm@google.com>
Cc: vgoyal@redhat.com, ebiederm@xmission.com,
mahesh@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/2] kdump: Initialize vmcoreinfo note at startup
Date: Wed, 21 Sep 2011 10:49:08 +0200 [thread overview]
Message-ID: <1316594948.3888.3.camel@br98xy6r> (raw)
In-Reply-To: <20110920155912.d107fd49.akpm@google.com>
Hello Andrew,
On Tue, 2011-09-20 at 15:59 -0700, Andrew Morton wrote:
> On Tue, 20 Sep 2011 16:34:01 +0200
[snip]
> Michael Holzheu <holzheu@linux.vnet.ibm.com> wrote:
> > -void crash_save_vmcoreinfo(void)
> > +static void update_vmcoreinfo_note(void)
> > {
> > - u32 *buf;
> > + u32 *buf = (u32 *) vmcoreinfo_note;
>
> The cast is unneeded?
Correct. I removed the cast (with the blank :), thanks!
Michael
next prev parent reply other threads:[~2011-09-21 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 14:34 [patch 0/2] kdump: Initialize vmcoreinfo note at startup Michael Holzheu
2011-09-20 14:34 ` [patch 1/2] " Michael Holzheu
2011-09-20 22:59 ` Andrew Morton
2011-09-21 8:49 ` Michael Holzheu [this message]
2011-09-20 14:34 ` [patch 2/2] s390: Export vmcoreinfo note Michael Holzheu
2011-09-20 23:00 ` [patch 0/2] kdump: Initialize vmcoreinfo note at startup Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316594948.3888.3.camel@br98xy6r \
--to=holzheu@linux.vnet.ibm.com \
--cc=akpm@google.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox