From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: schwidefsky@de.ibm.com, freude@de.ibm.com,
heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org,
sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com,
sebott@linux.vnet.ibm.com, oberpar@linux.vnet.ibm.com,
wi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
jwi@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 5/8] s390: qeth: constify attribute_group structures.
Date: Wed, 19 Jul 2017 12:39:14 +0530 [thread overview]
Message-ID: <1500448157-24668-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500448157-24668-1-git-send-email-arvind.yadav.cs@gmail.com>
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6763 1216 0 7979 1f2b drivers/s390/net/qeth_l3_sys.o
File size After adding 'const':
text data bss dec hex filename
7019 960 0 7971 1f2b drivers/s390/net/qeth_l3_sys.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/s390/net/qeth_l3_sys.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index f2f94f5..1a80ce4 100644
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -350,7 +350,7 @@ static DEVICE_ATTR(hsuid, 0644, qeth_l3_dev_hsuid_show,
NULL,
};
-static struct attribute_group qeth_l3_device_attr_group = {
+static const struct attribute_group qeth_l3_device_attr_group = {
.attrs = qeth_l3_device_attrs,
};
@@ -680,7 +680,7 @@ static QETH_DEVICE_ATTR(ipato_del6, del6, 0200, NULL,
NULL,
};
-static struct attribute_group qeth_device_ipato_group = {
+static const struct attribute_group qeth_device_ipato_group = {
.name = "ipa_takeover",
.attrs = qeth_ipato_device_attrs,
};
@@ -843,7 +843,7 @@ static QETH_DEVICE_ATTR(vipa_del6, del6, 0200, NULL,
NULL,
};
-static struct attribute_group qeth_device_vipa_group = {
+static const struct attribute_group qeth_device_vipa_group = {
.name = "vipa",
.attrs = qeth_vipa_device_attrs,
};
@@ -1006,7 +1006,7 @@ static QETH_DEVICE_ATTR(rxip_del6, del6, 0200, NULL,
NULL,
};
-static struct attribute_group qeth_device_rxip_group = {
+static const struct attribute_group qeth_device_rxip_group = {
.name = "rxip",
.attrs = qeth_rxip_device_attrs,
};
--
1.9.1
next prev parent reply other threads:[~2017-07-19 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 7:09 [PATCH 0/8] constify s390 attribute_group structures Arvind Yadav
2017-07-19 7:09 ` [PATCH 1/8] s390: zcrypt_queue: constify " Arvind Yadav
2017-07-19 7:09 ` [PATCH 2/8] s390: zcrypt_card: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 3/8] s390: dasd_devmap: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 4/8] s390: device: " Arvind Yadav
2017-07-19 7:09 ` Arvind Yadav [this message]
2017-07-19 7:09 ` [PATCH 6/8] s390: raw3270: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 7/8] s390: tape_core: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 8/8] s390: sclp_ocf: " Arvind Yadav
2017-07-19 8:50 ` [PATCH 0/8] constify s390 " Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500448157-24668-6-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=freude@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=sth@linux.vnet.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
--cc=wi@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox