From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: schwidefsky@de.ibm.com, freude@de.ibm.com,
heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org,
sth@linux.vnet.ibm.com, hoeppner@linux.vnet.ibm.com,
sebott@linux.vnet.ibm.com, oberpar@linux.vnet.ibm.com,
wi@linux.vnet.ibm.com, ubraun@linux.vnet.ibm.com,
jwi@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] s390: tape_core: constify attribute_group structures.
Date: Wed, 19 Jul 2017 12:39:16 +0530 [thread overview]
Message-ID: <1500448157-24668-8-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500448157-24668-1-git-send-email-arvind.yadav.cs@gmail.com>
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11511 656 16 12183 2f97 drivers/s390/char/tape_core.o
File size After adding 'const':
text data bss dec hex filename
11575 592 16 12183 2f97 drivers/s390/char/tape_core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/s390/char/tape_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c
index 3c379da..9dd4534 100644
--- a/drivers/s390/char/tape_core.c
+++ b/drivers/s390/char/tape_core.c
@@ -175,7 +175,7 @@ static int devid_to_int(struct ccw_dev_id *dev_id)
NULL
};
-static struct attribute_group tape_attr_group = {
+static const struct attribute_group tape_attr_group = {
.attrs = tape_attrs,
};
--
1.9.1
next prev parent reply other threads:[~2017-07-19 7:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 7:09 [PATCH 0/8] constify s390 attribute_group structures Arvind Yadav
2017-07-19 7:09 ` [PATCH 1/8] s390: zcrypt_queue: constify " Arvind Yadav
2017-07-19 7:09 ` [PATCH 2/8] s390: zcrypt_card: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 3/8] s390: dasd_devmap: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 4/8] s390: device: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 5/8] s390: qeth: " Arvind Yadav
2017-07-19 7:09 ` [PATCH 6/8] s390: raw3270: " Arvind Yadav
2017-07-19 7:09 ` Arvind Yadav [this message]
2017-07-19 7:09 ` [PATCH 8/8] s390: sclp_ocf: " Arvind Yadav
2017-07-19 8:50 ` [PATCH 0/8] constify s390 " Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500448157-24668-8-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=freude@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=sth@linux.vnet.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
--cc=wi@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox