From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: mst@redhat.com, linux-s390@vger.kernel.org, sth@linux.ibm.com,
martin.petersen@oracle.com, dm-devel@redhat.com,
hoeppner@linux.ibm.com, linux-nvme@lists.infradead.org,
richard@nod.at, josef@toxicpanda.com,
virtualization@lists.linux-foundation.org, snitzer@kernel.org,
roger.pau@citrix.com, linux-um@lists.infradead.org,
linux-block@vger.kernel.org, song@kernel.org,
nbd@other.debian.org, linux-raid@vger.kernel.org,
johannes@sipsolutions.net, haris.iqbal@ionos.com,
xen-devel@lists.xenproject.org, jasowang@redhat.com,
jinpu.wang@ionos.com
Subject: Re: fix and cleanup discard_alignment handling
Date: Tue, 03 May 2022 10:39:07 -0600 [thread overview]
Message-ID: <165159594780.2557.1712299203175316151.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220418045314.360785-1-hch@lst.de>
On Mon, 18 Apr 2022 06:53:03 +0200, Christoph Hellwig wrote:
> the somewhat confusing name of the discard_alignment queue limit, that
> really is an offset for the discard granularity mislead a lot of driver
> authors to set it to an incorrect value. This series tries to fix up
> all these cases.
>
> Diffstat:
> arch/um/drivers/ubd_kern.c | 1 -
> drivers/block/loop.c | 1 -
> drivers/block/nbd.c | 3 ---
> drivers/block/null_blk/main.c | 1 -
> drivers/block/rnbd/rnbd-srv-dev.h | 2 +-
> drivers/block/virtio_blk.c | 7 ++++---
> drivers/block/xen-blkback/xenbus.c | 4 ++--
> drivers/md/dm-zoned-target.c | 2 +-
> drivers/md/raid5.c | 1 -
> drivers/nvme/host/core.c | 1 -
> drivers/s390/block/dasd_fba.c | 1 -
> 11 files changed, 8 insertions(+), 16 deletions(-)
>
> [...]
Applied, thanks!
[01/11] ubd: don't set the discard_alignment queue limit
commit: 07c6e92a8478770a7302f7dde72f03a5465901bd
[02/11] nbd: don't set the discard_alignment queue limit
commit: 4a04d517c56e0616c6f69afc226ee2691e543712
[03/11] null_blk: don't set the discard_alignment queue limit
commit: fb749a87f4536d2fa86ea135ae4eff1072903438
[04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits
commit: 62952cc5bccd89b76d710de1d0b43244af0f2903
[05/11] dm-zoned: don't set the discard_alignment queue limit
commit: 44d583702f4429763c558624fac763650a1f05bf
[06/11] raid5: don't set the discard_alignment queue limit
commit: 3d50d368c92ade2f98a3d0d28b842a57c35284e9
[07/11] dasd: don't set the discard_alignment queue limit
commit: c3f765299632727fa5ea5a0acf118665227a4f1a
[08/11] loop: remove a spurious clear of discard_alignment
commit: 4418bfd8fb9602d9cd8747c3ad52fdbaa02e2ffd
[09/11] nvme: remove a spurious clear of discard_alignment
commit: 4e7f0ece41e1be8f876f320a0972a715daec0a50
[10/11] rnbd-srv: use bdev_discard_alignment
commit: 18292faa89d2bff3bdd33ab9c065f45fb6710e47
[11/11] xen-blkback: use bdev_discard_alignment
commit: c899b23533866910c90ef4386b501af50270d320
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-05-03 16:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 4:53 fix and cleanup discard_alignment handling Christoph Hellwig
2022-04-18 4:53 ` [PATCH 01/11] ubd: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 4:53 ` [PATCH 02/11] nbd: " Christoph Hellwig
2022-04-18 4:53 ` [PATCH 03/11] null_blk: " Christoph Hellwig
2022-04-18 8:01 ` [dm-devel] " Damien Le Moal
2022-04-18 21:22 ` Chaitanya Kulkarni
2022-04-18 4:53 ` [PATCH 04/11] virtio_blk: fix the discard_granularity and discard_alignment queue limits Christoph Hellwig
2022-04-18 4:53 ` [PATCH 05/11] dm-zoned: don't set the discard_alignment queue limit Christoph Hellwig
2022-04-18 8:00 ` [dm-devel] " Damien Le Moal
2022-04-18 4:53 ` [PATCH 06/11] raid5: " Christoph Hellwig
2022-04-25 21:08 ` Song Liu
2022-04-18 4:53 ` [PATCH 07/11] dasd: " Christoph Hellwig
2022-05-06 12:56 ` Jan Höppner
2022-04-18 4:53 ` [PATCH 08/11] loop: remove a spurious clear of discard_alignment Christoph Hellwig
2022-04-18 8:04 ` [dm-devel] " Damien Le Moal
2022-04-18 21:21 ` Chaitanya Kulkarni
2022-04-18 4:53 ` [PATCH 09/11] nvme: " Christoph Hellwig
2022-04-18 8:02 ` [dm-devel] " Damien Le Moal
2022-04-18 21:23 ` Chaitanya Kulkarni
2022-04-26 14:25 ` Sagi Grimberg
2022-04-18 4:53 ` [PATCH 10/11] rnbd-srv: use bdev_discard_alignment Christoph Hellwig
2022-04-18 8:02 ` [dm-devel] " Damien Le Moal
2022-04-19 4:51 ` Jinpu Wang
2022-04-18 4:53 ` [PATCH 11/11] xen-blkback: " Christoph Hellwig
2022-04-18 8:03 ` [dm-devel] " Damien Le Moal
2022-04-26 4:16 ` fix and cleanup discard_alignment handling Martin K. Petersen
2022-05-02 16:46 ` Christoph Hellwig
2022-05-03 16:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165159594780.2557.1712299203175316151.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=haris.iqbal@ionos.com \
--cc=hch@lst.de \
--cc=hoeppner@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=jinpu.wang@ionos.com \
--cc=johannes@sipsolutions.net \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=richard@nod.at \
--cc=roger.pau@citrix.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=sth@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox