* [PATCH net-next] net/smc: Support SO_REUSEPORT
@ 2022-09-22 12:19 Tony Lu
2022-09-23 19:00 ` Wenjia Zhang
2022-09-27 8:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tony Lu @ 2022-09-22 12:19 UTC (permalink / raw)
To: kgraul, wenjia, davem, edumazet, kuba, pabeni; +Cc: netdev, linux-s390
This enables SO_REUSEPORT [1] for clcsock when it is set on smc socket,
so that some applications which uses it can be transparently replaced
with SMC. Also, this helps improve load distribution.
Here is a simple test of NGINX + wrk with SMC. The CPU usage is collected
on NGINX (server) side as below.
Disable SO_REUSEPORT:
05:15:33 PM CPU %usr %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
05:15:34 PM all 7.02 0.00 11.86 0.00 2.04 8.93 0.00 0.00 0.00 70.15
05:15:34 PM 0 0.00 0.00 0.00 0.00 16.00 70.00 0.00 0.00 0.00 14.00
05:15:34 PM 1 11.58 0.00 22.11 0.00 0.00 0.00 0.00 0.00 0.00 66.32
05:15:34 PM 2 1.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 98.00
05:15:34 PM 3 16.84 0.00 30.53 0.00 0.00 0.00 0.00 0.00 0.00 52.63
05:15:34 PM 4 28.72 0.00 44.68 0.00 0.00 0.00 0.00 0.00 0.00 26.60
05:15:34 PM 5 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
05:15:34 PM 6 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
05:15:34 PM 7 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
Enable SO_REUSEPORT:
05:15:20 PM CPU %usr %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
05:15:21 PM all 8.56 0.00 14.40 0.00 2.20 9.86 0.00 0.00 0.00 64.98
05:15:21 PM 0 0.00 0.00 4.08 0.00 14.29 76.53 0.00 0.00 0.00 5.10
05:15:21 PM 1 9.09 0.00 16.16 0.00 1.01 0.00 0.00 0.00 0.00 73.74
05:15:21 PM 2 9.38 0.00 16.67 0.00 1.04 0.00 0.00 0.00 0.00 72.92
05:15:21 PM 3 10.42 0.00 17.71 0.00 1.04 0.00 0.00 0.00 0.00 70.83
05:15:21 PM 4 9.57 0.00 15.96 0.00 0.00 0.00 0.00 0.00 0.00 74.47
05:15:21 PM 5 9.18 0.00 15.31 0.00 0.00 1.02 0.00 0.00 0.00 74.49
05:15:21 PM 6 8.60 0.00 15.05 0.00 0.00 0.00 0.00 0.00 0.00 76.34
05:15:21 PM 7 12.37 0.00 14.43 0.00 0.00 0.00 0.00 0.00 0.00 73.20
Using SO_REUSEPORT helps the load distribution of NGINX be more
balanced.
[1] https://man7.org/linux/man-pages/man7/socket.7.html
Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
---
net/smc/af_smc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
index 0939cc3b915a..d933a804c94b 100644
--- a/net/smc/af_smc.c
+++ b/net/smc/af_smc.c
@@ -427,6 +427,7 @@ static int smc_bind(struct socket *sock, struct sockaddr *uaddr,
goto out_rel;
smc->clcsock->sk->sk_reuse = sk->sk_reuse;
+ smc->clcsock->sk->sk_reuseport = sk->sk_reuseport;
rc = kernel_bind(smc->clcsock, uaddr, addr_len);
out_rel:
--
2.19.1.6.gb485710b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/smc: Support SO_REUSEPORT
2022-09-22 12:19 [PATCH net-next] net/smc: Support SO_REUSEPORT Tony Lu
@ 2022-09-23 19:00 ` Wenjia Zhang
2022-09-27 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Wenjia Zhang @ 2022-09-23 19:00 UTC (permalink / raw)
To: Tony Lu, kgraul, davem, edumazet, kuba, pabeni; +Cc: netdev, linux-s390
On 22.09.22 14:19, Tony Lu wrote:
> This enables SO_REUSEPORT [1] for clcsock when it is set on smc socket,
> so that some applications which uses it can be transparently replaced
> with SMC. Also, this helps improve load distribution.
>
> Here is a simple test of NGINX + wrk with SMC. The CPU usage is collected
> on NGINX (server) side as below.
>
> Disable SO_REUSEPORT:
>
> 05:15:33 PM CPU %usr %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
> 05:15:34 PM all 7.02 0.00 11.86 0.00 2.04 8.93 0.00 0.00 0.00 70.15
> 05:15:34 PM 0 0.00 0.00 0.00 0.00 16.00 70.00 0.00 0.00 0.00 14.00
> 05:15:34 PM 1 11.58 0.00 22.11 0.00 0.00 0.00 0.00 0.00 0.00 66.32
> 05:15:34 PM 2 1.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 98.00
> 05:15:34 PM 3 16.84 0.00 30.53 0.00 0.00 0.00 0.00 0.00 0.00 52.63
> 05:15:34 PM 4 28.72 0.00 44.68 0.00 0.00 0.00 0.00 0.00 0.00 26.60
> 05:15:34 PM 5 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
> 05:15:34 PM 6 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
> 05:15:34 PM 7 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00
>
> Enable SO_REUSEPORT:
>
> 05:15:20 PM CPU %usr %nice %sys %iowait %irq %soft %steal %guest %gnice %idle
> 05:15:21 PM all 8.56 0.00 14.40 0.00 2.20 9.86 0.00 0.00 0.00 64.98
> 05:15:21 PM 0 0.00 0.00 4.08 0.00 14.29 76.53 0.00 0.00 0.00 5.10
> 05:15:21 PM 1 9.09 0.00 16.16 0.00 1.01 0.00 0.00 0.00 0.00 73.74
> 05:15:21 PM 2 9.38 0.00 16.67 0.00 1.04 0.00 0.00 0.00 0.00 72.92
> 05:15:21 PM 3 10.42 0.00 17.71 0.00 1.04 0.00 0.00 0.00 0.00 70.83
> 05:15:21 PM 4 9.57 0.00 15.96 0.00 0.00 0.00 0.00 0.00 0.00 74.47
> 05:15:21 PM 5 9.18 0.00 15.31 0.00 0.00 1.02 0.00 0.00 0.00 74.49
> 05:15:21 PM 6 8.60 0.00 15.05 0.00 0.00 0.00 0.00 0.00 0.00 76.34
> 05:15:21 PM 7 12.37 0.00 14.43 0.00 0.00 0.00 0.00 0.00 0.00 73.20
>
> Using SO_REUSEPORT helps the load distribution of NGINX be more
> balanced.
>
> [1] https://man7.org/linux/man-pages/man7/socket.7.html
>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> ---
> net/smc/af_smc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 0939cc3b915a..d933a804c94b 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -427,6 +427,7 @@ static int smc_bind(struct socket *sock, struct sockaddr *uaddr,
> goto out_rel;
>
> smc->clcsock->sk->sk_reuse = sk->sk_reuse;
> + smc->clcsock->sk->sk_reuseport = sk->sk_reuseport;
> rc = kernel_bind(smc->clcsock, uaddr, addr_len);
>
> out_rel:
It looks good to me. Thank you!
Acked-by: Wenjia Zhang <wenjia@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/smc: Support SO_REUSEPORT
2022-09-22 12:19 [PATCH net-next] net/smc: Support SO_REUSEPORT Tony Lu
2022-09-23 19:00 ` Wenjia Zhang
@ 2022-09-27 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-27 8:40 UTC (permalink / raw)
To: Tony Lu; +Cc: kgraul, wenjia, davem, edumazet, kuba, pabeni, netdev, linux-s390
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Thu, 22 Sep 2022 20:19:07 +0800 you wrote:
> This enables SO_REUSEPORT [1] for clcsock when it is set on smc socket,
> so that some applications which uses it can be transparently replaced
> with SMC. Also, this helps improve load distribution.
>
> Here is a simple test of NGINX + wrk with SMC. The CPU usage is collected
> on NGINX (server) side as below.
>
> [...]
Here is the summary with links:
- [net-next] net/smc: Support SO_REUSEPORT
https://git.kernel.org/netdev/net-next/c/6627a2074d5c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-27 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-22 12:19 [PATCH net-next] net/smc: Support SO_REUSEPORT Tony Lu
2022-09-23 19:00 ` Wenjia Zhang
2022-09-27 8:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox