* Re: [PATCH net,v2] net/smc: add the max value of fallback reason count
2024-08-05 4:38 [PATCH net,v2] net/smc: add the max value of fallback reason count Zhengchao Shao
@ 2024-08-05 7:53 ` Wenjia Zhang
2024-08-05 7:59 ` D. Wythe
2024-08-08 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Wenjia Zhang @ 2024-08-05 7:53 UTC (permalink / raw)
To: Zhengchao Shao, linux-s390, netdev, davem, edumazet, kuba, pabeni
Cc: jaka, alibuda, tonylu, guwen, guangguan.wang, weiyongjun1,
yuehaibing
On 05.08.24 06:38, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
>
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: add fix tag and change max value to 36
> ---
> net/smc/smc_stats.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..e19177ce4092 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>
> #include "smc_clc.h"
>
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 36
>
> enum {
> SMC_BUF_8K,
It looks good to me!
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net,v2] net/smc: add the max value of fallback reason count
2024-08-05 4:38 [PATCH net,v2] net/smc: add the max value of fallback reason count Zhengchao Shao
2024-08-05 7:53 ` Wenjia Zhang
@ 2024-08-05 7:59 ` D. Wythe
2024-08-08 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: D. Wythe @ 2024-08-05 7:59 UTC (permalink / raw)
To: Zhengchao Shao, linux-s390, netdev, davem, edumazet, kuba, pabeni
Cc: wenjia, jaka, tonylu, guwen, guangguan.wang, weiyongjun1,
yuehaibing
On 8/5/24 12:38 PM, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
>
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> v2: add fix tag and change max value to 36
> ---
> net/smc/smc_stats.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..e19177ce4092 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>
> #include "smc_clc.h"
>
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 36
>
> enum {
> SMC_BUF_8K,
LGTM. Thanks
Reviewed-by: D. Wythe <alibuda@linux.alibaba.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net,v2] net/smc: add the max value of fallback reason count
2024-08-05 4:38 [PATCH net,v2] net/smc: add the max value of fallback reason count Zhengchao Shao
2024-08-05 7:53 ` Wenjia Zhang
2024-08-05 7:59 ` D. Wythe
@ 2024-08-08 3:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-08 3:30 UTC (permalink / raw)
To: shaozhengchao
Cc: linux-s390, netdev, davem, edumazet, kuba, pabeni, wenjia, jaka,
alibuda, tonylu, guwen, guangguan.wang, weiyongjun1, yuehaibing
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 5 Aug 2024 12:38:56 +0800 you wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
>
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
>
> [...]
Here is the summary with links:
- [net,v2] net/smc: add the max value of fallback reason count
https://git.kernel.org/netdev/net/c/d27a835f41d9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread