* Re: [build failure] Re: Linux 2.6.24-rc4 on S390x
2007-12-04 10:23 ` [build failure] Re: Linux 2.6.24-rc4 on S390x Kamalesh Babulal
@ 2007-12-04 10:31 ` Martin Schwidefsky
2007-12-04 10:32 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2007-12-04 10:31 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Linus Torvalds, Linux Kernel Mailing List, ptiedem, braunu, jeff,
linux-s390, Andy Whitcroft, Balbir Singh
On Tue, 2007-12-04 at 15:53 +0530, Kamalesh Babulal wrote:
> The patch ctc: make use of alloc_netdev() (commit 1c1478859017452a1179dbbdf7b9eb5b48438746)
> introduces the build failure
>
> CC [M] drivers/s390/net/fsm.o
> CC [M] drivers/s390/net/smsgiucv.o
> CC [M] drivers/s390/net/ctcmain.o
> drivers/s390/net/ctcmain.c: In function `ctc_init_netdevice':
> drivers/s390/net/ctcmain.c:2805: error: implicit declaration of function `SET_MODULE_OWNER'
> make[2]: *** [drivers/s390/net/ctcmain.o] Error 1
> make[1]: *** [drivers/s390/net] Error 2
> make: *** [drivers/s390] Error 2
Hi Uschi,
that last patch reverted commit 10d024c1b2fd58af8362670d7d6e5ae52fc33353.
That needs to get readded.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [build failure] Re: Linux 2.6.24-rc4 on S390x
2007-12-04 10:23 ` [build failure] Re: Linux 2.6.24-rc4 on S390x Kamalesh Babulal
2007-12-04 10:31 ` Martin Schwidefsky
@ 2007-12-04 10:32 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2007-12-04 10:32 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Linus Torvalds, Linux Kernel Mailing List, ptiedem, braunu, jeff,
linux-s390, Andy Whitcroft, Balbir Singh, Andrew Morton
* Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:
> The patch ctc: make use of alloc_netdev() (commit
> 1c1478859017452a1179dbbdf7b9eb5b48438746) introduces the build failure
>
> CC [M] drivers/s390/net/fsm.o
> CC [M] drivers/s390/net/smsgiucv.o
> CC [M] drivers/s390/net/ctcmain.o
> drivers/s390/net/ctcmain.c: In function `ctc_init_netdevice':
> drivers/s390/net/ctcmain.c:2805: error: implicit declaration of function `SET_MODULE_OWNER'
> make[2]: *** [drivers/s390/net/ctcmain.o] Error 1
> make[1]: *** [drivers/s390/net] Error 2
> make: *** [drivers/s390] Error 2
the patch below should fix this.
Ingo
------------>
Subject: drivers/s390/net/ctcmain.c: fix build bug
From: Ingo Molnar <mingo@elte.hu>
SET_MODULE_OWNER() is obsolete.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/s390/net/ctcmain.c | 1 -
1 file changed, 1 deletion(-)
Index: linux/drivers/s390/net/ctcmain.c
===================================================================
--- linux.orig/drivers/s390/net/ctcmain.c
+++ linux/drivers/s390/net/ctcmain.c
@@ -2802,7 +2802,6 @@ void ctc_init_netdevice(struct net_devic
dev->type = ARPHRD_SLIP;
dev->tx_queue_len = 100;
dev->flags = IFF_POINTOPOINT | IFF_NOARP;
- SET_MODULE_OWNER(dev);
}
^ permalink raw reply [flat|nested] 3+ messages in thread