From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Sachin Sant <sachinp@in.ibm.com>, Ingo Molnar <mingo@elte.hu>
Cc: linux-s390@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: Next March 27 : s390 defconfig build failure
Date: Fri, 27 Mar 2009 15:40:27 +0100 [thread overview]
Message-ID: <20090327154027.55afeb02@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <49CCDB30.7010203@in.ibm.com>
On Fri, 27 Mar 2009 19:27:04 +0530
Sachin Sant <sachinp@in.ibm.com> wrote:
> Today's Next defconfig s390 build failed with
>
> arch/s390/hypfs/hypfs_diag.c: In function diag204_free_buffer:
> arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function free_pages
> arch/s390/hypfs/hypfs_diag.c: In function diag204_alloc_rbuf:
> arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function __get_free_pages
> arch/s390/hypfs/hypfs_diag.c:384: error: GFP_KERNEL undeclared (first use in this function)
Thanks for reporting. Ingo, could you pick up the patch below please?
Subject: [PATCH] s390/hypfs: fix build breakage
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Fix build breakage below which probably was introduced with
("rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints").
CC arch/s390/hypfs/hypfs_diag.o
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_free_buffer':
arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function 'free_pages'
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_alloc_rbuf':
arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function '__get_free_pages'
arch/s390/hypfs/hypfs_diag.c:384: error: 'GFP_KERNEL' undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once
arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.)
Reported-by: Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
arch/s390/hypfs/hypfs_diag.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-next/arch/s390/hypfs/hypfs_diag.c
===================================================================
--- linux-next.orig/arch/s390/hypfs/hypfs_diag.c
+++ linux-next/arch/s390/hypfs/hypfs_diag.c
@@ -12,6 +12,8 @@
#include <linux/types.h>
#include <linux/errno.h>
+#include <linux/gfp.h>
+#include <linux/slab.h>
#include <linux/string.h>
#include <linux/vmalloc.h>
#include <asm/ebcdic.h>
next prev parent reply other threads:[~2009-03-27 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090327231924.4e4168c5.sfr@canb.auug.org.au>
2009-03-27 13:57 ` Next March 27 : s390 defconfig build failure Sachin Sant
2009-03-27 14:40 ` Heiko Carstens [this message]
2009-03-30 9:51 ` Sachin Sant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327154027.55afeb02@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sachinp@in.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox