* Next March 27 : s390 defconfig build failure
[not found] <20090327231924.4e4168c5.sfr@canb.auug.org.au>
@ 2009-03-27 13:57 ` Sachin Sant
2009-03-27 14:40 ` Heiko Carstens
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Sant @ 2009-03-27 13:57 UTC (permalink / raw)
To: linux-s390; +Cc: Stephen Rothwell, linux-next, heiko.carstens
Today's Next defconfig s390 build failed with
arch/s390/hypfs/hypfs_diag.c: In function diag204_free_buffer:
arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function free_pages
arch/s390/hypfs/hypfs_diag.c: In function diag204_alloc_rbuf:
arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function __get_free_pages
arch/s390/hypfs/hypfs_diag.c:384: error: GFP_KERNEL undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once
arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.)
arch/s390/hypfs/hypfs_diag.c:384: warning: cast to pointer from integer of different size
arch/s390/hypfs/hypfs_diag.c: In function diag224_get_name_table:
arch/s390/hypfs/hypfs_diag.c:503: error: implicit declaration of function kmalloc
arch/s390/hypfs/hypfs_diag.c:503: error: GFP_KERNEL undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:503: error: GFP_DMA undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:503: warning: assignment makes pointer from integer without a cast
arch/s390/hypfs/hypfs_diag.c:507: error: implicit declaration of function kfree
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Next March 27 : s390 defconfig build failure
2009-03-27 13:57 ` Next March 27 : s390 defconfig build failure Sachin Sant
@ 2009-03-27 14:40 ` Heiko Carstens
2009-03-30 9:51 ` Sachin Sant
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2009-03-27 14:40 UTC (permalink / raw)
To: Sachin Sant, Ingo Molnar
Cc: linux-s390, Stephen Rothwell, linux-next, Martin Schwidefsky
On Fri, 27 Mar 2009 19:27:04 +0530
Sachin Sant <sachinp@in.ibm.com> wrote:
> Today's Next defconfig s390 build failed with
>
> arch/s390/hypfs/hypfs_diag.c: In function diag204_free_buffer:
> arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function free_pages
> arch/s390/hypfs/hypfs_diag.c: In function diag204_alloc_rbuf:
> arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function __get_free_pages
> arch/s390/hypfs/hypfs_diag.c:384: error: GFP_KERNEL undeclared (first use in this function)
Thanks for reporting. Ingo, could you pick up the patch below please?
Subject: [PATCH] s390/hypfs: fix build breakage
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Fix build breakage below which probably was introduced with
("rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints").
CC arch/s390/hypfs/hypfs_diag.o
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_free_buffer':
arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function 'free_pages'
arch/s390/hypfs/hypfs_diag.c: In function 'diag204_alloc_rbuf':
arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function '__get_free_pages'
arch/s390/hypfs/hypfs_diag.c:384: error: 'GFP_KERNEL' undeclared (first use in this function)
arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once
arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.)
Reported-by: Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
arch/s390/hypfs/hypfs_diag.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-next/arch/s390/hypfs/hypfs_diag.c
===================================================================
--- linux-next.orig/arch/s390/hypfs/hypfs_diag.c
+++ linux-next/arch/s390/hypfs/hypfs_diag.c
@@ -12,6 +12,8 @@
#include <linux/types.h>
#include <linux/errno.h>
+#include <linux/gfp.h>
+#include <linux/slab.h>
#include <linux/string.h>
#include <linux/vmalloc.h>
#include <asm/ebcdic.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Next March 27 : s390 defconfig build failure
2009-03-27 14:40 ` Heiko Carstens
@ 2009-03-30 9:51 ` Sachin Sant
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Sant @ 2009-03-30 9:51 UTC (permalink / raw)
To: Heiko Carstens
Cc: Ingo Molnar, linux-s390, Stephen Rothwell, linux-next,
Martin Schwidefsky
Heiko Carstens wrote:
> Thanks for reporting. Ingo, could you pick up the patch below please?
>
> Subject: [PATCH] s390/hypfs: fix build breakage
>
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Fix build breakage below which probably was introduced with
> ("rcu: don't include unnecessary headers, allow kmemtrace w/ tracepoints").
>
> CC arch/s390/hypfs/hypfs_diag.o
> arch/s390/hypfs/hypfs_diag.c: In function 'diag204_free_buffer':
> arch/s390/hypfs/hypfs_diag.c:364: error: implicit declaration of function 'free_pages'
> arch/s390/hypfs/hypfs_diag.c: In function 'diag204_alloc_rbuf':
> arch/s390/hypfs/hypfs_diag.c:384: error: implicit declaration of function '__get_free_pages'
> arch/s390/hypfs/hypfs_diag.c:384: error: 'GFP_KERNEL' undeclared (first use in this function)
> arch/s390/hypfs/hypfs_diag.c:384: error: (Each undeclared identifier is reported only once
> arch/s390/hypfs/hypfs_diag.c:384: error: for each function it appears in.)
>
> Reported-by: Sachin Sant <sachinp@in.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
Today's next tree also has this build failure and the above mentioned
patch fixes the issue.
Tested-by : Sachin Sant <sachinp@in.ibm.com>
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-30 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090327231924.4e4168c5.sfr@canb.auug.org.au>
2009-03-27 13:57 ` Next March 27 : s390 defconfig build failure Sachin Sant
2009-03-27 14:40 ` Heiko Carstens
2009-03-30 9:51 ` Sachin Sant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox