From: David Miller <davem@davemloft.net>
To: sachinp@in.ibm.com
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
linux-s390@vger.kernel.org
Subject: Re: Next 14: s390x defconfig build failure
Date: Tue, 14 Apr 2009 01:55:51 -0700 (PDT) [thread overview]
Message-ID: <20090414.015551.220726058.davem@davemloft.net> (raw)
In-Reply-To: <49E44C15.4050208@in.ibm.com>
From: Sachin Sant <sachinp@in.ibm.com>
Date: Tue, 14 Apr 2009 14:10:53 +0530
> Today's next tree build (defconfig s390x ) failed with following
> error.
>
> In file included from kernel/panic.c:11:
> include/linux/debug_locks.h: In function __debug_locks_off:
> include/linux/debug_locks.h:15: error: implicit declaration of
> function xchg
>
> Probably because of commit 9eeba6138cefc0435695463ddadb0d95e0a6bcd2.
I see that Stephen fixed this by adding a asm/system.h include
to asm/atomic.h on sparc.
I don't agree with this, and now we have yet another platform
broken in the same way.
If debug_locks.h needs xchg() I think it should include asm/system.h
which was always the traditional location from which to include that
declaration.
It is even the case on x86.
We get it via asm/atomic.h by accident on x86 and other platforms, not
because that's the canonical location from which to get xchg().
prev parent reply other threads:[~2009-04-14 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090414160809.e92d9d3e.sfr@canb.auug.org.au>
2009-04-14 8:40 ` Next 14: s390x defconfig build failure Sachin Sant
2009-04-14 8:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090414.015551.220726058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sachinp@in.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox