* Next 14: s390x defconfig build failure
[not found] <20090414160809.e92d9d3e.sfr@canb.auug.org.au>
@ 2009-04-14 8:40 ` Sachin Sant
2009-04-14 8:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Sant @ 2009-04-14 8:40 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, LKML, fweisbec, linux-s390
Today's next tree build (defconfig s390x ) failed with following
error.
In file included from kernel/panic.c:11:
include/linux/debug_locks.h: In function __debug_locks_off:
include/linux/debug_locks.h:15: error: implicit declaration of function xchg
Probably because of commit 9eeba6138cefc0435695463ddadb0d95e0a6bcd2.
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Next 14: s390x defconfig build failure
2009-04-14 8:40 ` Next 14: s390x defconfig build failure Sachin Sant
@ 2009-04-14 8:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-04-14 8:55 UTC (permalink / raw)
To: sachinp; +Cc: sfr, linux-next, linux-kernel, fweisbec, linux-s390
From: Sachin Sant <sachinp@in.ibm.com>
Date: Tue, 14 Apr 2009 14:10:53 +0530
> Today's next tree build (defconfig s390x ) failed with following
> error.
>
> In file included from kernel/panic.c:11:
> include/linux/debug_locks.h: In function __debug_locks_off:
> include/linux/debug_locks.h:15: error: implicit declaration of
> function xchg
>
> Probably because of commit 9eeba6138cefc0435695463ddadb0d95e0a6bcd2.
I see that Stephen fixed this by adding a asm/system.h include
to asm/atomic.h on sparc.
I don't agree with this, and now we have yet another platform
broken in the same way.
If debug_locks.h needs xchg() I think it should include asm/system.h
which was always the traditional location from which to include that
declaration.
It is even the case on x86.
We get it via asm/atomic.h by accident on x86 and other platforms, not
because that's the canonical location from which to get xchg().
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-14 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090414160809.e92d9d3e.sfr@canb.auug.org.au>
2009-04-14 8:40 ` Next 14: s390x defconfig build failure Sachin Sant
2009-04-14 8:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox