Linux s390 Architecture development
 help / color / mirror / Atom feed
* Re: [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held
       [not found] <Pine.LNX.4.64.1005302227470.19253@ask.diku.dk>
@ 2010-05-31  8:38 ` Christian Borntraeger
  2010-05-31  8:56   ` Martin Schwidefsky
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Borntraeger @ 2010-05-31  8:38 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Carsten Otte, linux390, Avi Kivity, Marcelo Tosatti,
	Martin Schwidefsky, Heiko Carstens, linux-s390, kvm, linux-kernel,
	kernel-janitors

> The containing function is called from several places.  At one of them, in
> the function __sigp_stop, the spin lock &fi->lock is held.
[...]
> Signed-off-by: Julia Lawall <julia@diku.dk>

Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

[...]
> --- a/arch/s390/kvm/sigp.c
> +++ b/arch/s390/kvm/sigp.c
> @@ -113,7 +113,7 @@ static int __inject_sigp_stop(struct kvm
>  {
>  	struct kvm_s390_interrupt_info *inti;
> 
> -	inti = kzalloc(sizeof(*inti), GFP_KERNEL);
> +	inti = kzalloc(sizeof(*inti), GFP_ATOMIC);
>  	if (!inti)
>  		return -ENOMEM;
>  	inti->type = KVM_S390_SIGP_STOP;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held
  2010-05-31  8:38 ` [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held Christian Borntraeger
@ 2010-05-31  8:56   ` Martin Schwidefsky
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Schwidefsky @ 2010-05-31  8:56 UTC (permalink / raw)
  To: Christian Borntraeger
  Cc: Julia Lawall, Carsten Otte, linux390, Avi Kivity, Marcelo Tosatti,
	Heiko Carstens, linux-s390, kvm, linux-kernel, kernel-janitors

On Mon, 31 May 2010 10:38:07 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> > The containing function is called from several places.  At one of them, in
> > the function __sigp_stop, the spin lock &fi->lock is held.
> [...]
> > Signed-off-by: Julia Lawall <julia@diku.dk>
> 
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

Ok, I'll add the patch to git390. Thanks.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-31  8:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <Pine.LNX.4.64.1005302227470.19253@ask.diku.dk>
2010-05-31  8:38 ` [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held Christian Borntraeger
2010-05-31  8:56   ` Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox