* [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
[not found] <1341968967.13724.23.camel@joe2Laptop>
@ 2012-07-13 5:33 ` Joe Perches
2012-07-13 5:33 ` [PATCH net-next 6/8] s390: Use eth_random_addr Joe Perches
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Joe Perches @ 2012-07-13 5:33 UTC (permalink / raw)
To: David Miller, netdev, linux-usb, wimax, linux-wireless, users,
linux-s390
Cc: Johannes Berg, uclinux-dist-devel, linux-kernel, linux-c6x-dev,
linux-mips, user-mode-linux-devel, user-mode-linux-user,
e1000-devel
net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
added a new style API. Rename random_ether_addr to eth_random_addr to
create some API symmetry.
Joe Perches (8):
etherdevice: Rename random_ether_addr to eth_random_addr
ethernet: Use eth_random_addr
net: usb: Use eth_random_addr
wireless: Use eth_random_addr
drivers/net: Use eth_random_addr
s390: Use eth_random_addr
usb: Use eth_random_addr
arch: Use eth_random_addr
arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
arch/c6x/kernel/soc.c | 2 +-
arch/mips/ar7/platform.c | 4 ++--
arch/mips/powertv/powertv_setup.c | 6 +++---
arch/um/drivers/net_kern.c | 2 +-
drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | 2 +-
drivers/net/ethernet/atheros/atlx/atl1.c | 2 +-
drivers/net/ethernet/atheros/atlx/atl2.c | 2 +-
drivers/net/ethernet/ethoc.c | 2 +-
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
drivers/net/ethernet/lantiq_etop.c | 2 +-
drivers/net/ethernet/micrel/ks8851.c | 2 +-
drivers/net/ethernet/micrel/ks8851_mll.c | 2 +-
drivers/net/ethernet/smsc/smsc911x.c | 2 +-
drivers/net/ethernet/ti/cpsw.c | 2 +-
drivers/net/ethernet/tile/tilegx.c | 2 +-
drivers/net/ethernet/wiznet/w5100.c | 2 +-
drivers/net/ethernet/wiznet/w5300.c | 2 +-
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
drivers/net/tun.c | 2 +-
drivers/net/usb/smsc75xx.c | 2 +-
drivers/net/usb/smsc95xx.c | 2 +-
drivers/net/usb/usbnet.c | 2 +-
drivers/net/wimax/i2400m/driver.c | 2 +-
drivers/net/wireless/adm8211.c | 2 +-
drivers/net/wireless/p54/eeprom.c | 2 +-
drivers/net/wireless/rt2x00/rt2400pci.c | 2 +-
drivers/net/wireless/rt2x00/rt2500pci.c | 2 +-
drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
drivers/net/wireless/rt2x00/rt61pci.c | 2 +-
drivers/net/wireless/rt2x00/rt73usb.c | 2 +-
drivers/net/wireless/rtl818x/rtl8180/dev.c | 2 +-
drivers/net/wireless/rtl818x/rtl8187/dev.c | 2 +-
drivers/s390/net/qeth_l2_main.c | 2 +-
drivers/s390/net/qeth_l3_main.c | 2 +-
drivers/usb/atm/xusbatm.c | 4 ++--
drivers/usb/gadget/u_ether.c | 2 +-
include/linux/etherdevice.h | 14 ++++++++------
40 files changed, 52 insertions(+), 50 deletions(-)
--
1.7.8.111.gad25c.dirty
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH net-next 6/8] s390: Use eth_random_addr
2012-07-13 5:33 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
@ 2012-07-13 5:33 ` Joe Perches
2012-07-16 10:14 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
2012-07-17 5:39 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2012-07-13 5:33 UTC (permalink / raw)
To: David Miller, Ursula Braun, Frank Blaschka, linux390
Cc: Johannes Berg, Martin Schwidefsky, Heiko Carstens, linux-s390,
linux-kernel
Convert the existing uses of random_ether_addr to
the new eth_random_addr.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/s390/net/qeth_l2_main.c | 2 +-
drivers/s390/net/qeth_l3_main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index 4269865..b09355c 100644
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -647,7 +647,7 @@ static int qeth_l2_request_initial_mac(struct qeth_card *card)
}
QETH_DBF_HEX(SETUP, 2, card->dev->dev_addr, OSA_ADDR_LEN);
} else {
- random_ether_addr(card->dev->dev_addr);
+ eth_random_addr(card->dev->dev_addr);
memcpy(card->dev->dev_addr, vendor_pre, 3);
}
return 0;
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 73ac63d..bada7f6 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -1473,7 +1473,7 @@ static int qeth_l3_iqd_read_initial_mac_cb(struct qeth_card *card,
memcpy(card->dev->dev_addr,
cmd->data.create_destroy_addr.unique_id, ETH_ALEN);
else
- random_ether_addr(card->dev->dev_addr);
+ eth_random_addr(card->dev->dev_addr);
return 0;
}
--
1.7.8.111.gad25c.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
2012-07-13 5:33 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
2012-07-13 5:33 ` [PATCH net-next 6/8] s390: Use eth_random_addr Joe Perches
@ 2012-07-16 10:14 ` Felipe Balbi
2012-07-16 10:29 ` David Miller
2012-07-17 5:39 ` David Miller
2 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2012-07-16 10:14 UTC (permalink / raw)
To: Joe Perches
Cc: David Miller, netdev, linux-usb, wimax, linux-wireless, users,
linux-s390, Johannes Berg, uclinux-dist-devel, linux-kernel,
linux-c6x-dev, linux-mips, user-mode-linux-devel,
user-mode-linux-user, e1000-devel
[-- Attachment #1: Type: text/plain, Size: 3669 bytes --]
On Thu, Jul 12, 2012 at 10:33:04PM -0700, Joe Perches wrote:
> net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
> added a new style API. Rename random_ether_addr to eth_random_addr to
> create some API symmetry.
>
> Joe Perches (8):
> etherdevice: Rename random_ether_addr to eth_random_addr
if you're really renaming the function, then this patch alone will break
all of the below users. That should all be a single patch, I'm afraid.
> ethernet: Use eth_random_addr
> net: usb: Use eth_random_addr
> wireless: Use eth_random_addr
> drivers/net: Use eth_random_addr
> s390: Use eth_random_addr
> usb: Use eth_random_addr
> arch: Use eth_random_addr
>
> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> arch/c6x/kernel/soc.c | 2 +-
> arch/mips/ar7/platform.c | 4 ++--
> arch/mips/powertv/powertv_setup.c | 6 +++---
> arch/um/drivers/net_kern.c | 2 +-
> drivers/net/ethernet/atheros/atl1c/atl1c_hw.c | 2 +-
> drivers/net/ethernet/atheros/atlx/atl1.c | 2 +-
> drivers/net/ethernet/atheros/atlx/atl2.c | 2 +-
> drivers/net/ethernet/ethoc.c | 2 +-
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> drivers/net/ethernet/lantiq_etop.c | 2 +-
> drivers/net/ethernet/micrel/ks8851.c | 2 +-
> drivers/net/ethernet/micrel/ks8851_mll.c | 2 +-
> drivers/net/ethernet/smsc/smsc911x.c | 2 +-
> drivers/net/ethernet/ti/cpsw.c | 2 +-
> drivers/net/ethernet/tile/tilegx.c | 2 +-
> drivers/net/ethernet/wiznet/w5100.c | 2 +-
> drivers/net/ethernet/wiznet/w5300.c | 2 +-
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
> drivers/net/tun.c | 2 +-
> drivers/net/usb/smsc75xx.c | 2 +-
> drivers/net/usb/smsc95xx.c | 2 +-
> drivers/net/usb/usbnet.c | 2 +-
> drivers/net/wimax/i2400m/driver.c | 2 +-
> drivers/net/wireless/adm8211.c | 2 +-
> drivers/net/wireless/p54/eeprom.c | 2 +-
> drivers/net/wireless/rt2x00/rt2400pci.c | 2 +-
> drivers/net/wireless/rt2x00/rt2500pci.c | 2 +-
> drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> drivers/net/wireless/rt2x00/rt2800lib.c | 2 +-
> drivers/net/wireless/rt2x00/rt61pci.c | 2 +-
> drivers/net/wireless/rt2x00/rt73usb.c | 2 +-
> drivers/net/wireless/rtl818x/rtl8180/dev.c | 2 +-
> drivers/net/wireless/rtl818x/rtl8187/dev.c | 2 +-
> drivers/s390/net/qeth_l2_main.c | 2 +-
> drivers/s390/net/qeth_l3_main.c | 2 +-
> drivers/usb/atm/xusbatm.c | 4 ++--
> drivers/usb/gadget/u_ether.c | 2 +-
> include/linux/etherdevice.h | 14 ++++++++------
> 40 files changed, 52 insertions(+), 50 deletions(-)
>
> --
> 1.7.8.111.gad25c.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
2012-07-16 10:14 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
@ 2012-07-16 10:29 ` David Miller
2012-07-16 11:12 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: David Miller @ 2012-07-16 10:29 UTC (permalink / raw)
To: balbi
Cc: joe, netdev, linux-usb, wimax, linux-wireless, users, linux-s390,
johannes, uclinux-dist-devel, linux-kernel, linux-c6x-dev,
linux-mips, user-mode-linux-devel, user-mode-linux-user,
e1000-devel
From: Felipe Balbi <balbi@ti.com>
Date: Mon, 16 Jul 2012 13:14:38 +0300
> if you're really renaming the function, then this patch alone will break
> all of the below users. That should all be a single patch, I'm afraid.
It would help if you actually read his patches before saying what they
might or might not do.
He provides a macro in the first patch that provides the old name,
and this will get removed at the end.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
2012-07-16 10:29 ` David Miller
@ 2012-07-16 11:12 ` Felipe Balbi
2012-07-16 11:17 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2012-07-16 11:12 UTC (permalink / raw)
To: David Miller
Cc: balbi, joe, netdev, linux-usb, wimax, linux-wireless, users,
linux-s390, johannes, uclinux-dist-devel, linux-kernel,
linux-c6x-dev, linux-mips, user-mode-linux-devel,
user-mode-linux-user, e1000-devel
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
Hi,
On Mon, Jul 16, 2012 at 03:29:01AM -0700, David Miller wrote:
> From: Felipe Balbi <balbi@ti.com>
> Date: Mon, 16 Jul 2012 13:14:38 +0300
>
> > if you're really renaming the function, then this patch alone will break
> > all of the below users. That should all be a single patch, I'm afraid.
>
> It would help if you actually read his patches before saying what they
> might or might not do.
>
> He provides a macro in the first patch that provides the old name,
> and this will get removed at the end.
that's why I put an "if" there. The subject was misleading and I really
couldn't bother going search for the patch on the mail archives.
Anyway, if nothing will be broken then for drivers/usb/gadget/:
Acked-by: Felipe Balbi <balbi@ti.com>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
2012-07-16 11:12 ` Felipe Balbi
@ 2012-07-16 11:17 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2012-07-16 11:17 UTC (permalink / raw)
To: balbi
Cc: joe, netdev, linux-usb, wimax, linux-wireless, users, linux-s390,
johannes, uclinux-dist-devel, linux-kernel, linux-c6x-dev,
linux-mips, user-mode-linux-devel, user-mode-linux-user,
e1000-devel
From: Felipe Balbi <balbi@ti.com>
Date: Mon, 16 Jul 2012 14:12:19 +0300
> Acked-by: Felipe Balbi <balbi@ti.com>
You need to provide this in a reply to the patch you actually want
to ACK, so that the patch tracking system attaches your ACK to
the proper patch.
Thank you.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr
2012-07-13 5:33 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
2012-07-13 5:33 ` [PATCH net-next 6/8] s390: Use eth_random_addr Joe Perches
2012-07-16 10:14 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
@ 2012-07-17 5:39 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2012-07-17 5:39 UTC (permalink / raw)
To: joe
Cc: netdev, linux-usb, wimax, linux-wireless, users, linux-s390,
johannes, uclinux-dist-devel, linux-kernel, linux-c6x-dev,
linux-mips, user-mode-linux-devel, user-mode-linux-user,
e1000-devel
From: Joe Perches <joe@perches.com>
Date: Thu, 12 Jul 2012 22:33:04 -0700
> net-next commit ad7eee98be ("etherdevice: introduce eth_broadcast_addr")
> added a new style API. Rename random_ether_addr to eth_random_addr to
> create some API symmetry.
Series applied, thanks Joe.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-17 5:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1341968967.13724.23.camel@joe2Laptop>
2012-07-13 5:33 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Joe Perches
2012-07-13 5:33 ` [PATCH net-next 6/8] s390: Use eth_random_addr Joe Perches
2012-07-16 10:14 ` [PATCH net-next 0/8] etherdevice: Rename random_ether_addr to eth_random_addr Felipe Balbi
2012-07-16 10:29 ` David Miller
2012-07-16 11:12 ` Felipe Balbi
2012-07-16 11:17 ` David Miller
2012-07-17 5:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox