* [PATCH] KVM: s390: virtio-ccw bugfix.
@ 2013-04-04 8:25 Cornelia Huck
2013-04-04 8:25 ` [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O Cornelia Huck
2013-04-04 8:27 ` [PATCH] KVM: s390: virtio-ccw bugfix Gleb Natapov
0 siblings, 2 replies; 8+ messages in thread
From: Cornelia Huck @ 2013-04-04 8:25 UTC (permalink / raw)
To: Marcelo Tosatti, Gleb Natapov
Cc: Christian Borntraeger, Carsten Otte, Alexander Graf,
Heiko Carstens, Martin Schwidefsky, KVM, linux-s390
Hi,
another virtio-ccw bugfix for a problem where we would not reset
old I/O errors. Please apply.
Cornelia Huck (1):
KVM: s390: virtio_ccw: reset errors for new I/O.
drivers/s390/kvm/virtio_ccw.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
1.7.12.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O.
2013-04-04 8:25 [PATCH] KVM: s390: virtio-ccw bugfix Cornelia Huck
@ 2013-04-04 8:25 ` Cornelia Huck
2013-04-04 9:28 ` Alexander Graf
2013-04-04 8:27 ` [PATCH] KVM: s390: virtio-ccw bugfix Gleb Natapov
1 sibling, 1 reply; 8+ messages in thread
From: Cornelia Huck @ 2013-04-04 8:25 UTC (permalink / raw)
To: Marcelo Tosatti, Gleb Natapov
Cc: Christian Borntraeger, Carsten Otte, Alexander Graf,
Heiko Carstens, Martin Schwidefsky, KVM, linux-s390
ccw_io_helper neglected to reset vcdev->err after a new channel
program had been successfully started, resulting in stale errors
delivered after one I/O failed. Reset the error after a new
channel program has been successfully started with no old I/O
pending.
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
drivers/s390/kvm/virtio_ccw.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
index 42d507c..5948f2a 100644
--- a/drivers/s390/kvm/virtio_ccw.c
+++ b/drivers/s390/kvm/virtio_ccw.c
@@ -133,8 +133,11 @@ static int ccw_io_helper(struct virtio_ccw_device *vcdev,
do {
spin_lock_irqsave(get_ccwdev_lock(vcdev->cdev), flags);
ret = ccw_device_start(vcdev->cdev, ccw, intparm, 0, 0);
- if (!ret)
+ if (!ret) {
+ if (!vcdev->curr_io)
+ vcdev->err = 0;
vcdev->curr_io |= flag;
+ }
spin_unlock_irqrestore(get_ccwdev_lock(vcdev->cdev), flags);
cpu_relax();
} while (ret == -EBUSY);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio-ccw bugfix.
2013-04-04 8:25 [PATCH] KVM: s390: virtio-ccw bugfix Cornelia Huck
2013-04-04 8:25 ` [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O Cornelia Huck
@ 2013-04-04 8:27 ` Gleb Natapov
2013-04-04 8:35 ` Cornelia Huck
1 sibling, 1 reply; 8+ messages in thread
From: Gleb Natapov @ 2013-04-04 8:27 UTC (permalink / raw)
To: Cornelia Huck
Cc: Marcelo Tosatti, Christian Borntraeger, Carsten Otte,
Alexander Graf, Heiko Carstens, Martin Schwidefsky, KVM,
linux-s390
On Thu, Apr 04, 2013 at 10:25:05AM +0200, Cornelia Huck wrote:
> Hi,
>
> another virtio-ccw bugfix for a problem where we would not reset
> old I/O errors. Please apply.
>
> Cornelia Huck (1):
> KVM: s390: virtio_ccw: reset errors for new I/O.
>
> drivers/s390/kvm/virtio_ccw.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Is this for 3.9 or 3.10?
--
Gleb.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio-ccw bugfix.
2013-04-04 8:27 ` [PATCH] KVM: s390: virtio-ccw bugfix Gleb Natapov
@ 2013-04-04 8:35 ` Cornelia Huck
2013-04-04 9:00 ` Gleb Natapov
0 siblings, 1 reply; 8+ messages in thread
From: Cornelia Huck @ 2013-04-04 8:35 UTC (permalink / raw)
To: Gleb Natapov
Cc: Marcelo Tosatti, Christian Borntraeger, Carsten Otte,
Alexander Graf, Heiko Carstens, Martin Schwidefsky, KVM,
linux-s390
On Thu, 4 Apr 2013 11:27:39 +0300
Gleb Natapov <gleb@redhat.com> wrote:
> On Thu, Apr 04, 2013 at 10:25:05AM +0200, Cornelia Huck wrote:
> > Hi,
> >
> > another virtio-ccw bugfix for a problem where we would not reset
> > old I/O errors. Please apply.
> >
> > Cornelia Huck (1):
> > KVM: s390: virtio_ccw: reset errors for new I/O.
> >
> > drivers/s390/kvm/virtio_ccw.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> Is this for 3.9 or 3.10?
I created the patch on top of kvm/queue (the problem won't surface with
the current code, I only noticed it when I was mucking around with some
experimental stuff).
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio-ccw bugfix.
2013-04-04 8:35 ` Cornelia Huck
@ 2013-04-04 9:00 ` Gleb Natapov
0 siblings, 0 replies; 8+ messages in thread
From: Gleb Natapov @ 2013-04-04 9:00 UTC (permalink / raw)
To: Cornelia Huck
Cc: Marcelo Tosatti, Christian Borntraeger, Carsten Otte,
Alexander Graf, Heiko Carstens, Martin Schwidefsky, KVM,
linux-s390
On Thu, Apr 04, 2013 at 10:35:54AM +0200, Cornelia Huck wrote:
> On Thu, 4 Apr 2013 11:27:39 +0300
> Gleb Natapov <gleb@redhat.com> wrote:
>
> > On Thu, Apr 04, 2013 at 10:25:05AM +0200, Cornelia Huck wrote:
> > > Hi,
> > >
> > > another virtio-ccw bugfix for a problem where we would not reset
> > > old I/O errors. Please apply.
> > >
> > > Cornelia Huck (1):
> > > KVM: s390: virtio_ccw: reset errors for new I/O.
> > >
> > > drivers/s390/kvm/virtio_ccw.c | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > Is this for 3.9 or 3.10?
>
> I created the patch on top of kvm/queue (the problem won't surface with
> the current code, I only noticed it when I was mucking around with some
> experimental stuff).
Applied to queue. Thanks.
--
Gleb.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O.
2013-04-04 8:25 ` [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O Cornelia Huck
@ 2013-04-04 9:28 ` Alexander Graf
2013-04-04 10:20 ` Cornelia Huck
0 siblings, 1 reply; 8+ messages in thread
From: Alexander Graf @ 2013-04-04 9:28 UTC (permalink / raw)
To: Cornelia Huck
Cc: Marcelo Tosatti, Gleb Natapov, Christian Borntraeger,
Carsten Otte, Heiko Carstens, Martin Schwidefsky, KVM, linux-s390
On 04.04.2013, at 10:25, Cornelia Huck wrote:
> ccw_io_helper neglected to reset vcdev->err after a new channel
> program had been successfully started, resulting in stale errors
> delivered after one I/O failed. Reset the error after a new
> channel program has been successfully started with no old I/O
> pending.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Shouldn't this be CC: stable?
Alex
> ---
> drivers/s390/kvm/virtio_ccw.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> index 42d507c..5948f2a 100644
> --- a/drivers/s390/kvm/virtio_ccw.c
> +++ b/drivers/s390/kvm/virtio_ccw.c
> @@ -133,8 +133,11 @@ static int ccw_io_helper(struct virtio_ccw_device *vcdev,
> do {
> spin_lock_irqsave(get_ccwdev_lock(vcdev->cdev), flags);
> ret = ccw_device_start(vcdev->cdev, ccw, intparm, 0, 0);
> - if (!ret)
> + if (!ret) {
> + if (!vcdev->curr_io)
> + vcdev->err = 0;
> vcdev->curr_io |= flag;
> + }
> spin_unlock_irqrestore(get_ccwdev_lock(vcdev->cdev), flags);
> cpu_relax();
> } while (ret == -EBUSY);
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O.
2013-04-04 9:28 ` Alexander Graf
@ 2013-04-04 10:20 ` Cornelia Huck
2013-04-04 11:34 ` Alexander Graf
0 siblings, 1 reply; 8+ messages in thread
From: Cornelia Huck @ 2013-04-04 10:20 UTC (permalink / raw)
To: Alexander Graf
Cc: Marcelo Tosatti, Gleb Natapov, Christian Borntraeger,
Carsten Otte, Heiko Carstens, Martin Schwidefsky, KVM, linux-s390
On Thu, 4 Apr 2013 11:28:35 +0200
Alexander Graf <agraf@suse.de> wrote:
>
> On 04.04.2013, at 10:25, Cornelia Huck wrote:
>
> > ccw_io_helper neglected to reset vcdev->err after a new channel
> > program had been successfully started, resulting in stale errors
> > delivered after one I/O failed. Reset the error after a new
> > channel program has been successfully started with no old I/O
> > pending.
> >
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>
> Shouldn't this be CC: stable?
I don't think so, current code will not continue after errors anyway.
>
>
> Alex
>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> > index 42d507c..5948f2a 100644
> > --- a/drivers/s390/kvm/virtio_ccw.c
> > +++ b/drivers/s390/kvm/virtio_ccw.c
> > @@ -133,8 +133,11 @@ static int ccw_io_helper(struct virtio_ccw_device *vcdev,
> > do {
> > spin_lock_irqsave(get_ccwdev_lock(vcdev->cdev), flags);
> > ret = ccw_device_start(vcdev->cdev, ccw, intparm, 0, 0);
> > - if (!ret)
> > + if (!ret) {
> > + if (!vcdev->curr_io)
> > + vcdev->err = 0;
> > vcdev->curr_io |= flag;
> > + }
> > spin_unlock_irqrestore(get_ccwdev_lock(vcdev->cdev), flags);
> > cpu_relax();
> > } while (ret == -EBUSY);
> > --
> > 1.7.12.4
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O.
2013-04-04 10:20 ` Cornelia Huck
@ 2013-04-04 11:34 ` Alexander Graf
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Graf @ 2013-04-04 11:34 UTC (permalink / raw)
To: Cornelia Huck
Cc: Marcelo Tosatti, Gleb Natapov, Christian Borntraeger,
Carsten Otte, Heiko Carstens, Martin Schwidefsky, KVM, linux-s390
On 04.04.2013, at 12:20, Cornelia Huck wrote:
> On Thu, 4 Apr 2013 11:28:35 +0200
> Alexander Graf <agraf@suse.de> wrote:
>
>>
>> On 04.04.2013, at 10:25, Cornelia Huck wrote:
>>
>>> ccw_io_helper neglected to reset vcdev->err after a new channel
>>> program had been successfully started, resulting in stale errors
>>> delivered after one I/O failed. Reset the error after a new
>>> channel program has been successfully started with no old I/O
>>> pending.
>>>
>>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>
>> Shouldn't this be CC: stable?
>
> I don't think so, current code will not continue after errors anyway.
Yeah, I got confused by the cover letter for a single patch. Usually, when you only send a single patch, you wouldn't also send a cover letter :).
Alex
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-04-04 11:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-04 8:25 [PATCH] KVM: s390: virtio-ccw bugfix Cornelia Huck
2013-04-04 8:25 ` [PATCH] KVM: s390: virtio_ccw: reset errors for new I/O Cornelia Huck
2013-04-04 9:28 ` Alexander Graf
2013-04-04 10:20 ` Cornelia Huck
2013-04-04 11:34 ` Alexander Graf
2013-04-04 8:27 ` [PATCH] KVM: s390: virtio-ccw bugfix Gleb Natapov
2013-04-04 8:35 ` Cornelia Huck
2013-04-04 9:00 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox