From: David Hildenbrand <dahi@linux.vnet.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
cornelia.huck@de.ibm.com, rusty@au1.ibm.com, nab@linux-iscsi.org,
pbonzini@redhat.com, thuth@linux.vnet.ibm.com,
Rusty Russell <rusty@rustcorp.com.au>,
Ohad Ben-Cohen <ohad@wizery.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux390@de.ibm.com, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Sudeep Dutt <sudeep.dutt@intel.com>,
Siva Yerramreddy <yshivakrishna@gmail.com>,
lguest@lists.ozlabs.org, linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v6 05/46] virtio: assert 32 bit features in transports
Date: Fri, 28 Nov 2014 09:54:36 +0100 [thread overview]
Message-ID: <20141128095436.20c59e84@thinkpad-w530> (raw)
In-Reply-To: <1417118789-18231-6-git-send-email-mst@redhat.com>
> At this point, no transports set any of the high 32 feature bits.
> Since transports generally can't (yet) cope with such bits, add BUG_ON
> checks to make sure they are not set by mistake.
>
> Based on rproc patch by Rusty.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/lguest/lguest_device.c | 3 +++
> drivers/misc/mic/card/mic_virtio.c | 3 +++
> drivers/remoteproc/remoteproc_virtio.c | 3 +++
> drivers/s390/kvm/kvm_virtio.c | 3 +++
> drivers/s390/kvm/virtio_ccw.c | 3 +++
> drivers/virtio/virtio_mmio.c | 3 +++
> drivers/virtio/virtio_pci.c | 3 +++
> 7 files changed, 21 insertions(+)
>
Looks sane to me.
Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
next prev parent reply other threads:[~2014-11-28 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417118789-18231-1-git-send-email-mst@redhat.com>
2014-11-27 20:07 ` [PATCH v6 02/46] virtio: use u32, not bitmap for features Michael S. Tsirkin
2014-11-28 12:44 ` Cornelia Huck
2014-11-29 17:34 ` Michael S. Tsirkin
2014-11-27 20:07 ` [PATCH v6 04/46] virtio: add support for 64 bit features Michael S. Tsirkin
2014-11-28 8:52 ` David Hildenbrand
2014-11-28 12:47 ` Cornelia Huck
2014-11-27 20:08 ` [PATCH v6 05/46] virtio: assert 32 bit features in transports Michael S. Tsirkin
2014-11-28 8:54 ` David Hildenbrand [this message]
2014-11-28 12:50 ` Cornelia Huck
2014-11-27 20:08 ` [PATCH v6 06/46] virtio_ccw: add support for 64 bit features Michael S. Tsirkin
2014-11-28 12:56 ` Cornelia Huck
2014-11-27 20:09 ` [PATCH v6 17/46] KVM: s390: Set virtio-ccw transport revision Michael S. Tsirkin
2014-11-27 20:09 ` [PATCH v6 18/46] KVM: s390: virtio-ccw revision 1 SET_VQ Michael S. Tsirkin
2014-11-27 20:09 ` [PATCH v6 19/46] KVM: s390 allow virtio_ccw status writes to fail Michael S. Tsirkin
2014-11-27 20:09 ` [PATCH v6 20/46] KVM: s390: enable virtio-ccw revision 1 Michael S. Tsirkin
2014-11-28 10:09 ` Cornelia Huck
2014-11-29 17:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128095436.20c59e84@thinkpad-w530 \
--to=dahi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=lguest@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mst@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=ohad@wizery.com \
--cc=pbonzini@redhat.com \
--cc=rusty@au1.ibm.com \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
--cc=sudeep.dutt@intel.com \
--cc=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yshivakrishna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox