[PATCH v2 38/40] s390: macro whitespace fixes

[PATCH v2 38/40] s390: macro whitespace fixes

[Michael S. Tsirkin]

While working on arch/s390/include/asm/uaccess.h, I noticed
that a couple of macros within this header are made harder to read
because they violate a coding style rule: space is missing after comma.

Fix it up.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 arch/s390/include/asm/uaccess.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/include/asm/uaccess.h b/arch/s390/include/asm/uaccess.h
index cd4c68e..71b9c40 100644
--- a/arch/s390/include/asm/uaccess.h
+++ b/arch/s390/include/asm/uaccess.h
@@ -46,7 +46,7 @@
 	__ctl_load(__pto, 7, 7);					\
 })
 
-#define segment_eq(a,b) ((a).ar4 == (b).ar4)
+#define segment_eq(a, b) ((a).ar4 == (b).ar4)
 
 static inline int __range_ok(unsigned long addr, unsigned long size)
 {
@@ -147,7 +147,7 @@ unsigned long __must_check __copy_to_user(void __user *to, const void *from,
 		"3:	lhi	%0,%5\n"			\
 		"	jg	2b\n"				\
 		".popsection\n"					\
-		EX_TABLE(0b,3b) EX_TABLE(1b,3b)			\
+		EX_TABLE(0b, 3b) EX_TABLE(1b, 3b)		\
 		: "=d" (__rc), "=Q" (*(to))			\
 		: "d" (size), "Q" (*(from)),			\
 		  "d" (__reg0), "K" (-EFAULT)			\
-- 
MST

Re: [PATCH v2 38/40] s390: macro whitespace fixes

[Heiko Carstens]

On Tue, Jan 06, 2015 at 05:45:38PM +0200, Michael S. Tsirkin wrote:
> While working on arch/s390/include/asm/uaccess.h, I noticed
> that a couple of macros within this header are made harder to read
> because they violate a coding style rule: space is missing after comma.
> 
> Fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  arch/s390/include/asm/uaccess.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/include/asm/uaccess.h b/arch/s390/include/asm/uaccess.h
> index cd4c68e..71b9c40 100644
> --- a/arch/s390/include/asm/uaccess.h
> +++ b/arch/s390/include/asm/uaccess.h
> @@ -46,7 +46,7 @@
>  	__ctl_load(__pto, 7, 7);					\
>  })
> 
> -#define segment_eq(a,b) ((a).ar4 == (b).ar4)
> +#define segment_eq(a, b) ((a).ar4 == (b).ar4)
> 
>  static inline int __range_ok(unsigned long addr, unsigned long size)
>  {
> @@ -147,7 +147,7 @@ unsigned long __must_check __copy_to_user(void __user *to, const void *from,
>  		"3:	lhi	%0,%5\n"			\
>  		"	jg	2b\n"				\
>  		".popsection\n"					\
> -		EX_TABLE(0b,3b) EX_TABLE(1b,3b)			\
> +		EX_TABLE(0b, 3b) EX_TABLE(1b, 3b)		\

Most EX_TABLE() usages within s390 are without space after comma.
No need to change that. Also I don't like the change of the seqment_eq()
macro.
I won't apply trivial whitespace patches, since this would make 'git blame'
useless and in addition invite more people to send whitespace patches.

Thanks,
Heiko

Re: [PATCH v2 38/40] s390: macro whitespace fixes

[Michael S. Tsirkin]

On Wed, Jan 07, 2015 at 09:33:39AM +0100, Heiko Carstens wrote:
> On Tue, Jan 06, 2015 at 05:45:38PM +0200, Michael S. Tsirkin wrote:
> > While working on arch/s390/include/asm/uaccess.h, I noticed
> > that a couple of macros within this header are made harder to read
> > because they violate a coding style rule: space is missing after comma.
> > 
> > Fix it up.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  arch/s390/include/asm/uaccess.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/s390/include/asm/uaccess.h b/arch/s390/include/asm/uaccess.h
> > index cd4c68e..71b9c40 100644
> > --- a/arch/s390/include/asm/uaccess.h
> > +++ b/arch/s390/include/asm/uaccess.h
> > @@ -46,7 +46,7 @@
> >  	__ctl_load(__pto, 7, 7);					\
> >  })
> > 
> > -#define segment_eq(a,b) ((a).ar4 == (b).ar4)
> > +#define segment_eq(a, b) ((a).ar4 == (b).ar4)
> > 
> >  static inline int __range_ok(unsigned long addr, unsigned long size)
> >  {
> > @@ -147,7 +147,7 @@ unsigned long __must_check __copy_to_user(void __user *to, const void *from,
> >  		"3:	lhi	%0,%5\n"			\
> >  		"	jg	2b\n"				\
> >  		".popsection\n"					\
> > -		EX_TABLE(0b,3b) EX_TABLE(1b,3b)			\
> > +		EX_TABLE(0b, 3b) EX_TABLE(1b, 3b)		\
> 
> Most EX_TABLE() usages within s390 are without space after comma.
> No need to change that. Also I don't like the change of the seqment_eq()
> macro.
> I won't apply trivial whitespace patches, since this would make 'git blame'
> useless and in addition invite more people to send whitespace patches.
> 
> Thanks,
> Heiko

There's always git blame -w. Anyway, I'll drop s390 patches.
Fix it up yourself if you wish.

-- 
MST