* [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
@ 2015-09-16 13:13 Jason J. Herne
2015-09-16 14:34 ` Christian Borntraeger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jason J. Herne @ 2015-09-16 13:13 UTC (permalink / raw)
To: pbonzini
Cc: borntraeger, cornelia.huck, peterz, tglx, kvm, linux-s390,
linux-kernel, Jason J. Herne
The offending commit accidentally replaces an atomic_clear with an
atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
The symptom is that kvm guests on s390 hang on startup.
This patch simply replaces the incorrect atomic_or with atomic_andnot
Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
---
arch/s390/kvm/kvm-s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index c91eb94..49e76be 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1574,7 +1574,7 @@ static void kvm_s390_vcpu_request(struct kvm_vcpu *vcpu)
static void kvm_s390_vcpu_request_handled(struct kvm_vcpu *vcpu)
{
- atomic_or(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
+ atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
2015-09-16 13:13 [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) Jason J. Herne
@ 2015-09-16 14:34 ` Christian Borntraeger
2015-09-16 14:38 ` Paolo Bonzini
2015-09-16 14:40 ` Peter Zijlstra
2015-09-16 14:47 ` Cornelia Huck
2 siblings, 1 reply; 5+ messages in thread
From: Christian Borntraeger @ 2015-09-16 14:34 UTC (permalink / raw)
To: Jason J. Herne, pbonzini
Cc: cornelia.huck, peterz, tglx, kvm, linux-s390, linux-kernel
Am 16.09.2015 um 15:13 schrieb Jason J. Herne:
> The offending commit accidentally replaces an atomic_clear with an
> atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
> The symptom is that kvm guests on s390 hang on startup.
> This patch simply replaces the incorrect atomic_or with atomic_andnot
>
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Paolo,
can you take this via kvm tree for 4.3?
Maybe move the subject line into the mail body an rephrase the subject line.
Christian
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index c91eb94..49e76be 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1574,7 +1574,7 @@ static void kvm_s390_vcpu_request(struct kvm_vcpu *vcpu)
>
> static void kvm_s390_vcpu_request_handled(struct kvm_vcpu *vcpu)
> {
> - atomic_or(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
> + atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
2015-09-16 14:34 ` Christian Borntraeger
@ 2015-09-16 14:38 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-09-16 14:38 UTC (permalink / raw)
To: Christian Borntraeger, Jason J. Herne
Cc: cornelia.huck, peterz, tglx, kvm, linux-s390, linux-kernel
On 16/09/2015 16:34, Christian Borntraeger wrote:
> Am 16.09.2015 um 15:13 schrieb Jason J. Herne:
>> The offending commit accidentally replaces an atomic_clear with an
>> atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
>> The symptom is that kvm guests on s390 hang on startup.
>> This patch simply replaces the incorrect atomic_or with atomic_andnot
>>
>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Paolo,
> can you take this via kvm tree for 4.3?
>
> Maybe move the subject line into the mail body an rephrase the subject line.
Sure.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
2015-09-16 13:13 [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) Jason J. Herne
2015-09-16 14:34 ` Christian Borntraeger
@ 2015-09-16 14:40 ` Peter Zijlstra
2015-09-16 14:47 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Peter Zijlstra @ 2015-09-16 14:40 UTC (permalink / raw)
To: Jason J. Herne
Cc: pbonzini, borntraeger, cornelia.huck, tglx, kvm, linux-s390,
linux-kernel
On Wed, Sep 16, 2015 at 09:13:50AM -0400, Jason J. Herne wrote:
> The offending commit accidentally replaces an atomic_clear with an
> atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
> The symptom is that kvm guests on s390 hang on startup.
> This patch simply replaces the incorrect atomic_or with atomic_andnot
>
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
Urgh, sorry about that.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage)
2015-09-16 13:13 [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) Jason J. Herne
2015-09-16 14:34 ` Christian Borntraeger
2015-09-16 14:40 ` Peter Zijlstra
@ 2015-09-16 14:47 ` Cornelia Huck
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2015-09-16 14:47 UTC (permalink / raw)
To: Jason J. Herne
Cc: pbonzini, borntraeger, peterz, tglx, kvm, linux-s390,
linux-kernel
On Wed, 16 Sep 2015 09:13:50 -0400
"Jason J. Herne" <jjherne@linux.vnet.ibm.com> wrote:
> The offending commit accidentally replaces an atomic_clear with an
> atomic_or instead of an atomic_andnot in kvm_s390_vcpu_request_handled.
> The symptom is that kvm guests on s390 hang on startup.
> This patch simply replaces the incorrect atomic_or with atomic_andnot
>
> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index c91eb94..49e76be 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1574,7 +1574,7 @@ static void kvm_s390_vcpu_request(struct kvm_vcpu *vcpu)
>
> static void kvm_s390_vcpu_request_handled(struct kvm_vcpu *vcpu)
> {
> - atomic_or(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
> + atomic_andnot(PROG_REQUEST, &vcpu->arch.sie_block->prog20);
> }
>
> /*
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-16 14:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 13:13 [PATCH] Fixes: 805de8f43c20 (atomic: Replace atomic_{set,clear}_mask() usage) Jason J. Herne
2015-09-16 14:34 ` Christian Borntraeger
2015-09-16 14:38 ` Paolo Bonzini
2015-09-16 14:40 ` Peter Zijlstra
2015-09-16 14:47 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox