* [PATCH] s390/vmur: fix build warning
@ 2015-12-22 6:53 Sudip Mukherjee
2015-12-22 6:58 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-12-22 6:53 UTC (permalink / raw)
To: Martin Schwidefsky, Heiko Carstens
Cc: linux-kernel, linux-s390, Sudip Mukherjee, Al Viro
The helper no_seek_end_llseek() was added but now newpos is not required
and as a result we are getting build warning of unused variable.
Fixes: fb1d259e480c ("new helpers: no_seek_end_llseek{,_size}()")
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/s390/char/vmur.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c
index a532e54..6c30e93a 100644
--- a/drivers/s390/char/vmur.c
+++ b/drivers/s390/char/vmur.c
@@ -782,8 +782,6 @@ static int ur_release(struct inode *inode, struct file *file)
static loff_t ur_llseek(struct file *file, loff_t offset, int whence)
{
- loff_t newpos;
-
if ((file->f_flags & O_ACCMODE) != O_RDONLY)
return -ESPIPE; /* seek allowed only for reader */
if (offset % PAGE_SIZE)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/vmur: fix build warning
2015-12-22 6:53 [PATCH] s390/vmur: fix build warning Sudip Mukherjee
@ 2015-12-22 6:58 ` Al Viro
2015-12-22 7:15 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2015-12-22 6:58 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Martin Schwidefsky, Heiko Carstens, linux-kernel, linux-s390
On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote:
> The helper no_seek_end_llseek() was added but now newpos is not required
> and as a result we are getting build warning of unused variable.
Mind if I simply fold that into the commit in question?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/vmur: fix build warning
2015-12-22 6:58 ` Al Viro
@ 2015-12-22 7:15 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-12-22 7:15 UTC (permalink / raw)
To: Al Viro; +Cc: Martin Schwidefsky, Heiko Carstens, linux-kernel, linux-s390
On Tue, Dec 22, 2015 at 06:58:50AM +0000, Al Viro wrote:
> On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote:
> > The helper no_seek_end_llseek() was added but now newpos is not required
> > and as a result we are getting build warning of unused variable.
>
> Mind if I simply fold that into the commit in question?
No problem at all. Please fold them together.
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-22 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-22 6:53 [PATCH] s390/vmur: fix build warning Sudip Mukherjee
2015-12-22 6:58 ` Al Viro
2015-12-22 7:15 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox