* [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next
@ 2017-04-21 12:02 Christian Borntraeger
2017-04-21 12:06 ` Cornelia Huck
2017-04-24 16:22 ` Michael S. Tsirkin
0 siblings, 2 replies; 3+ messages in thread
From: Christian Borntraeger @ 2017-04-21 12:02 UTC (permalink / raw)
To: Michael S . Tsirkin
Cc: Cornelia Huck, Halil Pasic, linux-s390, kvm,
Christian Borntraeger
Michael,
commit db932ced55cf ("virtio: add context flag to find vqs") of
linux-next causes this build failure:
drivers/s390/virtio/kvm_virtio.c: In function ‘kvm_find_vq’:
drivers/s390/virtio/kvm_virtio.c:215:18: error: passing argument 8 of
‘vring_new_virtqueue’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
kvm_notify, callback, name);
^~~~~~~~
In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
./include/linux/virtio_ring.h:93:19: note: expected ‘bool (*)(struct
virtqueue *) {aka _Bool (*)(struct virtqueue *)}’ but argument is of
type ‘void (*)(struct virtqueue *)’
struct virtqueue *vring_new_virtqueue(unsigned int index,
^~~~~~~~~~~~~~~~~~~
drivers/s390/virtio/kvm_virtio.c:215:28: error: passing argument 9 of
‘vring_new_virtqueue’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
kvm_notify, callback, name);
^~~~
In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
./include/linux/virtio_ring.h:93:19: note: expected ‘void (*)(struct
virtqueue *)’ but argument is of type ‘const char *’
struct virtqueue *vring_new_virtqueue(unsigned int index,
^~~~~~~~~~~~~~~~~~~
drivers/s390/virtio/kvm_virtio.c:213:7: error: too few arguments to
function ‘vring_new_virtqueue’
vq = vring_new_virtqueue(index, config->num,
KVM_S390_VIRTIO_RING_ALIGN,
^~~~~~~~~~~~~~~~~~~
In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
./include/linux/virtio_ring.h:93:19: note: declared here
struct virtqueue *vring_new_virtqueue(unsigned int index,
^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Looks like the new ctx was not added here.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
drivers/s390/virtio/kvm_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/virtio/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c
index 81b33aa..a99d09a 100644
--- a/drivers/s390/virtio/kvm_virtio.c
+++ b/drivers/s390/virtio/kvm_virtio.c
@@ -211,7 +211,7 @@ static struct virtqueue *kvm_find_vq(struct virtio_device *vdev,
goto out;
vq = vring_new_virtqueue(index, config->num, KVM_S390_VIRTIO_RING_ALIGN,
- vdev, true, (void *) config->address,
+ vdev, true, ctx, (void *) config->address,
kvm_notify, callback, name);
if (!vq) {
err = -ENOMEM;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next
2017-04-21 12:02 [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next Christian Borntraeger
@ 2017-04-21 12:06 ` Cornelia Huck
2017-04-24 16:22 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2017-04-21 12:06 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Michael S . Tsirkin, Halil Pasic, linux-s390, kvm
On Fri, 21 Apr 2017 14:02:00 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Michael,
> commit db932ced55cf ("virtio: add context flag to find vqs") of
> linux-next causes this build failure:
>
> drivers/s390/virtio/kvm_virtio.c: In function ‘kvm_find_vq’:
> drivers/s390/virtio/kvm_virtio.c:215:18: error: passing argument 8 of
> ‘vring_new_virtqueue’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> kvm_notify, callback, name);
> ^~~~~~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: expected ‘bool (*)(struct
> virtqueue *) {aka _Bool (*)(struct virtqueue *)}’ but argument is of
> type ‘void (*)(struct virtqueue *)’
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> drivers/s390/virtio/kvm_virtio.c:215:28: error: passing argument 9 of
> ‘vring_new_virtqueue’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> kvm_notify, callback, name);
> ^~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: expected ‘void (*)(struct
> virtqueue *)’ but argument is of type ‘const char *’
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> drivers/s390/virtio/kvm_virtio.c:213:7: error: too few arguments to
> function ‘vring_new_virtqueue’
> vq = vring_new_virtqueue(index, config->num,
> KVM_S390_VIRTIO_RING_ALIGN,
> ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: declared here
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Looks like the new ctx was not added here.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> drivers/s390/virtio/kvm_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/virtio/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c
> index 81b33aa..a99d09a 100644
> --- a/drivers/s390/virtio/kvm_virtio.c
> +++ b/drivers/s390/virtio/kvm_virtio.c
> @@ -211,7 +211,7 @@ static struct virtqueue *kvm_find_vq(struct virtio_device *vdev,
> goto out;
>
> vq = vring_new_virtqueue(index, config->num, KVM_S390_VIRTIO_RING_ALIGN,
> - vdev, true, (void *) config->address,
> + vdev, true, ctx, (void *) config->address,
> kvm_notify, callback, name);
> if (!vq) {
> err = -ENOMEM;
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Wasn't there supposed to be a new version of that series anyway?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next
2017-04-21 12:02 [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next Christian Borntraeger
2017-04-21 12:06 ` Cornelia Huck
@ 2017-04-24 16:22 ` Michael S. Tsirkin
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2017-04-24 16:22 UTC (permalink / raw)
To: Christian Borntraeger; +Cc: Cornelia Huck, Halil Pasic, linux-s390, kvm
On Fri, Apr 21, 2017 at 02:02:00PM +0200, Christian Borntraeger wrote:
> Michael,
> commit db932ced55cf ("virtio: add context flag to find vqs") of
> linux-next causes this build failure:
>
> drivers/s390/virtio/kvm_virtio.c: In function ‘kvm_find_vq’:
> drivers/s390/virtio/kvm_virtio.c:215:18: error: passing argument 8 of
> ‘vring_new_virtqueue’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> kvm_notify, callback, name);
> ^~~~~~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: expected ‘bool (*)(struct
> virtqueue *) {aka _Bool (*)(struct virtqueue *)}’ but argument is of
> type ‘void (*)(struct virtqueue *)’
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> drivers/s390/virtio/kvm_virtio.c:215:28: error: passing argument 9 of
> ‘vring_new_virtqueue’ from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> kvm_notify, callback, name);
> ^~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: expected ‘void (*)(struct
> virtqueue *)’ but argument is of type ‘const char *’
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> drivers/s390/virtio/kvm_virtio.c:213:7: error: too few arguments to
> function ‘vring_new_virtqueue’
> vq = vring_new_virtqueue(index, config->num,
> KVM_S390_VIRTIO_RING_ALIGN,
> ^~~~~~~~~~~~~~~~~~~
> In file included from drivers/s390/virtio/kvm_virtio.c:22:0:
> ./include/linux/virtio_ring.h:93:19: note: declared here
> struct virtqueue *vring_new_virtqueue(unsigned int index,
> ^~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Looks like the new ctx was not added here.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
I squashed this into my commit to avoid bisect issues.
Thanks!
> ---
> drivers/s390/virtio/kvm_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/virtio/kvm_virtio.c b/drivers/s390/virtio/kvm_virtio.c
> index 81b33aa..a99d09a 100644
> --- a/drivers/s390/virtio/kvm_virtio.c
> +++ b/drivers/s390/virtio/kvm_virtio.c
> @@ -211,7 +211,7 @@ static struct virtqueue *kvm_find_vq(struct virtio_device *vdev,
> goto out;
>
> vq = vring_new_virtqueue(index, config->num, KVM_S390_VIRTIO_RING_ALIGN,
> - vdev, true, (void *) config->address,
> + vdev, true, ctx, (void *) config->address,
> kvm_notify, callback, name);
> if (!vq) {
> err = -ENOMEM;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-24 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-21 12:02 [PATCH] s390/virtio: fix compilation of kvm_virtio.c in linux-next Christian Borntraeger
2017-04-21 12:06 ` Cornelia Huck
2017-04-24 16:22 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox