From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: linux-4.11/arch/s390/kernel/time.c:417: bad function call ?
Date: Tue, 02 May 2017 08:32:17 +0000 [thread overview]
Message-ID: <20170502103217.38cede5c@mschwideX1> (raw)
On Tue, 2 May 2017 07:59:45 +0000
David Binderman <dcb314@hotmail.com> wrote:
> linux-4.11/arch/s390/kernel/time.c:417]: (error) Shifting 32-bit value by 48 bits is undefined behaviour
>
>
> Source code is
>
> if ((abs(tod_steering_delta) >> 48) != 0)
>
> But the type of tod_steering_delta is long long. Suggest replace abs with llabs.
I wonder how you managed to get this error message. The abs definition
in include/linux/kernel.h takes care of the type, it can be used with
basically anything. And llabs does not exist for a kernel compile.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
reply other threads:[~2017-05-02 8:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502103217.38cede5c@mschwideX1 \
--to=schwidefsky@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox