* Re: linux-4.11/arch/s390/kernel/time.c:417: bad function call ?
@ 2017-05-02 8:32 Martin Schwidefsky
0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2017-05-02 8:32 UTC (permalink / raw)
To: linux-s390
On Tue, 2 May 2017 07:59:45 +0000
David Binderman <dcb314@hotmail.com> wrote:
> linux-4.11/arch/s390/kernel/time.c:417]: (error) Shifting 32-bit value by 48 bits is undefined behaviour
>
>
> Source code is
>
> if ((abs(tod_steering_delta) >> 48) != 0)
>
> But the type of tod_steering_delta is long long. Suggest replace abs with llabs.
I wonder how you managed to get this error message. The abs definition
in include/linux/kernel.h takes care of the type, it can be used with
basically anything. And llabs does not exist for a kernel compile.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-05-02 8:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-02 8:32 linux-4.11/arch/s390/kernel/time.c:417: bad function call ? Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox