[PATCH 06/11] s390/topology: Remove the unused parent_node() macro

[PATCH 06/11] s390/topology: Remove the unused parent_node() macro

[Dou Liyang]

Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().

The parent_node() macro in S390 platform is unnecessary.

Remove it for cleanup.

Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: linux-s390@vger.kernel.org
---
 arch/s390/include/asm/topology.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/s390/include/asm/topology.h b/arch/s390/include/asm/topology.h
index fa1bfce..5222da1 100644
--- a/arch/s390/include/asm/topology.h
+++ b/arch/s390/include/asm/topology.h
@@ -77,12 +77,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
 	return &node_to_cpumask_map[node];
 }
 
-/*
- * Returns the number of the node containing node 'node'. This
- * architecture is flat, so it is a pretty simple function!
- */
-#define parent_node(node) (node)
-
 #define pcibus_to_node(bus) __pcibus_to_node(bus)
 
 #define node_distance(a, b) __node_distance(a, b)
-- 
2.5.5

Re: [PATCH 06/11] s390/topology: Remove the unused parent_node() macro

[Heiko Carstens]

On Wed, Jul 26, 2017 at 09:34:31PM +0800, Dou Liyang wrote:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
> 
> The parent_node() macro in S390 platform is unnecessary.
> 
> Remove it for cleanup.
> 
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---

Are arch maintainers supposed to pick these patches up?

In any case: Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Re: [PATCH 06/11] s390/topology: Remove the unused parent_node() macro

[Dou Liyang]

Hi Heiko,

At 07/27/2017 04:19 PM, Heiko Carstens wrote:
> On Wed, Jul 26, 2017 at 09:34:31PM +0800, Dou Liyang wrote:
>> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
>> __register_one_node()") removes the last user of parent_node().
>>
>> The parent_node() macro in S390 platform is unnecessary.
>>
>> Remove it for cleanup.
>>
>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
>> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
>> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
>> Cc: linux-s390@vger.kernel.org
>> ---
>
> Are arch maintainers supposed to pick these patches up?
>

Yes, As Michael said, It seems these patches are merging individually.

can you merge this patch in s390 tree?

> In any case: Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>
>
Thanks,
	dou.