public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 4/5] zipl: Move macro definition to Makefile
@ 2018-08-07 13:33 Philipp Rudo
  0 siblings, 0 replies; only message in thread
From: Philipp Rudo @ 2018-08-07 13:33 UTC (permalink / raw)
  To: linux-s390

In the zipl Makefile macros are defined with the sole purpose to define
other macros in zipl.h. Remove this unnecessary indirection.

Signed-off-by: Philipp Rudo <prudo@linux.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
---
 zipl/include/zipl.h | 5 -----
 zipl/src/Makefile   | 5 ++---
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/zipl/include/zipl.h b/zipl/include/zipl.h
index fb68ae88..770801e5 100644
--- a/zipl/include/zipl.h
+++ b/zipl/include/zipl.h
@@ -48,11 +48,6 @@
 #define MENU_DEFAULT_PROMPT		0
 #define MENU_DEFAULT_TIMEOUT		0
 
-#define ZFCPDUMP_IMAGE		STRINGIFY(ZFCPDUMP_DIR) "/" \
-					STRINGIFY(ZFCPDUMP_PART_IMAGE)
-#define ZFCPDUMP_INITRD		STRINGIFY(ZFCPDUMP_DIR) "/" \
-					STRINGIFY(ZFCPDUMP_PART_RD)
-
 #define MAX_DUMP_VOLUMES		32
 
 /* Internal component load address type */
diff --git a/zipl/src/Makefile b/zipl/src/Makefile
index b9018b4b..be14fce5 100644
--- a/zipl/src/Makefile
+++ b/zipl/src/Makefile
@@ -2,9 +2,8 @@
 include ../../common.mak
 
 ALL_CPPFLAGS += -I../include -I../boot \
-	    -DZFCPDUMP_DIR=$(ZFCPDUMP_DIR) \
-	    -DZFCPDUMP_PART_IMAGE=$(ZFCPDUMP_IMAGE) \
-	    -DZFCPDUMP_PART_RD=$(ZFCPDUMP_INITRD) \
+	    -DZFCPDUMP_IMAGE="STRINGIFY($(ZFCPDUMP_DIR)/$(ZFCPDUMP_IMAGE))" \
+	    -DZFCPDUMP_INITRD="STRINGIFY($(ZFCPDUMP_DIR)/$(ZFCPDUMP_INITRD))" \
 	    -D_FILE_OFFSET_BITS=64 $(NO_PIE_CFLAGS)
 ALL_LDFLAGS += -Wl,-z,noexecstack $(NO_PIE_LDFLAGS)
 
-- 
2.16.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-08-07 13:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 13:33 [PATCH v2 4/5] zipl: Move macro definition to Makefile Philipp Rudo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox