public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] s390/config: Enable CONFIG_PRINTK_TIME in defconfig
@ 2018-10-28 11:23 Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2018-10-28 11:23 UTC (permalink / raw)
  To: linux-s390

s390 defconfig uses the same value default value for CONFIG_LOG_BUF_SHIFT
(currently 17), which is the same as other s390 configs, which enable
CONFIG_PRINTK_TIME. There is no need to have it disabled for defconfig.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 arch/s390/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/s390/defconfig b/arch/s390/defconfig
index 7cb6a52f727d..646244a6885d 100644
--- a/arch/s390/defconfig
+++ b/arch/s390/defconfig
@@ -248,3 +248,4 @@ CONFIG_CRC7=m
 # CONFIG_XZ_DEC_ARMTHUMB is not set
 # CONFIG_XZ_DEC_SPARC is not set
 CONFIG_CMM=m
+CONFIG_PRINTK_TIME=y
-- 
2.12.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] s390/config: Enable CONFIG_PRINTK_TIME in defconfig
       [not found] <20181101100509.GB5757@osiris>
@ 2018-11-01 10:23 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2018-11-01 10:23 UTC (permalink / raw)
  To: linux-s390

Hi Heiko,

> What does this fix for you? Not having timestamps on the console makes
> life easier for developers, since this wouldn't waste so much line
> space on e.g. a 3215 console.
> While the other configs within the configs directory are supposed to
> be more distro-like.

> So, I'm not willing to apply this one, since it makes my life not
> easier ;)

Thanks for review. I consider timestamps useful even on console.
But sorry, I considered only x3270 and thought that reason, why
it's off is due ring buffer size.


Kind regards,
Petr

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-01 10:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20181101100509.GB5757@osiris>
2018-11-01 10:23 ` [PATCH 1/1] s390/config: Enable CONFIG_PRINTK_TIME in defconfig Petr Vorel
2018-10-28 11:23 Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox