* [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
@ 2018-11-16 10:47 Petr Tesarik
2018-11-16 10:58 ` Cornelia Huck
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Petr Tesarik @ 2018-11-16 10:47 UTC (permalink / raw)
To: Tony Krowiak, Pierre Morel, Halil Pasic, Harald Freudenberger,
Martin Schwidefsky, Heiko Carstens, linux-s390
Cc: linux-kernel
The driver uses test_facility(), but does not include the
corresponding include file explicitly. The driver currently builds
only thanks to the following include chain:
vfio_ap_drv.c
<linux/module.h>
<linux/elf.h>
<asm/elf.h>
<linux/compat.h>
<asm/uaccess.h>
<asm/facility.h>
Files should not rely on such fragile implicit includes.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
drivers/s390/crypto/vfio_ap_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 7667b38728f0..31c6c847eaca 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -11,6 +11,7 @@
#include <linux/mod_devicetable.h>
#include <linux/slab.h>
#include <linux/string.h>
+#include <asm/facility.h>
#include "vfio_ap_private.h"
#define VFIO_AP_ROOT_NAME "vfio_ap"
--
2.16.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
2018-11-16 10:47 [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility() Petr Tesarik
@ 2018-11-16 10:58 ` Cornelia Huck
2018-11-16 11:48 ` Christian Borntraeger
2018-11-16 12:20 ` Halil Pasic
2 siblings, 0 replies; 5+ messages in thread
From: Cornelia Huck @ 2018-11-16 10:58 UTC (permalink / raw)
To: Petr Tesarik
Cc: Tony Krowiak, Pierre Morel, Halil Pasic, Harald Freudenberger,
Martin Schwidefsky, Heiko Carstens, linux-s390, linux-kernel
On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik <ptesarik@suse.com> wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
2018-11-16 10:47 [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility() Petr Tesarik
2018-11-16 10:58 ` Cornelia Huck
@ 2018-11-16 11:48 ` Christian Borntraeger
2018-11-16 12:20 ` Halil Pasic
2 siblings, 0 replies; 5+ messages in thread
From: Christian Borntraeger @ 2018-11-16 11:48 UTC (permalink / raw)
To: Petr Tesarik, Tony Krowiak, Pierre Morel, Halil Pasic,
Harald Freudenberger, Martin Schwidefsky, Heiko Carstens,
linux-s390
Cc: linux-kernel
On 11/16/2018 11:47 AM, Petr Tesarik wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
2018-11-16 10:47 [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility() Petr Tesarik
2018-11-16 10:58 ` Cornelia Huck
2018-11-16 11:48 ` Christian Borntraeger
@ 2018-11-16 12:20 ` Halil Pasic
2018-11-16 12:28 ` Petr Tesarik
2 siblings, 1 reply; 5+ messages in thread
From: Halil Pasic @ 2018-11-16 12:20 UTC (permalink / raw)
To: Petr Tesarik
Cc: Tony Krowiak, Pierre Morel, Harald Freudenberger,
Martin Schwidefsky, Heiko Carstens, linux-s390, linux-kernel,
Christian Borntraeger
On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik <ptesarik@suse.com> wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> b/drivers/s390/crypto/vfio_ap_drv.c index 7667b38728f0..31c6c847eaca
> 100644 --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
Applied. Is going to go via Martins S390 tree.
Thanks,
Halil
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()
2018-11-16 12:20 ` Halil Pasic
@ 2018-11-16 12:28 ` Petr Tesarik
0 siblings, 0 replies; 5+ messages in thread
From: Petr Tesarik @ 2018-11-16 12:28 UTC (permalink / raw)
To: Halil Pasic
Cc: Tony Krowiak, Pierre Morel, Harald Freudenberger,
Martin Schwidefsky, Heiko Carstens, linux-s390, linux-kernel,
Christian Borntraeger
On Fri, 16 Nov 2018 13:20:33 +0100
Halil Pasic <pasic@linux.ibm.com> wrote:
> On Fri, 16 Nov 2018 11:47:48 +0100
> Petr Tesarik <ptesarik@suse.com> wrote:
>
> > The driver uses test_facility(), but does not include the
> > corresponding include file explicitly. The driver currently builds
> > only thanks to the following include chain:
> >
> > vfio_ap_drv.c
> > <linux/module.h>
> > <linux/elf.h>
> > <asm/elf.h>
> > <linux/compat.h>
> > <asm/uaccess.h>
> > <asm/facility.h>
> >
> > Files should not rely on such fragile implicit includes.
> >
> > Signed-off-by: Petr Tesarik <ptesarik@suse.com>
> > ---
> > drivers/s390/crypto/vfio_ap_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> > b/drivers/s390/crypto/vfio_ap_drv.c index 7667b38728f0..31c6c847eaca
> > 100644 --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -11,6 +11,7 @@
> > #include <linux/mod_devicetable.h>
> > #include <linux/slab.h>
> > #include <linux/string.h>
> > +#include <asm/facility.h>
> > #include "vfio_ap_private.h"
> >
> > #define VFIO_AP_ROOT_NAME "vfio_ap"
>
> Applied. Is going to go via Martins S390 tree.
Thank you for the quick turnaround.
Petr Tesarik
SUSE HW Enablement Team
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-16 12:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-16 10:47 [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility() Petr Tesarik
2018-11-16 10:58 ` Cornelia Huck
2018-11-16 11:48 ` Christian Borntraeger
2018-11-16 12:20 ` Halil Pasic
2018-11-16 12:28 ` Petr Tesarik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox