* [PATCH v3 18/34] s390: mm: Add p?d_large() definitions
[not found] <20190227170608.27963-1-steven.price@arm.com>
@ 2019-02-27 17:05 ` Steven Price
2019-02-27 17:40 ` Martin Schwidefsky
0 siblings, 1 reply; 3+ messages in thread
From: Steven Price @ 2019-02-27 17:05 UTC (permalink / raw)
To: linux-mm
Cc: Mark Rutland, Peter Zijlstra, Catalin Marinas, Dave Hansen,
Will Deacon, H. Peter Anvin, Liang, Kan, linux-s390, x86,
Steven Price, Ingo Molnar, Arnd Bergmann, Heiko Carstens,
Jérôme Glisse, Borislav Petkov, Andy Lutomirski,
Thomas Gleixner, linux-arm-kernel, Ard Biesheuvel, linux-kernel,
James Morse, Martin Schwidefsky
walk_page_range() is going to be allowed to walk page tables other than
those of user space. For this it needs to know when it has reached a
'leaf' entry in the page tables. This information is provided by the
p?d_large() functions/macros.
For s390, we don't support large pages, so add a stub returning 0.
CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
CC: Heiko Carstens <heiko.carstens@de.ibm.com>
CC: linux-s390@vger.kernel.org
Signed-off-by: Steven Price <steven.price@arm.com>
---
arch/s390/include/asm/pgtable.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
index 063732414dfb..9617f1fb69b4 100644
--- a/arch/s390/include/asm/pgtable.h
+++ b/arch/s390/include/asm/pgtable.h
@@ -605,6 +605,11 @@ static inline int pgd_present(pgd_t pgd)
return (pgd_val(pgd) & _REGION_ENTRY_ORIGIN) != 0UL;
}
+static inline int pgd_large(pgd_t pgd)
+{
+ return 0;
+}
+
static inline int pgd_none(pgd_t pgd)
{
if (pgd_folded(pgd))
@@ -645,6 +650,11 @@ static inline int p4d_present(p4d_t p4d)
return (p4d_val(p4d) & _REGION_ENTRY_ORIGIN) != 0UL;
}
+static inline int p4d_large(p4d_t p4d)
+{
+ return 0;
+}
+
static inline int p4d_none(p4d_t p4d)
{
if (p4d_folded(p4d))
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 18/34] s390: mm: Add p?d_large() definitions
2019-02-27 17:05 ` [PATCH v3 18/34] s390: mm: Add p?d_large() definitions Steven Price
@ 2019-02-27 17:40 ` Martin Schwidefsky
2019-02-28 11:43 ` Steven Price
0 siblings, 1 reply; 3+ messages in thread
From: Martin Schwidefsky @ 2019-02-27 17:40 UTC (permalink / raw)
To: Steven Price
Cc: Mark Rutland, linux-s390, x86, Arnd Bergmann, Ard Biesheuvel,
Peter Zijlstra, Catalin Marinas, Dave Hansen, Will Deacon,
linux-kernel, Heiko Carstens, linux-mm, Jérôme Glisse,
Ingo Molnar, Borislav Petkov, Andy Lutomirski, H. Peter Anvin,
James Morse, Thomas Gleixner, linux-arm-kernel, Liang, Kan
On Wed, 27 Feb 2019 17:05:52 +0000
Steven Price <steven.price@arm.com> wrote:
> walk_page_range() is going to be allowed to walk page tables other than
> those of user space. For this it needs to know when it has reached a
> 'leaf' entry in the page tables. This information is provided by the
> p?d_large() functions/macros.
>
> For s390, we don't support large pages, so add a stub returning 0.
Well s390 does support 1MB and 2GB large pages, pmd_large() and pud_large()
are non-empty. We do not support 4TB or 8PB large pages though, which
makes the patch itself correct. Just the wording is slightly off.
> CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
> CC: Heiko Carstens <heiko.carstens@de.ibm.com>
> CC: linux-s390@vger.kernel.org
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> arch/s390/include/asm/pgtable.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
> index 063732414dfb..9617f1fb69b4 100644
> --- a/arch/s390/include/asm/pgtable.h
> +++ b/arch/s390/include/asm/pgtable.h
> @@ -605,6 +605,11 @@ static inline int pgd_present(pgd_t pgd)
> return (pgd_val(pgd) & _REGION_ENTRY_ORIGIN) != 0UL;
> }
>
> +static inline int pgd_large(pgd_t pgd)
> +{
> + return 0;
> +}
> +
> static inline int pgd_none(pgd_t pgd)
> {
> if (pgd_folded(pgd))
> @@ -645,6 +650,11 @@ static inline int p4d_present(p4d_t p4d)
> return (p4d_val(p4d) & _REGION_ENTRY_ORIGIN) != 0UL;
> }
>
> +static inline int p4d_large(p4d_t p4d)
> +{
> + return 0;
> +}
> +
> static inline int p4d_none(p4d_t p4d)
> {
> if (p4d_folded(p4d))
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 18/34] s390: mm: Add p?d_large() definitions
2019-02-27 17:40 ` Martin Schwidefsky
@ 2019-02-28 11:43 ` Steven Price
0 siblings, 0 replies; 3+ messages in thread
From: Steven Price @ 2019-02-28 11:43 UTC (permalink / raw)
To: Martin Schwidefsky
Cc: Mark Rutland, linux-s390, Dave Hansen, Arnd Bergmann,
Ard Biesheuvel, Peter Zijlstra, Catalin Marinas, x86, Will Deacon,
linux-kernel, Heiko Carstens, linux-mm, Jérôme Glisse,
Ingo Molnar, Borislav Petkov, Andy Lutomirski, H. Peter Anvin,
James Morse, Thomas Gleixner, linux-arm-kernel, Liang, Kan
On 27/02/2019 17:40, Martin Schwidefsky wrote:
> On Wed, 27 Feb 2019 17:05:52 +0000
> Steven Price <steven.price@arm.com> wrote:
>
>> walk_page_range() is going to be allowed to walk page tables other than
>> those of user space. For this it needs to know when it has reached a
>> 'leaf' entry in the page tables. This information is provided by the
>> p?d_large() functions/macros.
>>
>> For s390, we don't support large pages, so add a stub returning 0.
>
> Well s390 does support 1MB and 2GB large pages, pmd_large() and pud_large()
> are non-empty. We do not support 4TB or 8PB large pages though, which
> makes the patch itself correct. Just the wording is slightly off.
Sorry, you're absolutely right - I'll update the commit message for the
next posting.
Thanks,
Steve
>> CC: Martin Schwidefsky <schwidefsky@de.ibm.com>
>> CC: Heiko Carstens <heiko.carstens@de.ibm.com>
>> CC: linux-s390@vger.kernel.org
>> Signed-off-by: Steven Price <steven.price@arm.com>
>> ---
>> arch/s390/include/asm/pgtable.h | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h
>> index 063732414dfb..9617f1fb69b4 100644
>> --- a/arch/s390/include/asm/pgtable.h
>> +++ b/arch/s390/include/asm/pgtable.h
>> @@ -605,6 +605,11 @@ static inline int pgd_present(pgd_t pgd)
>> return (pgd_val(pgd) & _REGION_ENTRY_ORIGIN) != 0UL;
>> }
>>
>> +static inline int pgd_large(pgd_t pgd)
>> +{
>> + return 0;
>> +}
>> +
>> static inline int pgd_none(pgd_t pgd)
>> {
>> if (pgd_folded(pgd))
>> @@ -645,6 +650,11 @@ static inline int p4d_present(p4d_t p4d)
>> return (p4d_val(p4d) & _REGION_ENTRY_ORIGIN) != 0UL;
>> }
>>
>> +static inline int p4d_large(p4d_t p4d)
>> +{
>> + return 0;
>> +}
>> +
>> static inline int p4d_none(p4d_t p4d)
>> {
>> if (p4d_folded(p4d))
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-28 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190227170608.27963-1-steven.price@arm.com>
2019-02-27 17:05 ` [PATCH v3 18/34] s390: mm: Add p?d_large() definitions Steven Price
2019-02-27 17:40 ` Martin Schwidefsky
2019-02-28 11:43 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox