* [PATCH V3 09/15] s390: zfcp_fc: use sg helper to operate scatterlist [not found] <20190614025316.7360-1-ming.lei@redhat.com> @ 2019-06-14 2:53 ` Ming Lei 2019-06-16 16:25 ` Benjamin Block 0 siblings, 1 reply; 2+ messages in thread From: Ming Lei @ 2019-06-14 2:53 UTC (permalink / raw) To: linux-scsi, Martin K . Petersen Cc: James Bottomley, Bart Van Assche, Hannes Reinecke, Christoph Hellwig, Jim Gill, Cathy Avery, Ewan D . Milne, Brian King, James Smart, Juergen E . Fischer, Michael Schmitz, Finn Thain, Greg Kroah-Hartman, devel, linux-usb, Dan Carpenter, Benjamin Block, Ming Lei, Steffen Maier, Martin Schwidefsky, Heiko Carstens, linux-s390 Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Cc: Steffen Maier <maier@linux.ibm.com> Cc: Benjamin Block <bblock@linux.ibm.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: linux-s390@vger.kernel.org Signed-off-by: Ming Lei <ming.lei@redhat.com> --- drivers/s390/scsi/zfcp_fc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c index 33eddb02ee30..b018b61bd168 100644 --- a/drivers/s390/scsi/zfcp_fc.c +++ b/drivers/s390/scsi/zfcp_fc.c @@ -620,7 +620,7 @@ static void zfcp_fc_sg_free_table(struct scatterlist *sg, int count) { int i; - for (i = 0; i < count; i++, sg++) + for (i = 0; i < count; i++, sg = sg_next(sg)) if (sg) free_page((unsigned long) sg_virt(sg)); else @@ -641,7 +641,7 @@ static int zfcp_fc_sg_setup_table(struct scatterlist *sg, int count) int i; sg_init_table(sg, count); - for (i = 0; i < count; i++, sg++) { + for (i = 0; i < count; i++, sg = sg_next(sg)) { addr = (void *) get_zeroed_page(GFP_KERNEL); if (!addr) { zfcp_fc_sg_free_table(sg, i); -- 2.20.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3 09/15] s390: zfcp_fc: use sg helper to operate scatterlist 2019-06-14 2:53 ` [PATCH V3 09/15] s390: zfcp_fc: use sg helper to operate scatterlist Ming Lei @ 2019-06-16 16:25 ` Benjamin Block 0 siblings, 0 replies; 2+ messages in thread From: Benjamin Block @ 2019-06-16 16:25 UTC (permalink / raw) To: Ming Lei Cc: linux-scsi, Martin K . Petersen, James Bottomley, Bart Van Assche, Hannes Reinecke, Christoph Hellwig, Jim Gill, Cathy Avery, Ewan D . Milne, Brian King, James Smart, Juergen E . Fischer, Michael Schmitz, Finn Thain, Greg Kroah-Hartman, devel, linux-usb, Dan Carpenter, Steffen Maier, Martin Schwidefsky, Heiko Carstens, linux-s390 On Fri, Jun 14, 2019 at 10:53:10AM +0800, Ming Lei wrote: > Use the scatterlist iterators and remove direct indexing of the > scatterlist array. > > This way allows us to pre-allocate one small scatterlist, which can be > chained with one runtime allocated scatterlist if the pre-allocated one > isn't enough for the whole request. > > Cc: Steffen Maier <maier@linux.ibm.com> > Cc: Benjamin Block <bblock@linux.ibm.com> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Cc: linux-s390@vger.kernel.org > Signed-off-by: Ming Lei <ming.lei@redhat.com> > --- > drivers/s390/scsi/zfcp_fc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c > index 33eddb02ee30..b018b61bd168 100644 > --- a/drivers/s390/scsi/zfcp_fc.c > +++ b/drivers/s390/scsi/zfcp_fc.c > @@ -620,7 +620,7 @@ static void zfcp_fc_sg_free_table(struct scatterlist *sg, int count) > { > int i; > > - for (i = 0; i < count; i++, sg++) > + for (i = 0; i < count; i++, sg = sg_next(sg)) > if (sg) > free_page((unsigned long) sg_virt(sg)); > else > @@ -641,7 +641,7 @@ static int zfcp_fc_sg_setup_table(struct scatterlist *sg, int count) > int i; > > sg_init_table(sg, count); > - for (i = 0; i < count; i++, sg++) { > + for (i = 0; i < count; i++, sg = sg_next(sg)) { > addr = (void *) get_zeroed_page(GFP_KERNEL); > if (!addr) { > zfcp_fc_sg_free_table(sg, i); Acked-by: Benjamin Block <bblock@linux.ibm.com> -- With Best Regards, Benjamin Block / Linux on IBM Z Kernel Development IBM Systems & Technology Group / IBM Deutschland Research & Development GmbH Vorsitz. AufsR.: Matthias Hartmann / Gesch�ftsf�hrung: Dirk Wittkopp Sitz der Gesellschaft: B�blingen / Registergericht: AmtsG Stuttgart, HRB 243294 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-16 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190614025316.7360-1-ming.lei@redhat.com>
2019-06-14 2:53 ` [PATCH V3 09/15] s390: zfcp_fc: use sg helper to operate scatterlist Ming Lei
2019-06-16 16:25 ` Benjamin Block
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox