* Re: linux-next: Tree for Jul 8 --> bootup failure on s390x (bisected) [not found] <20190708224238.60bd0aff@canb.auug.org.au> @ 2019-07-08 16:52 ` Christian Borntraeger 2019-07-08 18:06 ` Al Viro 0 siblings, 1 reply; 3+ messages in thread From: Christian Borntraeger @ 2019-07-08 16:52 UTC (permalink / raw) To: viro@zeniv.linux.org.uk Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Heiko Carstens, Vasily Gorbik, markward Al, linux-next July 8th fails to bootup on s390x (linux-next from July 4th did still work) [...] smp: Brought up 1 node, 1 CPU Unable to handle kernel pointer dereference in virtual kernel address space Failing address: 000000003a070000 TEID: 000000003a070407 Fault in home space mode while using kernel ASCE. AS:000000003a780007 R3:000000007ffd0007 S:000000007ffd4800 P:000000003a07021d Oops: 0004 ilc:2 [#1] SMP Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc5-00101-gcb8f0b366109 #14 Hardware name: IBM 2964 NC9 712 (KVM/Linux) Krnl PSW : 0704e00180000000 000000003974b580 (shmem_parse_monolithic+0x88/0x100) R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3 Krnl GPRS: 0000000000000000 000000000000003d 000000003a07040e 000000000000003d 000000003a07040f 000000000000006d 0000000000000001 0000000000000000 000000007f7c1c00 0000000000000000 000000003a07040a 0000000000000000 000000007f7e4000 000000003a190d78 000000003974b56c 000003e00031fd38 Krnl Code: 000000003974b574: b920002a cgr %r2,%r10 000000003974b578: a784001b brc 8,3974b5ae #000000003974b57c: 41402001 la %r4,1(%r2) >000000003974b580: 92002000 mvi 0(%r2),0 000000003974b584: a7090000 lghi %r0,0 000000003974b588: b9040014 lgr %r1,%r4 000000003974b58c: b25e0001 srst %r0,%r1 000000003974b590: a714fffe brc 1,3974b58c Call Trace: ([<000003e00031fd80>] 0x3e00031fd80) [<0000000039811662>] vfs_kern_mount.part.0+0x9a/0xc8 [<000000003a302fc0>] devtmpfs_init+0x38/0x140 [<000000003a302e0a>] driver_init+0x22/0x60 [<000000003a2beff8>] kernel_init_freeable+0x298/0x4f0 [<0000000039e7b53a>] kernel_init+0x22/0x148 [<0000000039e87b70>] ret_from_fork+0x30/0x34 [<0000000039e87b74>] kernel_thread_starter+0x0/0xc INFO: lockdep is turned off. [...] bisect points to f6ab6e953ab3b37b10646aabede8d8731f54cc61 is the first bad commit commit f6ab6e953ab3b37b10646aabede8d8731f54cc61 Author: Al Viro <viro@zeniv.linux.org.uk> Date: Sat Jun 1 18:43:09 2019 -0400 devtmpfs: don't mix {ramfs,shmem}_fill_super() with mount_single() Create an internal-only type matching the current devtmpfs, never register it and have one kernel-internal mount done. That thing gets mounted only once, so it is free to use mount_nodev(). The "public" devtmpfs (the one we do register, and only after the internal mount of the real thing is done) simply gets and returns an extra reference to the internal superblock. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> :040000 040000 4874d86e78685322401d6284d458ae323620573c e3c5780581792df416a4c272b583f76b98321080 M drivers I can confirm that f6ab6e953ab3b37b10646aabede8d8731f54cc61 has the issue and f6ab6e953ab3b37b10646aabede8d8731f54cc61^ has not. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 8 --> bootup failure on s390x (bisected) 2019-07-08 16:52 ` linux-next: Tree for Jul 8 --> bootup failure on s390x (bisected) Christian Borntraeger @ 2019-07-08 18:06 ` Al Viro 2019-07-08 19:16 ` Christian Borntraeger 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2019-07-08 18:06 UTC (permalink / raw) To: Christian Borntraeger Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Heiko Carstens, Vasily Gorbik, markward On Mon, Jul 08, 2019 at 06:52:14PM +0200, Christian Borntraeger wrote: > smp: Brought up 1 node, 1 CPU > Unable to handle kernel pointer dereference in virtual kernel address space > Failing address: 000000003a070000 TEID: 000000003a070407 > Fault in home space mode while using kernel ASCE. > AS:000000003a780007 R3:000000007ffd0007 S:000000007ffd4800 P:000000003a07021d > Oops: 0004 ilc:2 [#1] SMP > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc5-00101-gcb8f0b366109 #14 > Hardware name: IBM 2964 NC9 712 (KVM/Linux) > Krnl PSW : 0704e00180000000 000000003974b580 (shmem_parse_monolithic+0x88/0x100) > R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3 > Krnl GPRS: 0000000000000000 000000000000003d 000000003a07040e 000000000000003d > 000000003a07040f 000000000000006d 0000000000000001 0000000000000000 > 000000007f7c1c00 0000000000000000 000000003a07040a 0000000000000000 > 000000007f7e4000 000000003a190d78 000000003974b56c 000003e00031fd38 > Krnl Code: 000000003974b574: b920002a cgr %r2,%r10 > 000000003974b578: a784001b brc 8,3974b5ae > #000000003974b57c: 41402001 la %r4,1(%r2) > >000000003974b580: 92002000 mvi 0(%r2),0 > 000000003974b584: a7090000 lghi %r0,0 > 000000003974b588: b9040014 lgr %r1,%r4 > 000000003974b58c: b25e0001 srst %r0,%r1 > 000000003974b590: a714fffe brc 1,3974b58c > Call Trace: > ([<000003e00031fd80>] 0x3e00031fd80) > [<0000000039811662>] vfs_kern_mount.part.0+0x9a/0xc8 > [<000000003a302fc0>] devtmpfs_init+0x38/0x140 > [<000000003a302e0a>] driver_init+0x22/0x60 > [<000000003a2beff8>] kernel_init_freeable+0x298/0x4f0 > [<0000000039e7b53a>] kernel_init+0x22/0x148 > [<0000000039e87b70>] ret_from_fork+0x30/0x34 > [<0000000039e87b74>] kernel_thread_starter+0x0/0xc > INFO: lockdep is turned off. > [...] Oh, fuck... OK, I understand what's going on; sorry, my fault. Could you verify that the following helps? diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c index 52312c665a38..30d0523014e0 100644 --- a/drivers/base/devtmpfs.c +++ b/drivers/base/devtmpfs.c @@ -431,9 +431,10 @@ static int devtmpfsd(void *p) */ int __init devtmpfs_init(void) { + char opts[] = "mode=0755"; int err; - mnt = vfs_kern_mount(&internal_fs_type, 0, "devtmpfs", "mode=0755"); + mnt = vfs_kern_mount(&internal_fs_type, 0, "devtmpfs", opts); if (IS_ERR(mnt)) { printk(KERN_ERR "devtmpfs: unable to create devtmpfs %ld\n", PTR_ERR(mnt)); ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 8 --> bootup failure on s390x (bisected) 2019-07-08 18:06 ` Al Viro @ 2019-07-08 19:16 ` Christian Borntraeger 0 siblings, 0 replies; 3+ messages in thread From: Christian Borntraeger @ 2019-07-08 19:16 UTC (permalink / raw) To: Al Viro Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Heiko Carstens, Vasily Gorbik, markward, linux-s390 On 08.07.19 20:06, Al Viro wrote: > On Mon, Jul 08, 2019 at 06:52:14PM +0200, Christian Borntraeger wrote: > >> smp: Brought up 1 node, 1 CPU >> Unable to handle kernel pointer dereference in virtual kernel address space >> Failing address: 000000003a070000 TEID: 000000003a070407 >> Fault in home space mode while using kernel ASCE. >> AS:000000003a780007 R3:000000007ffd0007 S:000000007ffd4800 P:000000003a07021d >> Oops: 0004 ilc:2 [#1] SMP >> Modules linked in: >> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.2.0-rc5-00101-gcb8f0b366109 #14 >> Hardware name: IBM 2964 NC9 712 (KVM/Linux) >> Krnl PSW : 0704e00180000000 000000003974b580 (shmem_parse_monolithic+0x88/0x100) >> R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3 >> Krnl GPRS: 0000000000000000 000000000000003d 000000003a07040e 000000000000003d >> 000000003a07040f 000000000000006d 0000000000000001 0000000000000000 >> 000000007f7c1c00 0000000000000000 000000003a07040a 0000000000000000 >> 000000007f7e4000 000000003a190d78 000000003974b56c 000003e00031fd38 >> Krnl Code: 000000003974b574: b920002a cgr %r2,%r10 >> 000000003974b578: a784001b brc 8,3974b5ae >> #000000003974b57c: 41402001 la %r4,1(%r2) >> >000000003974b580: 92002000 mvi 0(%r2),0 >> 000000003974b584: a7090000 lghi %r0,0 >> 000000003974b588: b9040014 lgr %r1,%r4 >> 000000003974b58c: b25e0001 srst %r0,%r1 >> 000000003974b590: a714fffe brc 1,3974b58c >> Call Trace: >> ([<000003e00031fd80>] 0x3e00031fd80) >> [<0000000039811662>] vfs_kern_mount.part.0+0x9a/0xc8 >> [<000000003a302fc0>] devtmpfs_init+0x38/0x140 >> [<000000003a302e0a>] driver_init+0x22/0x60 >> [<000000003a2beff8>] kernel_init_freeable+0x298/0x4f0 >> [<0000000039e7b53a>] kernel_init+0x22/0x148 >> [<0000000039e87b70>] ret_from_fork+0x30/0x34 >> [<0000000039e87b74>] kernel_thread_starter+0x0/0xc >> INFO: lockdep is turned off. >> [...] > > Oh, fuck... OK, I understand what's going on; sorry, my fault. Could you > verify that the following helps? Yes, it does. > > diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c > index 52312c665a38..30d0523014e0 100644 > --- a/drivers/base/devtmpfs.c > +++ b/drivers/base/devtmpfs.c > @@ -431,9 +431,10 @@ static int devtmpfsd(void *p) > */ > int __init devtmpfs_init(void) > { > + char opts[] = "mode=0755"; > int err; > > - mnt = vfs_kern_mount(&internal_fs_type, 0, "devtmpfs", "mode=0755"); > + mnt = vfs_kern_mount(&internal_fs_type, 0, "devtmpfs", opts); > if (IS_ERR(mnt)) { > printk(KERN_ERR "devtmpfs: unable to create devtmpfs %ld\n", > PTR_ERR(mnt)); > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-08 19:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190708224238.60bd0aff@canb.auug.org.au>
2019-07-08 16:52 ` linux-next: Tree for Jul 8 --> bootup failure on s390x (bisected) Christian Borntraeger
2019-07-08 18:06 ` Al Viro
2019-07-08 19:16 ` Christian Borntraeger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox