Re: [kvm-unit-tests PATCH v6 4/4] s390x: SCLP unit test

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Thu, 9 Jan 2020 18:44:34 +0100
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 1/9/20 5:16 PM, Claudio Imbrenda wrote:
> > SCLP unit test. Testing the following:
> > 
> > * Correctly ignoring instruction bits that should be ignored
> > * Privileged instruction check
> > * Check for addressing exceptions
> > * Specification exceptions:
> >   - SCCB size less than 8
> >   - SCCB unaligned
> >   - SCCB overlaps prefix or lowcore
> >   - SCCB address higher than 2GB
> > * Return codes for
> >   - Invalid command
> >   - SCCB too short (but at least 8)
> >   - SCCB page boundary violation
> > 
> > Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>  
> 
> I wonder how fast this will run under z/VM and if we need to increase
> the timeout.

I don't know, but it runs pretty fast even on z13

> Nicely done, one comment below.
> 
> Acked-by: Janosch Frank <frankja@linux.ibm.com>

[...]

> LC_SIZE?
> Can also be used in more places below.

hmm yes I'll fix it