From: Cornelia Huck <cohuck@redhat.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Jason Herne <jjherne@linux.ibm.com>,
Jared Rossi <jrossi@linux.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH v2 9/9] vfio-ccw: Remove inline get_schid() routine
Date: Fri, 14 Feb 2020 14:27:06 +0100 [thread overview]
Message-ID: <20200214142706.4d6a1efc.cohuck@redhat.com> (raw)
In-Reply-To: <20200206213825.11444-10-farman@linux.ibm.com>
On Thu, 6 Feb 2020 22:38:25 +0100
Eric Farman <farman@linux.ibm.com> wrote:
> This seems misplaced in the middle of FSM, returning the schid
> field from inside the private struct. We could move this macro
> into vfio_ccw_private.h, but this doesn't seem to simplify things
> that much. Let's just remove it, and use the field directly.
It had been introduced with the first set of traces, I'm now wondering
why, as it doesn't do any checking.
>
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_fsm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
next prev parent reply other threads:[~2020-02-14 13:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 21:38 [RFC PATCH v2 0/9] s390x/vfio-ccw: Channel Path Handling Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 1/9] vfio-ccw: Introduce new helper functions to free/destroy regions Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 2/9] vfio-ccw: Register a chp_event callback for vfio-ccw Eric Farman
2020-02-14 12:11 ` Cornelia Huck
2020-02-14 16:35 ` Eric Farman
2020-03-24 15:58 ` Cornelia Huck
2020-03-26 2:09 ` Eric Farman
2020-03-26 6:47 ` Cornelia Huck
2020-03-26 11:54 ` Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 3/9] vfio-ccw: Refactor the unregister of the async regions Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 4/9] vfio-ccw: Introduce a new schib region Eric Farman
2020-02-14 12:32 ` Cornelia Huck
2020-02-14 14:29 ` Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 5/9] vfio-ccw: Introduce a new CRW region Eric Farman
2020-04-06 13:40 ` Cornelia Huck
2020-04-06 21:43 ` Eric Farman
2020-04-07 6:30 ` Cornelia Huck
2020-02-06 21:38 ` [RFC PATCH v2 6/9] vfio-ccw: Refactor IRQ handlers Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 7/9] vfio-ccw: Wire up the CRW irq and CRW region Eric Farman
2020-02-14 13:34 ` Cornelia Huck
2020-02-14 16:24 ` Eric Farman
2020-03-24 16:34 ` Cornelia Huck
2020-03-26 18:51 ` Eric Farman
2020-04-06 13:52 ` Cornelia Huck
2020-04-06 22:11 ` Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 8/9] vfio-ccw: Add trace for CRW event Eric Farman
2020-02-06 21:38 ` [RFC PATCH v2 9/9] vfio-ccw: Remove inline get_schid() routine Eric Farman
2020-02-14 13:27 ` Cornelia Huck [this message]
2020-02-14 14:27 ` Eric Farman
2020-02-07 9:12 ` [RFC PATCH v2 0/9] s390x/vfio-ccw: Channel Path Handling Cornelia Huck
2020-02-07 13:26 ` Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214142706.4d6a1efc.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=jrossi@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox