* [PATCH net] net/smc: check for valid ib_client_data
@ 2020-02-26 16:52 Karsten Graul
2020-02-27 4:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Karsten Graul @ 2020-02-26 16:52 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, heiko.carstens, raspl, ubraun
In smc_ib_remove_dev() check if the provided ib device was actually
initialized for SMC before.
Reported-by: syzbot+84484ccebdd4e5451d91@syzkaller.appspotmail.com
Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client")
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
---
net/smc/smc_ib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/smc/smc_ib.c b/net/smc/smc_ib.c
index 6756bd5a3fe4..da18871f360f 100644
--- a/net/smc/smc_ib.c
+++ b/net/smc/smc_ib.c
@@ -587,6 +587,8 @@ static void smc_ib_remove_dev(struct ib_device *ibdev, void *client_data)
struct smc_ib_device *smcibdev;
smcibdev = ib_get_client_data(ibdev, &smc_ib_client);
+ if (!smcibdev || smcibdev->ibdev != ibdev)
+ return;
ib_set_client_data(ibdev, &smc_ib_client, NULL);
spin_lock(&smc_ib_devices.lock);
list_del_init(&smcibdev->list); /* remove from smc_ib_devices */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net/smc: check for valid ib_client_data
2020-02-26 16:52 [PATCH net] net/smc: check for valid ib_client_data Karsten Graul
@ 2020-02-27 4:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-27 4:57 UTC (permalink / raw)
To: kgraul; +Cc: netdev, linux-s390, heiko.carstens, raspl, ubraun
From: Karsten Graul <kgraul@linux.ibm.com>
Date: Wed, 26 Feb 2020 17:52:46 +0100
> In smc_ib_remove_dev() check if the provided ib device was actually
> initialized for SMC before.
>
> Reported-by: syzbot+84484ccebdd4e5451d91@syzkaller.appspotmail.com
> Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client")
> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 4:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-26 16:52 [PATCH net] net/smc: check for valid ib_client_data Karsten Graul
2020-02-27 4:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox