* Re: linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use
[not found] <20200504173547.2cdd83bf@canb.auug.org.au>
@ 2020-05-04 14:50 ` Christian Borntraeger
2020-05-04 15:44 ` Mike Rapoport
0 siblings, 1 reply; 4+ messages in thread
From: Christian Borntraeger @ 2020-05-04 14:50 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, Mike Rapoport
Mike,
commit 51a2f644fd020d5f090044825c388444d11029d ("mm: free_area_init: allow defining max_zone_pfn in descending order")
does increase the memory use on s390 (e.g. 700 MB vs.1.8 GB).
Something is odd in this patch. Any idea?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use
2020-05-04 14:50 ` linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use Christian Borntraeger
@ 2020-05-04 15:44 ` Mike Rapoport
2020-05-04 21:08 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2020-05-04 15:44 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, Andrew Morton, Marc Hartmayer,
linux-s390, Vasily Gorbik, Heiko Carstens
Ho Christian,
On Mon, May 04, 2020 at 04:50:06PM +0200, Christian Borntraeger wrote:
> Mike,
> commit 51a2f644fd020d5f090044825c388444d11029d ("mm: free_area_init: allow defining max_zone_pfn in descending order")
> does increase the memory use on s390 (e.g. 700 MB vs.1.8 GB).
>
> Something is odd in this patch. Any idea?
Yeah, this patch is buggy. In short, it breaks zone size calculation on
s390 and some other architectures.
I've just replied at [1] with more details and a fix.
[1] https://lore.kernel.org/linux-mm/20200504153901.GM14260@kernel.org/
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use
2020-05-04 15:44 ` Mike Rapoport
@ 2020-05-04 21:08 ` Stephen Rothwell
2020-05-05 9:36 ` Christian Borntraeger
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-05-04 21:08 UTC (permalink / raw)
To: Mike Rapoport
Cc: Christian Borntraeger, Linux Next Mailing List,
Linux Kernel Mailing List, Andrew Morton, Marc Hartmayer,
linux-s390, Vasily Gorbik, Heiko Carstens
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
Hi Mike,
On Mon, 4 May 2020 18:44:10 +0300 Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> Ho Christian,
>
> On Mon, May 04, 2020 at 04:50:06PM +0200, Christian Borntraeger wrote:
> > Mike,
> > commit 51a2f644fd020d5f090044825c388444d11029d ("mm: free_area_init: allow defining max_zone_pfn in descending order")
> > does increase the memory use on s390 (e.g. 700 MB vs.1.8 GB).
> >
> > Something is odd in this patch. Any idea?
>
> Yeah, this patch is buggy. In short, it breaks zone size calculation on
> s390 and some other architectures.
>
> I've just replied at [1] with more details and a fix.
>
> [1] https://lore.kernel.org/linux-mm/20200504153901.GM14260@kernel.org/
I have added that to linux-next for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use
2020-05-04 21:08 ` Stephen Rothwell
@ 2020-05-05 9:36 ` Christian Borntraeger
0 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2020-05-05 9:36 UTC (permalink / raw)
To: Stephen Rothwell, Mike Rapoport
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andrew Morton,
Marc Hartmayer, linux-s390, Vasily Gorbik, Heiko Carstens
On 04.05.20 23:08, Stephen Rothwell wrote:
> Hi Mike,
>
> On Mon, 4 May 2020 18:44:10 +0300 Mike Rapoport <rppt@linux.ibm.com> wrote:
>>
>> Ho Christian,
>>
>> On Mon, May 04, 2020 at 04:50:06PM +0200, Christian Borntraeger wrote:
>>> Mike,
>>> commit 51a2f644fd020d5f090044825c388444d11029d ("mm: free_area_init: allow defining max_zone_pfn in descending order")
>>> does increase the memory use on s390 (e.g. 700 MB vs.1.8 GB).
>>>
>>> Something is odd in this patch. Any idea?
>>
>> Yeah, this patch is buggy. In short, it breaks zone size calculation on
>> s390 and some other architectures.
>>
>> I've just replied at [1] with more details and a fix.
>>
>> [1] https://lore.kernel.org/linux-mm/20200504153901.GM14260@kernel.org/
>
> I have added that to linux-next for today.
>
Ack, 5.7.0-rc4-next-20200505 seems to work fine.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-05 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200504173547.2cdd83bf@canb.auug.org.au>
2020-05-04 14:50 ` linux-next: Tree for May 4 --> mm: free_area_init: allow defining max_zone_pfn in descending order does increase memory use Christian Borntraeger
2020-05-04 15:44 ` Mike Rapoport
2020-05-04 21:08 ` Stephen Rothwell
2020-05-05 9:36 ` Christian Borntraeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox