From: Christoph Hellwig <hch@lst.de>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Harald Freudenberger <freude@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 2/4] s390/dis: get rid of set_fs() usage
Date: Tue, 15 Sep 2020 17:52:17 +0200 [thread overview]
Message-ID: <20200915155217.GA22056@lst.de> (raw)
In-Reply-To: <20200915154340.4215-3-hca@linux.ibm.com>
On Tue, Sep 15, 2020 at 05:43:38PM +0200, Heiko Carstens wrote:
> + if (user_mode(regs)) {
> + if (__copy_from_user(code + start - 2, (char __user *)addr, 2))
> + break;
> + } else {
> + if (copy_from_kernel_nofault(code + start - 2, (char *)addr, 2))
> + break;
> + }
> for (end = 32; end < 64; end += 2) {
> addr = regs->psw.addr + end - 32;
> + if (user_mode(regs)) {
> + if (__copy_from_user(code + end, (char __user *)addr, 2))
> + break;
> + } else {
> + if (copy_from_kernel_nofault(code + end, (char *)addr, 2))
> + break;
> + }
Maybe add a little copy_from_regs helper? That would also get rid
of the awfully long lines here.
Also any good reason for the __copy_from_user instead of the normal
copy_from_user here?
next prev parent reply other threads:[~2020-09-15 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 15:43 [PATCH 0/4] s390: set_fs() removal Heiko Carstens
2020-09-15 15:43 ` [PATCH 1/4] s390/zcrypt: remove set_fs() invocation in zcrypt device driver Heiko Carstens
2020-09-15 15:43 ` [PATCH 2/4] s390/dis: get rid of set_fs() usage Heiko Carstens
2020-09-15 15:52 ` Christoph Hellwig [this message]
2020-09-15 16:55 ` Heiko Carstens
2020-09-15 15:43 ` [PATCH 3/4] s390/uaccess: implement HAVE_GET_KERNEL_NOFAULT support Heiko Carstens
2020-09-15 15:43 ` [PATCH 4/4] s390/uaccess: remove set_fs() interface Heiko Carstens
2020-09-15 16:02 ` Christoph Hellwig
2020-09-15 16:49 ` Heiko Carstens
2020-09-15 19:37 ` Heiko Carstens
2020-09-16 12:36 ` Heiko Carstens
2020-11-25 8:38 ` Christoph Hellwig
2020-11-25 8:51 ` Christian Borntraeger
2020-11-25 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915155217.GA22056@lst.de \
--to=hch@lst.de \
--cc=borntraeger@de.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox