public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Vineeth Vijayan <vneethv@linux.ibm.com>
To: oberpar@linux.ibm.com, christian.ehrhardt@canonical.com,
	borntraeger@de.ibm.com, linux-s390@vger.kernel.org
Subject: [PATCH] s390/cio: Remove the invalid condition on IO_SCH_UNREG
Date: Fri, 23 Apr 2021 12:08:43 +0200	[thread overview]
Message-ID: <20210423100843.2230969-1-vneethv@linux.ibm.com> (raw)

The condition to check the cdev pointer validity on
css_sch_device_unregister() is a leftover from the 'commit c97cd8c81d4a
("s390/cio: Remove pm support from ccw bus driver")'. This could lead to a
situation, where detaching the disk is not happening completely. Remove
this invalid condition in the IO_SCH_UNREG case.

Fixes: 8cc0dcfdc1c0 ("s390/cio: remove pm support from ccw bus driver")
Reported-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Vineeth Vijayan <vneethv@linux.ibm.com>
---
 drivers/s390/cio/device.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c
index 3f026021e95e..84f659cafe76 100644
--- a/drivers/s390/cio/device.c
+++ b/drivers/s390/cio/device.c
@@ -1532,8 +1532,7 @@ static int io_subchannel_sch_event(struct subchannel *sch, int process)
 	switch (action) {
 	case IO_SCH_ORPH_UNREG:
 	case IO_SCH_UNREG:
-		if (!cdev)
-			css_sch_device_unregister(sch);
+		css_sch_device_unregister(sch);
 		break;
 	case IO_SCH_ORPH_ATTACH:
 	case IO_SCH_UNREG_ATTACH:
-- 
2.25.1


             reply	other threads:[~2021-04-23 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:08 Vineeth Vijayan [this message]
2021-04-26  6:03 ` [PATCH] s390/cio: Remove the invalid condition on IO_SCH_UNREG Julian Wiedmann
2021-04-26 12:38 ` Peter Oberparleiter
2021-04-26 16:24 ` Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423100843.2230969-1-vneethv@linux.ibm.com \
    --to=vneethv@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox