From: Peter Oberparleiter <oberpar@linux.ibm.com>
To: Vineeth Vijayan <vneethv@linux.ibm.com>,
christian.ehrhardt@canonical.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390/cio: Remove the invalid condition on IO_SCH_UNREG
Date: Mon, 26 Apr 2021 14:38:20 +0200 [thread overview]
Message-ID: <ca1e885c-0cc4-8e66-e05f-a1af62f1b3c9@linux.ibm.com> (raw)
In-Reply-To: <20210423100843.2230969-1-vneethv@linux.ibm.com>
On 23.04.2021 12:08, Vineeth Vijayan wrote:
> The condition to check the cdev pointer validity on
> css_sch_device_unregister() is a leftover from the 'commit c97cd8c81d4a
> ("s390/cio: Remove pm support from ccw bus driver")'. This could lead to a
> situation, where detaching the disk is not happening completely. Remove
This applies to all devices types, not just disks. So replace "disk"
with either "device" or "subchannel".
> this invalid condition in the IO_SCH_UNREG case.
>
> Fixes: 8cc0dcfdc1c0 ("s390/cio: remove pm support from ccw bus driver")
> Reported-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Suggested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
--
Peter Oberparleiter
Linux on Z Development - IBM Germany
next prev parent reply other threads:[~2021-04-26 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 10:08 [PATCH] s390/cio: Remove the invalid condition on IO_SCH_UNREG Vineeth Vijayan
2021-04-26 6:03 ` Julian Wiedmann
2021-04-26 12:38 ` Peter Oberparleiter [this message]
2021-04-26 16:24 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1e885c-0cc4-8e66-e05f-a1af62f1b3c9@linux.ibm.com \
--to=oberpar@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=christian.ehrhardt@canonical.com \
--cc=linux-s390@vger.kernel.org \
--cc=vneethv@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox