From: Eric Farman <farman@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
Eric Farman <farman@linux.ibm.com>
Subject: [PATCH kvm-unit-tests v2 0/6] s390x SIGP fixes
Date: Fri, 11 Mar 2022 18:38:16 +0100 [thread overview]
Message-ID: <20220311173822.1234617-1-farman@linux.ibm.com> (raw)
Hi all,
Here is a second version of the SIGNAL PROCESSOR tests, addressing
the comments that were made to v1.
The biggest change is Patch 6, which has effectively been replaced.
Considering comments from Nico and Janosch, and making sure
consumers of smp_sigp get their SIGP retried, I opted to convert
smp_sigp() to perform the CC2 retry under the covers, and remove
smp_sigp_retry() itself. This effectively reverts patch 1, but I
thought the end result was cleaner and less prone to confusion
going forward. If a test needs a no-retry interface going forward,
that would be one thing, but the only places that do that are
the testing of STOP and RESTART itself, which handle this as seen
in patches 4 and 5.
So, thoughts?
v2:
- Patch 1-2: Applied r-b from Claudio, Janosch, and Nico (thank you!)
- [JF] Patch 3: Clarified commit message that it's dealing with semantics
rather than a bugfix.
- [NB] Patch 4-5: Added return code checks of the _nowait() routines
(Claudio: I appreciate the r-b on 4, but didn't apply it because of the
new checks that were made here)
- [EF] Patch 4-5: Use the non-retry sigp() call directly, rather than
smp_sigp()
v1: https://lore.kernel.org/r/20220303210425.1693486-1-farman@linux.ibm.com/
Eric Farman (6):
lib: s390x: smp: Retry SIGP SENSE on CC2
s390x: smp: Test SIGP RESTART against stopped CPU
s390x: smp: Fix checks for SIGP STOP STORE STATUS
s390x: smp: Create and use a non-waiting CPU stop
s390x: smp: Create and use a non-waiting CPU restart
lib: s390x: smp: Remove smp_sigp_retry
lib/s390x/smp.c | 63 ++++++++++++++++++++++++++++++++++++++++++-------
lib/s390x/smp.h | 3 ++-
s390x/smp.c | 53 +++++++++++++++++++++++++----------------
3 files changed, 89 insertions(+), 30 deletions(-)
--
2.32.0
next reply other threads:[~2022-03-11 17:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 17:38 Eric Farman [this message]
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 1/6] lib: s390x: smp: Retry SIGP SENSE on CC2 Eric Farman
2022-03-24 8:08 ` Thomas Huth
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 2/6] s390x: smp: Test SIGP RESTART against stopped CPU Eric Farman
2022-03-24 8:15 ` Thomas Huth
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 3/6] s390x: smp: Fix checks for SIGP STOP STORE STATUS Eric Farman
2022-03-15 6:39 ` Nico Boehr
2022-03-15 17:39 ` Claudio Imbrenda
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 4/6] s390x: smp: Create and use a non-waiting CPU stop Eric Farman
2022-03-15 6:45 ` Nico Boehr
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 5/6] s390x: smp: Create and use a non-waiting CPU restart Eric Farman
2022-03-15 6:51 ` Nico Boehr
2022-03-21 7:43 ` Janosch Frank
2022-03-11 17:38 ` [PATCH kvm-unit-tests v2 6/6] lib: s390x: smp: Remove smp_sigp_retry Eric Farman
2022-03-15 7:20 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311173822.1234617-1-farman@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox