* [PATCH v2] s390/kvm: avoid hypfs error message
@ 2022-06-20 9:45 Juergen Gross
2022-06-20 9:47 ` Heiko Carstens
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Juergen Gross @ 2022-06-20 9:45 UTC (permalink / raw)
To: linux-s390, linux-kernel
Cc: Juergen Gross, Heiko Carstens, Vasily Gorbik, Alexander Gordeev,
Christian Borntraeger, Sven Schnelle
When booting under KVM the following error messages are issued:
hypfs.7f5705: The hardware system does not support hypfs
hypfs.7a79f0: Initialization of hypfs failed with rc=-61
Demote the severity of first message from "error" to "info" and issue
the second message only in other error cases.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V2:
- don't bail out if KVM, but avoid error messages instead (Christian
Borntraeger)
---
arch/s390/hypfs/hypfs_diag.c | 2 +-
arch/s390/hypfs/inode.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
index f0bc4dc3e9bf..6511d15ace45 100644
--- a/arch/s390/hypfs/hypfs_diag.c
+++ b/arch/s390/hypfs/hypfs_diag.c
@@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
int rc;
if (diag204_probe()) {
- pr_err("The hardware system does not support hypfs\n");
+ pr_info("The hardware system does not support hypfs\n");
return -ENODATA;
}
diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
index 5c97f48cea91..ee919bfc8186 100644
--- a/arch/s390/hypfs/inode.c
+++ b/arch/s390/hypfs/inode.c
@@ -496,9 +496,9 @@ static int __init hypfs_init(void)
hypfs_vm_exit();
fail_hypfs_diag_exit:
hypfs_diag_exit();
+ pr_err("Initialization of hypfs failed with rc=%i\n", rc);
fail_dbfs_exit:
hypfs_dbfs_exit();
- pr_err("Initialization of hypfs failed with rc=%i\n", rc);
return rc;
}
device_initcall(hypfs_init)
--
2.35.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] s390/kvm: avoid hypfs error message
2022-06-20 9:45 [PATCH v2] s390/kvm: avoid hypfs error message Juergen Gross
@ 2022-06-20 9:47 ` Heiko Carstens
2022-06-20 9:48 ` Christian Borntraeger
2022-06-20 11:31 ` Alexander Gordeev
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Carstens @ 2022-06-20 9:47 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-s390, linux-kernel, Vasily Gorbik, Alexander Gordeev,
Christian Borntraeger, Sven Schnelle
On Mon, Jun 20, 2022 at 11:45:34AM +0200, Juergen Gross wrote:
> When booting under KVM the following error messages are issued:
>
> hypfs.7f5705: The hardware system does not support hypfs
> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>
> Demote the severity of first message from "error" to "info" and issue
> the second message only in other error cases.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> V2:
> - don't bail out if KVM, but avoid error messages instead (Christian
> Borntraeger)
> ---
> arch/s390/hypfs/hypfs_diag.c | 2 +-
> arch/s390/hypfs/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] s390/kvm: avoid hypfs error message
2022-06-20 9:45 [PATCH v2] s390/kvm: avoid hypfs error message Juergen Gross
2022-06-20 9:47 ` Heiko Carstens
@ 2022-06-20 9:48 ` Christian Borntraeger
2022-06-20 11:31 ` Alexander Gordeev
2 siblings, 0 replies; 6+ messages in thread
From: Christian Borntraeger @ 2022-06-20 9:48 UTC (permalink / raw)
To: Juergen Gross, linux-s390, linux-kernel
Cc: Heiko Carstens, Vasily Gorbik, Alexander Gordeev, Sven Schnelle
Am 20.06.22 um 11:45 schrieb Juergen Gross:
> When booting under KVM the following error messages are issued:
>
> hypfs.7f5705: The hardware system does not support hypfs
> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>
> Demote the severity of first message from "error" to "info" and issue
> the second message only in other error cases.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> ---
> V2:
> - don't bail out if KVM, but avoid error messages instead (Christian
> Borntraeger)
> ---
> arch/s390/hypfs/hypfs_diag.c | 2 +-
> arch/s390/hypfs/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
> index f0bc4dc3e9bf..6511d15ace45 100644
> --- a/arch/s390/hypfs/hypfs_diag.c
> +++ b/arch/s390/hypfs/hypfs_diag.c
> @@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
> int rc;
>
> if (diag204_probe()) {
> - pr_err("The hardware system does not support hypfs\n");
> + pr_info("The hardware system does not support hypfs\n");
> return -ENODATA;
> }
>
> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
> index 5c97f48cea91..ee919bfc8186 100644
> --- a/arch/s390/hypfs/inode.c
> +++ b/arch/s390/hypfs/inode.c
> @@ -496,9 +496,9 @@ static int __init hypfs_init(void)
> hypfs_vm_exit();
> fail_hypfs_diag_exit:
> hypfs_diag_exit();
> + pr_err("Initialization of hypfs failed with rc=%i\n", rc);
> fail_dbfs_exit:
> hypfs_dbfs_exit();
> - pr_err("Initialization of hypfs failed with rc=%i\n", rc);
> return rc;
> }
> device_initcall(hypfs_init)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] s390/kvm: avoid hypfs error message
2022-06-20 9:45 [PATCH v2] s390/kvm: avoid hypfs error message Juergen Gross
2022-06-20 9:47 ` Heiko Carstens
2022-06-20 9:48 ` Christian Borntraeger
@ 2022-06-20 11:31 ` Alexander Gordeev
2022-08-11 8:14 ` Juergen Gross
2 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2022-06-20 11:31 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-s390, linux-kernel, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Sven Schnelle
On Mon, Jun 20, 2022 at 11:45:34AM +0200, Juergen Gross wrote:
> When booting under KVM the following error messages are issued:
>
> hypfs.7f5705: The hardware system does not support hypfs
> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>
> Demote the severity of first message from "error" to "info" and issue
> the second message only in other error cases.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Applied, thanks!
> ---
> V2:
> - don't bail out if KVM, but avoid error messages instead (Christian
> Borntraeger)
> ---
> arch/s390/hypfs/hypfs_diag.c | 2 +-
> arch/s390/hypfs/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
> index f0bc4dc3e9bf..6511d15ace45 100644
> --- a/arch/s390/hypfs/hypfs_diag.c
> +++ b/arch/s390/hypfs/hypfs_diag.c
> @@ -437,7 +437,7 @@ __init int hypfs_diag_init(void)
> int rc;
>
> if (diag204_probe()) {
> - pr_err("The hardware system does not support hypfs\n");
> + pr_info("The hardware system does not support hypfs\n");
> return -ENODATA;
> }
>
> diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
> index 5c97f48cea91..ee919bfc8186 100644
> --- a/arch/s390/hypfs/inode.c
> +++ b/arch/s390/hypfs/inode.c
> @@ -496,9 +496,9 @@ static int __init hypfs_init(void)
> hypfs_vm_exit();
> fail_hypfs_diag_exit:
> hypfs_diag_exit();
> + pr_err("Initialization of hypfs failed with rc=%i\n", rc);
> fail_dbfs_exit:
> hypfs_dbfs_exit();
> - pr_err("Initialization of hypfs failed with rc=%i\n", rc);
> return rc;
> }
> device_initcall(hypfs_init)
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] s390/kvm: avoid hypfs error message
2022-06-20 11:31 ` Alexander Gordeev
@ 2022-08-11 8:14 ` Juergen Gross
2022-08-11 14:49 ` Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2022-08-11 8:14 UTC (permalink / raw)
To: Alexander Gordeev
Cc: linux-s390, linux-kernel, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Sven Schnelle
[-- Attachment #1.1.1: Type: text/plain, Size: 641 bytes --]
On 20.06.22 13:31, Alexander Gordeev wrote:
> On Mon, Jun 20, 2022 at 11:45:34AM +0200, Juergen Gross wrote:
>> When booting under KVM the following error messages are issued:
>>
>> hypfs.7f5705: The hardware system does not support hypfs
>> hypfs.7a79f0: Initialization of hypfs failed with rc=-61
>>
>> Demote the severity of first message from "error" to "info" and issue
>> the second message only in other error cases.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Applied, thanks!
Hmm, applied to which tree and branch?
I would have thought this patch should have reached upstream by now...
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] s390/kvm: avoid hypfs error message
2022-08-11 8:14 ` Juergen Gross
@ 2022-08-11 14:49 ` Alexander Gordeev
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2022-08-11 14:49 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-s390, linux-kernel, Heiko Carstens, Vasily Gorbik,
Christian Borntraeger, Sven Schnelle
On Thu, Aug 11, 2022 at 10:14:55AM +0200, Juergen Gross wrote:
> On 20.06.22 13:31, Alexander Gordeev wrote:
> > Applied, thanks!
>
> Hmm, applied to which tree and branch?
>
> I would have thought this patch should have reached upstream by now...
Hi Juergen,
This one is going to land in -rc2 or -rc3 most likely.
Thanks!
> Juergen
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-11 14:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-20 9:45 [PATCH v2] s390/kvm: avoid hypfs error message Juergen Gross
2022-06-20 9:47 ` Heiko Carstens
2022-06-20 9:48 ` Christian Borntraeger
2022-06-20 11:31 ` Alexander Gordeev
2022-08-11 8:14 ` Juergen Gross
2022-08-11 14:49 ` Alexander Gordeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox